[webkit-changes] [201754] trunk/Source/JavaScriptCore

Tue, 07 Jun 2016 09:26:30 -0700

Title: [201754] trunk/Source/_javascript_Core
Revision
201754
Author
[email protected]
Date
2016-06-07 09:19:59 -0700 (Tue, 07 Jun 2016)

Log Message

Unskip generator related stress tests
https://bugs.webkit.org/show_bug.cgi?id=158461

Patch by Joseph Pecoraro <[email protected]> on 2016-06-07
Reviewed by Darin Adler.

* tests/stress/generator-methods.js:
* tests/stress/generator-syntax.js:
* tests/stress/yield-and-line-terminator.js:
* tests/stress/yield-label-generator.js:
* tests/stress/yield-named-accessors-generator.js:
* tests/stress/yield-named-variable-generator.js:
* tests/stress/yield-out-of-generator.js:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (201753 => 201754)


--- trunk/Source/_javascript_Core/ChangeLog	2016-06-07 15:47:30 UTC (rev 201753)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-06-07 16:19:59 UTC (rev 201754)
@@ -1,3 +1,18 @@
+2016-06-07  Joseph Pecoraro  <[email protected]>
+
+        Unskip generator related stress tests
+        https://bugs.webkit.org/show_bug.cgi?id=158461
+
+        Reviewed by Darin Adler.
+
+        * tests/stress/generator-methods.js:
+        * tests/stress/generator-syntax.js:
+        * tests/stress/yield-and-line-terminator.js:
+        * tests/stress/yield-label-generator.js:
+        * tests/stress/yield-named-accessors-generator.js:
+        * tests/stress/yield-named-variable-generator.js:
+        * tests/stress/yield-out-of-generator.js:
+
 2016-06-06  Joseph Pecoraro  <[email protected]>
 
         Fix typo in test name trailing-comma-in-function-paramters.js

Modified: trunk/Source/_javascript_Core/tests/stress/generator-methods.js (201753 => 201754)


--- trunk/Source/_javascript_Core/tests/stress/generator-methods.js	2016-06-07 15:47:30 UTC (rev 201753)
+++ trunk/Source/_javascript_Core/tests/stress/generator-methods.js	2016-06-07 16:19:59 UTC (rev 201754)
@@ -1,4 +1,3 @@
-//@ skip
 class Hello {
     *gen() {
         yield;

Modified: trunk/Source/_javascript_Core/tests/stress/generator-syntax.js (201753 => 201754)


--- trunk/Source/_javascript_Core/tests/stress/generator-syntax.js	2016-06-07 15:47:30 UTC (rev 201753)
+++ trunk/Source/_javascript_Core/tests/stress/generator-syntax.js	2016-06-07 16:19:59 UTC (rev 201754)
@@ -1,4 +1,6 @@
+// <https://webkit.org/b/158460> Clarify SyntaxErrors around yield and unskip tests
 //@ skip
+
 function testSyntax(script) {
     try {
         eval(script);

Modified: trunk/Source/_javascript_Core/tests/stress/yield-and-line-terminator.js (201753 => 201754)


--- trunk/Source/_javascript_Core/tests/stress/yield-and-line-terminator.js	2016-06-07 15:47:30 UTC (rev 201753)
+++ trunk/Source/_javascript_Core/tests/stress/yield-and-line-terminator.js	2016-06-07 16:19:59 UTC (rev 201754)
@@ -1,4 +1,3 @@
-//@ skip
 function testSyntax(script) {
     try {
         eval(script);

Modified: trunk/Source/_javascript_Core/tests/stress/yield-label-generator.js (201753 => 201754)


--- trunk/Source/_javascript_Core/tests/stress/yield-label-generator.js	2016-06-07 15:47:30 UTC (rev 201753)
+++ trunk/Source/_javascript_Core/tests/stress/yield-label-generator.js	2016-06-07 16:19:59 UTC (rev 201754)
@@ -1,5 +1,3 @@
-//@ skip
-
 function testSyntax(script) {
     try {
         eval(script);

Modified: trunk/Source/_javascript_Core/tests/stress/yield-named-accessors-generator.js (201753 => 201754)


--- trunk/Source/_javascript_Core/tests/stress/yield-named-accessors-generator.js	2016-06-07 15:47:30 UTC (rev 201753)
+++ trunk/Source/_javascript_Core/tests/stress/yield-named-accessors-generator.js	2016-06-07 16:19:59 UTC (rev 201754)
@@ -1,4 +1,3 @@
-//@ skip
 function *t1() {
     let object = {
         get yield() {

Modified: trunk/Source/_javascript_Core/tests/stress/yield-named-variable-generator.js (201753 => 201754)


--- trunk/Source/_javascript_Core/tests/stress/yield-named-variable-generator.js	2016-06-07 15:47:30 UTC (rev 201753)
+++ trunk/Source/_javascript_Core/tests/stress/yield-named-variable-generator.js	2016-06-07 16:19:59 UTC (rev 201754)
@@ -1,4 +1,3 @@
-//@ skip
 function testSyntax(script) {
     try {
         eval(script);
@@ -31,12 +30,12 @@
 function *t1() {
     let yield = 20;
 }
-`, `SyntaxError: Cannot use the keyword 'yield' as a variable name.`);
+`, `SyntaxError: Cannot use the keyword 'yield' as a lexical variable name.`);
 testSyntaxError(`
 function *t1() {
     const yield = 20;
 }
-`, `SyntaxError: Cannot use the keyword 'yield' as a variable name.`);
+`, `SyntaxError: Cannot use the keyword 'yield' as a lexical variable name.`);
 
 testSyntaxError(`
 function *t1() {
@@ -63,12 +62,12 @@
 function *t1() {
     let { i: yield } = 20;
 }
-`, `SyntaxError: Cannot use the keyword 'yield' as a variable name.`);
+`, `SyntaxError: Cannot use the keyword 'yield' as a lexical variable name.`);
 testSyntaxError(`
 function *t1() {
     const { i: yield } = 20;
 }
-`, `SyntaxError: Cannot use the keyword 'yield' as a variable name.`);
+`, `SyntaxError: Cannot use the keyword 'yield' as a lexical variable name.`);
 
 testSyntaxError(`
 function *t1() {
@@ -79,12 +78,12 @@
 function *t1() {
     let [ yield ] = 20;
 }
-`, `SyntaxError: Cannot use the keyword 'yield' as a variable name.`);
+`, `SyntaxError: Cannot use the keyword 'yield' as a lexical variable name.`);
 testSyntaxError(`
 function *t1() {
     const [ yield ] = 20;
 }
-`, `SyntaxError: Cannot use the keyword 'yield' as a variable name.`);
+`, `SyntaxError: Cannot use the keyword 'yield' as a lexical variable name.`);
 
 testSyntaxError(`
 function *t1() {
@@ -104,7 +103,7 @@
     } catch (yield) {
     }
 }
-`, `SyntaxError: Cannot use the keyword 'yield' as a catch variable name.`);
+`, `SyntaxError: Cannot use the keyword 'yield' as a catch parameter name.`);
 
 testSyntax(`
 function *t1() {

Modified: trunk/Source/_javascript_Core/tests/stress/yield-out-of-generator.js (201753 => 201754)


--- trunk/Source/_javascript_Core/tests/stress/yield-out-of-generator.js	2016-06-07 15:47:30 UTC (rev 201753)
+++ trunk/Source/_javascript_Core/tests/stress/yield-out-of-generator.js	2016-06-07 16:19:59 UTC (rev 201754)
@@ -1,4 +1,6 @@
+// <https://webkit.org/b/158460> Clarify SyntaxErrors around yield and unskip tests
 //@ skip
+
 function testSyntax(script) {
     try {
         eval(script);

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to