Title: [201839] trunk/Source/WebInspectorUI
- Revision
- 201839
- Author
- [email protected]
- Date
- 2016-06-08 16:02:39 -0700 (Wed, 08 Jun 2016)
Log Message
Uncaught Exception in TimelineDataGrid._updatePopoverForSelectedNode()
https://bugs.webkit.org/show_bug.cgi?id=158502
<rdar://problem/26687038>
Reviewed by Joseph Pecoraro.
* UserInterface/Views/TimelineDataGrid.js:
(WebInspector.TimelineDataGrid.prototype._updatePopoverForSelectedNode):
It appears that this _expression_ was moved around since it accesses
targetFrame before it's initialized. Check rect.size.height directly.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (201838 => 201839)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-06-08 22:35:09 UTC (rev 201838)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-06-08 23:02:39 UTC (rev 201839)
@@ -1,5 +1,18 @@
2016-06-08 Brian Burg <[email protected]>
+ Uncaught Exception in TimelineDataGrid._updatePopoverForSelectedNode()
+ https://bugs.webkit.org/show_bug.cgi?id=158502
+ <rdar://problem/26687038>
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/TimelineDataGrid.js:
+ (WebInspector.TimelineDataGrid.prototype._updatePopoverForSelectedNode):
+ It appears that this _expression_ was moved around since it accesses
+ targetFrame before it's initialized. Check rect.size.height directly.
+
+2016-06-08 Brian Burg <[email protected]>
+
Web Inspector: reduce redundant attribute modification updates in DOMTreeUpdater and DOMTreeElement
https://bugs.webkit.org/show_bug.cgi?id=158504
<rdar://problem/25561452>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js (201838 => 201839)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js 2016-06-08 22:35:09 UTC (rev 201838)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js 2016-06-08 23:02:39 UTC (rev 201839)
@@ -489,7 +489,7 @@
// The element might be hidden if it does not have a width and height.
let rect = WebInspector.Rect.rectFromClientRect(targetPopoverElement.getBoundingClientRect());
- if (!rect.size.width && !targetFrame.rect.height)
+ if (!rect.size.width && !rect.size.height)
return;
if (this._hidePopoverContentClearTimeout) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
