Title: [201871] trunk/LayoutTests
- Revision
- 201871
- Author
- [email protected]
- Date
- 2016-06-09 10:31:08 -0700 (Thu, 09 Jun 2016)
Log Message
LayoutTest storage/indexeddb/modern/handle-user-delete.html is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=158501
Reviewed by Darin Adler.
The order in which the transaction abort happens doesn't matter; It only matters that it happens.
Update the test to reflect this.
* storage/indexeddb/modern/handle-user-delete-expected.txt:
* storage/indexeddb/modern/resources/handle-user-delete.js:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (201870 => 201871)
--- trunk/LayoutTests/ChangeLog 2016-06-09 17:12:53 UTC (rev 201870)
+++ trunk/LayoutTests/ChangeLog 2016-06-09 17:31:08 UTC (rev 201871)
@@ -1,3 +1,17 @@
+2016-06-09 Brady Eidson <[email protected]>
+
+ LayoutTest storage/indexeddb/modern/handle-user-delete.html is a flaky failure.
+ https://bugs.webkit.org/show_bug.cgi?id=158501
+
+ Reviewed by Darin Adler.
+
+ The order in which the transaction abort happens doesn't matter; It only matters that it happens.
+
+ Update the test to reflect this.
+
+ * storage/indexeddb/modern/handle-user-delete-expected.txt:
+ * storage/indexeddb/modern/resources/handle-user-delete.js:
+
2016-06-09 Simon Fraser <[email protected]>
border-radius with different width and height rendered wrong
Modified: trunk/LayoutTests/storage/indexeddb/modern/handle-user-delete-expected.txt (201870 => 201871)
--- trunk/LayoutTests/storage/indexeddb/modern/handle-user-delete-expected.txt 2016-06-09 17:12:53 UTC (rev 201870)
+++ trunk/LayoutTests/storage/indexeddb/modern/handle-user-delete-expected.txt 2016-06-09 17:31:08 UTC (rev 201871)
@@ -10,9 +10,9 @@
Initial upgrade needed: Old version - 0 New version - 1
Started two spinning requests
Requested clearAllDatabases
-Initial upgrade versionchange transaction aborted: [object DOMError]
[PASS] Both requests hit a failure condition (Received onerror or failed to start a new request because the transaction was aborted)
[PASS] Database received correct error.
+[PASS] Transaction aborted.
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/storage/indexeddb/modern/resources/handle-user-delete.js (201870 => 201871)
--- trunk/LayoutTests/storage/indexeddb/modern/resources/handle-user-delete.js 2016-06-09 17:12:53 UTC (rev 201870)
+++ trunk/LayoutTests/storage/indexeddb/modern/resources/handle-user-delete.js 2016-06-09 17:31:08 UTC (rev 201871)
@@ -4,6 +4,7 @@
var requestErrorCount = 0;
var databaseError = false;
+var transactionAbort = false;
function done()
{
@@ -16,7 +17,12 @@
log("[PASS] Database received correct error.");
else
log("[FAIL] Database did not receive correct error.");
-
+
+ if (transactionAbort)
+ log("[PASS] Transaction aborted.");
+ else
+ log("[FAIL] Transaction did not abort.");
+
finishJSTest();
}
@@ -27,7 +33,7 @@
function maybeFinish()
{
- if (requestErrorCount == 2 && databaseError)
+ if (requestErrorCount == 2 && databaseError && transactionAbort)
done();
}
@@ -77,7 +83,8 @@
log("Started two spinning requests")
versionTransaction._onabort_ = function(event) {
- log("Initial upgrade versionchange transaction aborted: " + versionTransaction.error);
+ transactionAbort = true;
+ maybeFinish();
}
versionTransaction._oncomplete_ = function() {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
