Title: [201879] trunk
Revision
201879
Author
mcatanz...@igalia.com
Date
2016-06-09 13:09:21 -0700 (Thu, 09 Jun 2016)

Log Message

Add comments to clarify feature enablement
https://bugs.webkit.org/show_bug.cgi?id=158567

Reviewed by Alex Christensen.

.:

* Source/cmake/WebKitFeatures.cmake:

Tools:

* Scripts/webkitperl/FeatureList.pm:

Modified Paths

Diff

Modified: trunk/ChangeLog (201878 => 201879)


--- trunk/ChangeLog	2016-06-09 19:24:22 UTC (rev 201878)
+++ trunk/ChangeLog	2016-06-09 20:09:21 UTC (rev 201879)
@@ -1,3 +1,12 @@
+2016-06-09  Michael Catanzaro  <mcatanz...@igalia.com>
+
+        Add comments to clarify feature enablement
+        https://bugs.webkit.org/show_bug.cgi?id=158567
+
+        Reviewed by Alex Christensen.
+
+        * Source/cmake/WebKitFeatures.cmake:
+
 2016-06-08  Per Arne Vollan  <pvol...@apple.com>
 
         [Win] Shadow DOM tests are failing.

Modified: trunk/Source/cmake/WebKitFeatures.cmake (201878 => 201879)


--- trunk/Source/cmake/WebKitFeatures.cmake	2016-06-09 19:24:22 UTC (rev 201878)
+++ trunk/Source/cmake/WebKitFeatures.cmake	2016-06-09 20:09:21 UTC (rev 201879)
@@ -1,3 +1,13 @@
+# The settings in this file are the WebKit project default values, and
+# are recommended for most ports. Ports can override these settings in
+# Options*.cmake, but should do so only if there is strong reason to
+# deviate from the defaults of the WebKit project (e.g. if the feature
+# requires platform-specific implementation that does not exist).
+#
+# Most defaults in this file affect end users but not developers.
+# Defaults for development builds are set in FeatureList.pm. Most all
+# features enabled here should also be enabled in FeatureList.pm.
+
 set(_WEBKIT_AVAILABLE_OPTIONS "")
 
 set(PUBLIC YES)

Modified: trunk/Tools/ChangeLog (201878 => 201879)


--- trunk/Tools/ChangeLog	2016-06-09 19:24:22 UTC (rev 201878)
+++ trunk/Tools/ChangeLog	2016-06-09 20:09:21 UTC (rev 201879)
@@ -1,3 +1,12 @@
+2016-06-09  Michael Catanzaro  <mcatanz...@igalia.com>
+
+        Add comments to clarify feature enablement
+        https://bugs.webkit.org/show_bug.cgi?id=158567
+
+        Reviewed by Alex Christensen.
+
+        * Scripts/webkitperl/FeatureList.pm:
+
 2016-06-09  Filip Pizlo  <fpi...@apple.com>
 
         Unreviewed, skip jsair tests while we figure out the debug timeouts.

Modified: trunk/Tools/Scripts/webkitperl/FeatureList.pm (201878 => 201879)


--- trunk/Tools/Scripts/webkitperl/FeatureList.pm	2016-06-09 19:24:22 UTC (rev 201878)
+++ trunk/Tools/Scripts/webkitperl/FeatureList.pm	2016-06-09 20:09:21 UTC (rev 201879)
@@ -23,6 +23,13 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 # A module to contain all the enable/disable feature option code.
+#
+# For CMake ports, this module only affects development builds. The
+# settings in this file have ZERO EFFECT for end users. Use
+# WebKitFeatures.cmake to change settings for users. Guidelines:
+#
+# * A feature enabled here but not WebKitFeatures.cmake is EXPERIMENTAL.
+# * A feature enabled in WebKitFeatures.cmake but not here is a BUG.
 
 use strict;
 use warnings;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to