Diff
Modified: trunk/Source/WebCore/ChangeLog (201893 => 201894)
--- trunk/Source/WebCore/ChangeLog 2016-06-09 23:48:08 UTC (rev 201893)
+++ trunk/Source/WebCore/ChangeLog 2016-06-09 23:53:36 UTC (rev 201894)
@@ -1,3 +1,50 @@
+2016-06-09 Alex Christensen <[email protected]>
+
+ Clean up EditorClient lifetime
+ https://bugs.webkit.org/show_bug.cgi?id=158588
+
+ Reviewed by Anders Carlsson.
+
+ No new tests. This patch does two things, all of which do not change behavior:
+ 1. Use a std::unique_ptr<EditorClient> owned by the Page instead of allocating
+ with new in WebKit/WebKit2 and deleting in WebEditorClient::pageDestroyed.
+ 2. Give the Page a PageConfiguration&& instead of a PageConfiguration& in its constructor.
+
+ * inspector/InspectorOverlay.cpp:
+ (WebCore::InspectorOverlay::overlayPage):
+ * loader/EmptyClients.cpp:
+ (WebCore::fillWithEmptyClients):
+ * loader/EmptyClients.h:
+ (WebCore::EmptyEditorClient::EmptyEditorClient):
+ (WebCore::EmptyEditorClient::~EmptyEditorClient):
+ * page/EditorClient.h:
+ (WebCore::EditorClient::~EditorClient):
+ * page/Page.cpp:
+ (WebCore::Page::Page):
+ (WebCore::Page::~Page):
+ (WebCore::Page::setViewMode):
+ (WebCore::Page::clearUndoRedoOperations):
+ (WebCore::Page::inLowQualityImageInterpolationMode):
+ (WebCore::Page::invalidateStylesForAllLinks):
+ (WebCore::Page::invalidateStylesForLink):
+ (WebCore::Page::invalidateInjectedStyleSheetCacheInAllFrames):
+ (WebCore::Page::setDebugger):
+ (WebCore::Page::setIsVisibleInternal):
+ (WebCore::Page::setAllowsMediaDocumentInlinePlayback):
+ * page/Page.h:
+ (WebCore::Page::canStartMedia):
+ (WebCore::Page::editorClient):
+ (WebCore::Page::plugInClient):
+ (WebCore::Page::mainFrame):
+ (WebCore::Page::group):
+ * page/PageConfiguration.cpp:
+ * page/PageConfiguration.h:
+ * page/mac/PageMac.mm:
+ (WebCore::Page::addSchedulePair):
+ (WebCore::Page::removeSchedulePair):
+ * svg/graphics/SVGImage.cpp:
+ (WebCore::SVGImage::dataChanged):
+
2016-06-09 Joseph Pecoraro <[email protected]>
REGRESSION: Web Inspector: IndexedDB does not show ObjectStore data
Modified: trunk/Source/WebCore/inspector/InspectorOverlay.cpp (201893 => 201894)
--- trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2016-06-09 23:48:08 UTC (rev 201893)
+++ trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2016-06-09 23:53:36 UTC (rev 201894)
@@ -866,7 +866,7 @@
PageConfiguration pageConfiguration;
fillWithEmptyClients(pageConfiguration);
- m_overlayPage = std::make_unique<Page>(pageConfiguration);
+ m_overlayPage = std::make_unique<Page>(WTFMove(pageConfiguration));
Settings& settings = m_page.settings();
Settings& overlaySettings = m_overlayPage->settings();
Modified: trunk/Source/WebCore/loader/EmptyClients.cpp (201893 => 201894)
--- trunk/Source/WebCore/loader/EmptyClients.cpp 2016-06-09 23:48:08 UTC (rev 201893)
+++ trunk/Source/WebCore/loader/EmptyClients.cpp 2016-06-09 23:53:36 UTC (rev 201894)
@@ -129,9 +129,8 @@
pageConfiguration.dragClient = &dummyDragClient.get();
#endif
- static NeverDestroyed<EmptyEditorClient> dummyEditorClient;
- pageConfiguration.editorClient = &dummyEditorClient.get();
-
+ pageConfiguration.editorClient = std::make_unique<EmptyEditorClient>();
+
static NeverDestroyed<EmptyInspectorClient> dummyInspectorClient;
pageConfiguration.inspectorClient = &dummyInspectorClient.get();
Modified: trunk/Source/WebCore/loader/EmptyClients.h (201893 => 201894)
--- trunk/Source/WebCore/loader/EmptyClients.h 2016-06-09 23:48:08 UTC (rev 201893)
+++ trunk/Source/WebCore/loader/EmptyClients.h 2016-06-09 23:53:36 UTC (rev 201894)
@@ -40,7 +40,6 @@
#include "FocusDirection.h"
#include "FrameLoaderClient.h"
#include "InspectorClient.h"
-#include "Page.h"
#include "ProgressTrackerClient.h"
#include "ResourceError.h"
#include "TextCheckerClient.h"
@@ -71,6 +70,7 @@
namespace WebCore {
class GraphicsContext3D;
+class Page;
class EmptyChromeClient : public ChromeClient {
WTF_MAKE_FAST_ALLOCATED;
@@ -436,7 +436,6 @@
public:
EmptyEditorClient() { }
virtual ~EmptyEditorClient() { }
- void pageDestroyed() override { }
bool shouldDeleteRange(Range*) override { return false; }
bool smartInsertDeleteEnabled() override { return false; }
Modified: trunk/Source/WebCore/page/EditorClient.h (201893 => 201894)
--- trunk/Source/WebCore/page/EditorClient.h 2016-06-09 23:48:08 UTC (rev 201893)
+++ trunk/Source/WebCore/page/EditorClient.h 2016-06-09 23:53:36 UTC (rev 201894)
@@ -70,7 +70,6 @@
class EditorClient {
public:
virtual ~EditorClient() { }
- virtual void pageDestroyed() = 0;
virtual bool shouldDeleteRange(Range*) = 0;
virtual bool smartInsertDeleteEnabled() = 0;
Modified: trunk/Source/WebCore/page/Page.cpp (201893 => 201894)
--- trunk/Source/WebCore/page/Page.cpp 2016-06-09 23:48:08 UTC (rev 201893)
+++ trunk/Source/WebCore/page/Page.cpp 2016-06-09 23:53:36 UTC (rev 201894)
@@ -156,7 +156,7 @@
static const ViewState::Flags PageInitialViewState = ViewState::IsVisible | ViewState::IsInWindow;
-Page::Page(PageConfiguration& pageConfiguration)
+Page::Page(PageConfiguration&& pageConfiguration)
: m_chrome(std::make_unique<Chrome>(*this, *pageConfiguration.chromeClient))
, m_dragCaretController(std::make_unique<DragCaretController>())
#if ENABLE(DRAG_SUPPORT)
@@ -179,7 +179,7 @@
, m_backForwardController(std::make_unique<BackForwardController>(*this, WTFMove(pageConfiguration.backForwardClient)))
, m_mainFrame(MainFrame::create(*this, pageConfiguration))
, m_theme(RenderTheme::themeForPage(this))
- , m_editorClient(*pageConfiguration.editorClient)
+ , m_editorClient(WTFMove(pageConfiguration.editorClient))
, m_plugInClient(pageConfiguration.plugInClient)
, m_validationMessageClient(pageConfiguration.validationMessageClient)
, m_diagnosticLoggingClient(WTFMove(pageConfiguration.diagnosticLoggingClient))
@@ -238,6 +238,7 @@
, m_sessionID(SessionID::defaultSessionID())
, m_isClosing(false)
{
+ ASSERT(m_editorClient);
updateTimerThrottlingState();
m_storageNamespaceProvider->addPage(*this);
@@ -283,7 +284,6 @@
frame->detachFromPage();
}
- m_editorClient.pageDestroyed();
if (m_plugInClient)
m_plugInClient->pageDestroyed();
if (m_alternativeTextClient)
@@ -412,8 +412,6 @@
m_viewMode = viewMode;
- if (!m_mainFrame)
- return;
if (m_mainFrame->view())
m_mainFrame->view()->forceLayout();
@@ -750,7 +748,7 @@
void Page::clearUndoRedoOperations()
{
- m_editorClient.clearUndoRedoOperations();
+ m_editorClient->clearUndoRedoOperations();
}
bool Page::inLowQualityImageInterpolationMode() const
@@ -1122,7 +1120,7 @@
void Page::invalidateStylesForAllLinks()
{
- for (Frame* frame = m_mainFrame.get(); frame; frame = frame->tree().traverseNext()) {
+ for (Frame* frame = &m_mainFrame.get(); frame; frame = frame->tree().traverseNext()) {
if (!frame->document())
continue;
frame->document()->visitedLinkState().invalidateStyleForAllLinks();
@@ -1131,7 +1129,7 @@
void Page::invalidateStylesForLink(LinkHash linkHash)
{
- for (Frame* frame = m_mainFrame.get(); frame; frame = frame->tree().traverseNext()) {
+ for (Frame* frame = &m_mainFrame.get(); frame; frame = frame->tree().traverseNext()) {
if (!frame->document())
continue;
frame->document()->visitedLinkState().invalidateStyleForLink(linkHash);
@@ -1140,7 +1138,7 @@
void Page::invalidateInjectedStyleSheetCacheInAllFrames()
{
- for (Frame* frame = m_mainFrame.get(); frame; frame = frame->tree().traverseNext()) {
+ for (Frame* frame = &m_mainFrame.get(); frame; frame = frame->tree().traverseNext()) {
Document* document = frame->document();
if (!document)
continue;
@@ -1156,7 +1154,7 @@
m_debugger = debugger;
- for (Frame* frame = m_mainFrame.get(); frame; frame = frame->tree().traverseNext())
+ for (Frame* frame = &m_mainFrame.get(); frame; frame = frame->tree().traverseNext())
frame->script().attachDebugger(m_debugger);
}
@@ -1487,7 +1485,7 @@
}
Vector<Ref<Document>> documents;
- for (Frame* frame = m_mainFrame.get(); frame; frame = frame->tree().traverseNext())
+ for (Frame* frame = &m_mainFrame.get(); frame; frame = frame->tree().traverseNext())
documents.append(*frame->document());
for (auto& document : documents)
@@ -1985,7 +1983,7 @@
m_allowsMediaDocumentInlinePlayback = flag;
Vector<Ref<Document>> documents;
- for (Frame* frame = m_mainFrame.get(); frame; frame = frame->tree().traverseNext())
+ for (Frame* frame = &m_mainFrame.get(); frame; frame = frame->tree().traverseNext())
documents.append(*frame->document());
for (auto& document : documents)
Modified: trunk/Source/WebCore/page/Page.h (201893 => 201894)
--- trunk/Source/WebCore/page/Page.h 2016-06-09 23:48:08 UTC (rev 201893)
+++ trunk/Source/WebCore/page/Page.h 2016-06-09 23:53:36 UTC (rev 201894)
@@ -18,8 +18,7 @@
* Boston, MA 02110-1301, USA.
*/
-#ifndef Page_h
-#define Page_h
+#pragma once
#include "FindOptions.h"
#include "FrameLoaderTypes.h"
@@ -141,7 +140,7 @@
WEBCORE_EXPORT static void updateStyleForAllPagesAfterGlobalChangeInEnvironment();
WEBCORE_EXPORT static void clearPreviousItemFromAllPages(HistoryItem*);
- WEBCORE_EXPORT explicit Page(PageConfiguration&);
+ WEBCORE_EXPORT explicit Page(PageConfiguration&&);
WEBCORE_EXPORT ~Page();
WEBCORE_EXPORT uint64_t renderTreeSize() const;
@@ -158,11 +157,11 @@
WEBCORE_EXPORT void setCanStartMedia(bool);
bool canStartMedia() const { return m_canStartMedia; }
- EditorClient& editorClient() { return m_editorClient; }
+ EditorClient& editorClient() const { return *m_editorClient; }
PlugInClient* plugInClient() const { return m_plugInClient; }
- MainFrame& mainFrame() { ASSERT(m_mainFrame); return *m_mainFrame; }
- const MainFrame& mainFrame() const { ASSERT(m_mainFrame); return *m_mainFrame; }
+ MainFrame& mainFrame() { return m_mainFrame.get(); }
+ const MainFrame& mainFrame() const { return m_mainFrame.get(); }
bool inPageCache() const;
@@ -578,13 +577,13 @@
const std::unique_ptr<ProgressTracker> m_progress;
const std::unique_ptr<BackForwardController> m_backForwardController;
- const RefPtr<MainFrame> m_mainFrame;
+ Ref<MainFrame> m_mainFrame;
mutable RefPtr<PluginData> m_pluginData;
RefPtr<RenderTheme> m_theme;
- EditorClient& m_editorClient;
+ std::unique_ptr<EditorClient> m_editorClient;
PlugInClient* m_plugInClient;
ValidationMessageClient* m_validationMessageClient;
std::unique_ptr<DiagnosticLoggingClient> m_diagnosticLoggingClient;
@@ -724,5 +723,3 @@
}
} // namespace WebCore
-
-#endif // Page_h
Modified: trunk/Source/WebCore/page/PageConfiguration.cpp (201893 => 201894)
--- trunk/Source/WebCore/page/PageConfiguration.cpp 2016-06-09 23:48:08 UTC (rev 201893)
+++ trunk/Source/WebCore/page/PageConfiguration.cpp 2016-06-09 23:53:36 UTC (rev 201894)
@@ -30,6 +30,7 @@
#include "BackForwardClient.h"
#include "DatabaseProvider.h"
#include "DiagnosticLoggingClient.h"
+#include "EditorClient.h"
#include "StorageNamespaceProvider.h"
#include "UserContentController.h"
#include "VisitedLinkStore.h"
Modified: trunk/Source/WebCore/page/PageConfiguration.h (201893 => 201894)
--- trunk/Source/WebCore/page/PageConfiguration.h 2016-06-09 23:48:08 UTC (rev 201893)
+++ trunk/Source/WebCore/page/PageConfiguration.h 2016-06-09 23:53:36 UTC (rev 201894)
@@ -67,7 +67,7 @@
#if ENABLE(CONTEXT_MENUS)
ContextMenuClient* contextMenuClient { nullptr };
#endif
- EditorClient* editorClient { nullptr };
+ std::unique_ptr<EditorClient> editorClient;
DragClient* dragClient { nullptr };
InspectorClient* inspectorClient { nullptr };
PlugInClient* plugInClient { nullptr };
Modified: trunk/Source/WebCore/page/mac/PageMac.mm (201893 => 201894)
--- trunk/Source/WebCore/page/mac/PageMac.mm 2016-06-09 23:48:08 UTC (rev 201893)
+++ trunk/Source/WebCore/page/mac/PageMac.mm 2016-06-09 23:53:36 UTC (rev 201894)
@@ -70,7 +70,7 @@
m_scheduledRunLoopPairs->add(pair.ptr());
#if !USE(CFNETWORK)
- for (Frame* frame = m_mainFrame.get(); frame; frame = frame->tree().traverseNext()) {
+ for (Frame* frame = &m_mainFrame.get(); frame; frame = frame->tree().traverseNext()) {
if (DocumentLoader* documentLoader = frame->loader().documentLoader())
documentLoader->schedule(pair);
if (DocumentLoader* documentLoader = frame->loader().provisionalDocumentLoader())
@@ -90,7 +90,7 @@
m_scheduledRunLoopPairs->remove(pair.ptr());
#if !USE(CFNETWORK)
- for (Frame* frame = m_mainFrame.get(); frame; frame = frame->tree().traverseNext()) {
+ for (Frame* frame = &m_mainFrame.get(); frame; frame = frame->tree().traverseNext()) {
if (DocumentLoader* documentLoader = frame->loader().documentLoader())
documentLoader->unschedule(pair);
if (DocumentLoader* documentLoader = frame->loader().provisionalDocumentLoader())
Modified: trunk/Source/WebCore/svg/graphics/SVGImage.cpp (201893 => 201894)
--- trunk/Source/WebCore/svg/graphics/SVGImage.cpp 2016-06-09 23:48:08 UTC (rev 201893)
+++ trunk/Source/WebCore/svg/graphics/SVGImage.cpp 2016-06-09 23:53:36 UTC (rev 201894)
@@ -390,7 +390,7 @@
// This will become an issue when SVGImage will be able to load other
// SVGImage objects, but we're safe now, because SVGImage can only be
// loaded by a top-level document.
- m_page = std::make_unique<Page>(pageConfiguration);
+ m_page = std::make_unique<Page>(WTFMove(pageConfiguration));
m_page->settings().setMediaEnabled(false);
m_page->settings().setScriptEnabled(false);
m_page->settings().setPluginsEnabled(false);
Modified: trunk/Source/WebKit/mac/ChangeLog (201893 => 201894)
--- trunk/Source/WebKit/mac/ChangeLog 2016-06-09 23:48:08 UTC (rev 201893)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-06-09 23:53:36 UTC (rev 201894)
@@ -1,3 +1,18 @@
+2016-06-09 Alex Christensen <[email protected]>
+
+ Clean up EditorClient lifetime
+ https://bugs.webkit.org/show_bug.cgi?id=158588
+
+ Reviewed by Anders Carlsson.
+
+ * WebCoreSupport/WebEditorClient.h:
+ * WebCoreSupport/WebEditorClient.mm:
+ (WebEditorClient::WebEditorClient):
+ (WebEditorClient::pageDestroyed): Deleted.
+ * WebView/WebView.mm:
+ (-[WebView _commonInitializationWithFrameName:groupName:]):
+ (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
+
2016-06-09 Andy Estes <[email protected]>
Define printing{Minimum,Maximum}ShrinkFactor in only one place
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.h (201893 => 201894)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.h 2016-06-09 23:48:08 UTC (rev 201893)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.h 2016-06-09 23:53:36 UTC (rev 201894)
@@ -51,8 +51,6 @@
void didCheckSucceed(int sequence, NSArray *results);
private:
- void pageDestroyed() override;
-
bool isGrammarCheckingEnabled() override;
void toggleGrammarChecking() override;
bool isContinuousSpellCheckingEnabled() override;
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm (201893 => 201894)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm 2016-06-09 23:48:08 UTC (rev 201893)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm 2016-06-09 23:53:36 UTC (rev 201894)
@@ -183,11 +183,6 @@
@end
-void WebEditorClient::pageDestroyed()
-{
- delete this;
-}
-
WebEditorClient::WebEditorClient(WebView *webView)
: m_webView(webView)
, m_undoTarget(adoptNS([[WebEditorUndoTarget alloc] init]))
Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (201893 => 201894)
--- trunk/Source/WebKit/mac/WebView/WebView.mm 2016-06-09 23:48:08 UTC (rev 201893)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2016-06-09 23:53:36 UTC (rev 201894)
@@ -1004,7 +1004,7 @@
#import <WebKitAdditions/WebViewInitialization.mm>
#endif
- pageConfiguration.editorClient = new WebEditorClient(self);
+ pageConfiguration.editorClient = std::make_unique<WebEditorClient>(self);
pageConfiguration.alternativeTextClient = new WebAlternativeTextClient(self);
pageConfiguration.loaderClientForMainFrame = new WebFrameLoaderClient;
pageConfiguration.progressTrackerClient = new WebProgressTrackerClient(self);
@@ -1013,7 +1013,7 @@
pageConfiguration.storageNamespaceProvider = &_private->group->storageNamespaceProvider();
pageConfiguration.userContentProvider = &_private->group->userContentController();
pageConfiguration.visitedLinkStore = &_private->group->visitedLinkStore();
- _private->page = new Page(pageConfiguration);
+ _private->page = new Page(WTFMove(pageConfiguration));
_private->page->setGroupName(groupName);
@@ -1248,7 +1248,7 @@
#import <WebKitAdditions/WebViewInitialization.mm>
#endif
- pageConfiguration.editorClient = new WebEditorClient(self);
+ pageConfiguration.editorClient = std::make_unique<WebEditorClient>(self);
pageConfiguration.inspectorClient = new WebInspectorClient(self);
pageConfiguration.loaderClientForMainFrame = new WebFrameLoaderClient;
pageConfiguration.progressTrackerClient = new WebProgressTrackerClient(self);
@@ -1258,7 +1258,7 @@
pageConfiguration.userContentProvider = &_private->group->userContentController();
pageConfiguration.visitedLinkStore = &_private->group->visitedLinkStore();
- _private->page = new Page(pageConfiguration);
+ _private->page = new Page(WTFMove(pageConfiguration));
[self setSmartInsertDeleteEnabled:YES];
Modified: trunk/Source/WebKit2/ChangeLog (201893 => 201894)
--- trunk/Source/WebKit2/ChangeLog 2016-06-09 23:48:08 UTC (rev 201893)
+++ trunk/Source/WebKit2/ChangeLog 2016-06-09 23:53:36 UTC (rev 201894)
@@ -1,3 +1,19 @@
+2016-06-09 Alex Christensen <[email protected]>
+
+ Clean up EditorClient lifetime
+ https://bugs.webkit.org/show_bug.cgi?id=158588
+
+ Reviewed by Anders Carlsson.
+
+ * WebProcess/WebCoreSupport/WebEditorClient.cpp:
+ (WebKit::generateTextCheckingRequestID):
+ (WebKit::WebEditorClient::shouldDeleteRange):
+ (WebKit::WebEditorClient::pageDestroyed): Deleted.
+ * WebProcess/WebCoreSupport/WebEditorClient.h:
+ (WebKit::WebEditorClient::WebEditorClient):
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::m_shouldDispatchFakeMouseMoveEvents):
+
2016-06-09 Andy Estes <[email protected]>
WKWebView does not render PDF pages in AirPrint
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp (201893 => 201894)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp 2016-06-09 23:48:08 UTC (rev 201893)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp 2016-06-09 23:53:36 UTC (rev 201894)
@@ -70,11 +70,6 @@
return uniqueTextCheckingRequestID++;
}
-void WebEditorClient::pageDestroyed()
-{
- delete this;
-}
-
bool WebEditorClient::shouldDeleteRange(Range* range)
{
bool result = m_page->injectedBundleEditorClient().shouldDeleteRange(m_page, range);
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h (201893 => 201894)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h 2016-06-09 23:48:08 UTC (rev 201893)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h 2016-06-09 23:53:36 UTC (rev 201894)
@@ -41,8 +41,6 @@
}
private:
- void pageDestroyed() override;
-
bool shouldDeleteRange(WebCore::Range*) override;
bool smartInsertDeleteEnabled() override;
bool isSelectTrailingWhitespaceEnabled() override;
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (201893 => 201894)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-06-09 23:48:08 UTC (rev 201893)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2016-06-09 23:53:36 UTC (rev 201894)
@@ -389,7 +389,7 @@
#if ENABLE(CONTEXT_MENUS)
pageConfiguration.contextMenuClient = new WebContextMenuClient(this);
#endif
- pageConfiguration.editorClient = new WebEditorClient(this);
+ pageConfiguration.editorClient = std::make_unique<WebEditorClient>(this);
#if ENABLE(DRAG_SUPPORT)
pageConfiguration.dragClient = new WebDragClient(this);
#endif
@@ -414,7 +414,7 @@
#include <WebKitAdditions/WebPageInitialization.h>
#endif
- m_page = std::make_unique<Page>(pageConfiguration);
+ m_page = std::make_unique<Page>(WTFMove(pageConfiguration));
updatePreferences(parameters.store);
m_drawingArea = DrawingArea::create(*this, parameters);
