Title: [201905] trunk/Source/WebKit/win
- Revision
- 201905
- Author
- [email protected]
- Date
- 2016-06-09 22:17:48 -0700 (Thu, 09 Jun 2016)
Log Message
Unreviewed build fix after r201894
https://bugs.webkit.org/show_bug.cgi?id=158588
* WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::~WebEditorClient):
(WebEditorClient::isContinuousSpellCheckingEnabled):
(WebEditorClient::pageDestroyed): Deleted.
* WebCoreSupport/WebEditorClient.h:
* WebView.cpp:
(WebView::initWithFrame):
Modified Paths
Diff
Modified: trunk/Source/WebKit/win/ChangeLog (201904 => 201905)
--- trunk/Source/WebKit/win/ChangeLog 2016-06-10 03:31:00 UTC (rev 201904)
+++ trunk/Source/WebKit/win/ChangeLog 2016-06-10 05:17:48 UTC (rev 201905)
@@ -1,3 +1,16 @@
+2016-06-09 Alex Christensen <[email protected]>
+
+ Unreviewed build fix after r201894
+ https://bugs.webkit.org/show_bug.cgi?id=158588
+
+ * WebCoreSupport/WebEditorClient.cpp:
+ (WebEditorClient::~WebEditorClient):
+ (WebEditorClient::isContinuousSpellCheckingEnabled):
+ (WebEditorClient::pageDestroyed): Deleted.
+ * WebCoreSupport/WebEditorClient.h:
+ * WebView.cpp:
+ (WebView::initWithFrame):
+
2016-06-08 Per Arne Vollan <[email protected]>
[Win] Shadow DOM tests are failing.
Modified: trunk/Source/WebKit/win/WebCoreSupport/WebEditorClient.cpp (201904 => 201905)
--- trunk/Source/WebKit/win/WebCoreSupport/WebEditorClient.cpp 2016-06-10 03:31:00 UTC (rev 201904)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebEditorClient.cpp 2016-06-10 05:17:48 UTC (rev 201905)
@@ -142,11 +142,6 @@
m_undoTarget->Release();
}
-void WebEditorClient::pageDestroyed()
-{
- delete this;
-}
-
bool WebEditorClient::isContinuousSpellCheckingEnabled()
{
BOOL enabled;
Modified: trunk/Source/WebKit/win/WebCoreSupport/WebEditorClient.h (201904 => 201905)
--- trunk/Source/WebKit/win/WebCoreSupport/WebEditorClient.h 2016-06-10 03:31:00 UTC (rev 201904)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebEditorClient.h 2016-06-10 05:17:48 UTC (rev 201905)
@@ -23,8 +23,7 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef WebEditorClient_H
-#define WebEditorClient_H
+#pragma once
#include "WebKit.h"
#include <WebCore/EditorClient.h>
@@ -39,8 +38,6 @@
WebEditorClient(WebView*);
~WebEditorClient();
- virtual void pageDestroyed();
-
virtual bool isContinuousSpellCheckingEnabled();
virtual void toggleGrammarChecking();
virtual bool isGrammarCheckingEnabled();
@@ -122,5 +119,3 @@
WebView* m_webView;
WebEditorUndoTarget* m_undoTarget;
};
-
-#endif // WebEditorClient_H
Modified: trunk/Source/WebKit/win/WebView.cpp (201904 => 201905)
--- trunk/Source/WebKit/win/WebView.cpp 2016-06-10 03:31:00 UTC (rev 201904)
+++ trunk/Source/WebKit/win/WebView.cpp 2016-06-10 05:17:48 UTC (rev 201905)
@@ -2911,7 +2911,7 @@
PageConfiguration configuration;
configuration.chromeClient = new WebChromeClient(this);
configuration.contextMenuClient = new WebContextMenuClient(this);
- configuration.editorClient = new WebEditorClient(this);
+ configuration.editorClient = std::make_unique<WebEditorClient>(this);
configuration.dragClient = new WebDragClient(this);
configuration.inspectorClient = m_inspectorClient;
configuration.loaderClientForMainFrame = new WebFrameLoaderClient;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
