Title: [201921] trunk/Source/WebKit2
Revision
201921
Author
[email protected]
Date
2016-06-10 05:50:14 -0700 (Fri, 10 Jun 2016)

Log Message

[GTK] Browser plugins crash under Wayland
https://bugs.webkit.org/show_bug.cgi?id=157605

Reviewed by Michael Catanzaro.

Fail the initialization of windowed plugins if we don't have a platform implementation.

* WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.cpp:
(WebKit::NetscapePlugin::platformPostInitialize):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (201920 => 201921)


--- trunk/Source/WebKit2/ChangeLog	2016-06-10 09:15:07 UTC (rev 201920)
+++ trunk/Source/WebKit2/ChangeLog	2016-06-10 12:50:14 UTC (rev 201921)
@@ -1,3 +1,15 @@
+2016-06-10  Carlos Garcia Campos  <[email protected]>
+
+        [GTK] Browser plugins crash under Wayland
+        https://bugs.webkit.org/show_bug.cgi?id=157605
+
+        Reviewed by Michael Catanzaro.
+
+        Fail the initialization of windowed plugins if we don't have a platform implementation.
+
+        * WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.cpp:
+        (WebKit::NetscapePlugin::platformPostInitialize):
+
 2016-06-09  Antoine Quint  <[email protected]>
 
         [iOS] -webkit-overflow-scrolling: touch; ignores pointer-events: none;

Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.cpp (201920 => 201921)


--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.cpp	2016-06-10 09:15:07 UTC (rev 201920)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.cpp	2016-06-10 12:50:14 UTC (rev 201921)
@@ -51,13 +51,14 @@
     }
 #endif
 
-    if (m_impl) {
-        m_npWindow.type = m_impl->windowType();
-        m_npWindow.window = m_impl->window();
-        m_npWindow.ws_info = m_impl->windowSystemInfo();
-        callSetWindow();
-    }
+    // Windowed plugins need a platform implementation.
+    if (!m_impl)
+        return !m_isWindowed;
 
+    m_npWindow.type = m_impl->windowType();
+    m_npWindow.window = m_impl->window();
+    m_npWindow.ws_info = m_impl->windowSystemInfo();
+    callSetWindow();
     return true;
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to