- Revision
- 201926
- Author
- [email protected]
- Date
- 2016-06-10 09:19:44 -0700 (Fri, 10 Jun 2016)
Log Message
ErrorEvent / ProgressEvent should be exposed to workers
https://bugs.webkit.org/show_bug.cgi?id=158606
Reviewed by Brady Eidson.
Source/WebCore:
ErrorEvent / ProgressEvent should be exposed to workers:
- https://html.spec.whatwg.org/multipage/webappapis.html#errorevent
- https://xhr.spec.whatwg.org/#interface-progressevent
Firefox and Chrome both already expose those.
No new tests, rebaselined existing test.
* dom/ErrorEvent.idl:
* dom/ProgressEvent.idl:
LayoutTests:
Rebaseline test.
* js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (201925 => 201926)
--- trunk/LayoutTests/ChangeLog 2016-06-10 14:47:37 UTC (rev 201925)
+++ trunk/LayoutTests/ChangeLog 2016-06-10 16:19:44 UTC (rev 201926)
@@ -1,5 +1,16 @@
2016-06-10 Chris Dumez <[email protected]>
+ ErrorEvent / ProgressEvent should be exposed to workers
+ https://bugs.webkit.org/show_bug.cgi?id=158606
+
+ Reviewed by Brady Eidson.
+
+ Rebaseline test.
+
+ * js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
+
+2016-06-10 Chris Dumez <[email protected]>
+
MessagePort should be exposed to workers
https://bugs.webkit.org/show_bug.cgi?id=158607
Modified: trunk/LayoutTests/js/dom/global-constructors-attributes-dedicated-worker-expected.txt (201925 => 201926)
--- trunk/LayoutTests/js/dom/global-constructors-attributes-dedicated-worker-expected.txt 2016-06-10 14:47:37 UTC (rev 201925)
+++ trunk/LayoutTests/js/dom/global-constructors-attributes-dedicated-worker-expected.txt 2016-06-10 16:19:44 UTC (rev 201926)
@@ -59,6 +59,11 @@
PASS [Worker] Object.getOwnPropertyDescriptor(global, 'Error').hasOwnProperty('set') is false
PASS [Worker] Object.getOwnPropertyDescriptor(global, 'Error').enumerable is false
PASS [Worker] Object.getOwnPropertyDescriptor(global, 'Error').configurable is true
+PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ErrorEvent').value is ErrorEvent
+PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ErrorEvent').hasOwnProperty('get') is false
+PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ErrorEvent').hasOwnProperty('set') is false
+PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ErrorEvent').enumerable is false
+PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ErrorEvent').configurable is true
PASS [Worker] Object.getOwnPropertyDescriptor(global, 'EvalError').value is EvalError
PASS [Worker] Object.getOwnPropertyDescriptor(global, 'EvalError').hasOwnProperty('get') is false
PASS [Worker] Object.getOwnPropertyDescriptor(global, 'EvalError').hasOwnProperty('set') is false
@@ -159,6 +164,11 @@
PASS [Worker] Object.getOwnPropertyDescriptor(global, 'Object').hasOwnProperty('set') is false
PASS [Worker] Object.getOwnPropertyDescriptor(global, 'Object').enumerable is false
PASS [Worker] Object.getOwnPropertyDescriptor(global, 'Object').configurable is true
+PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ProgressEvent').value is ProgressEvent
+PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ProgressEvent').hasOwnProperty('get') is false
+PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ProgressEvent').hasOwnProperty('set') is false
+PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ProgressEvent').enumerable is false
+PASS [Worker] Object.getOwnPropertyDescriptor(global, 'ProgressEvent').configurable is true
PASS [Worker] Object.getOwnPropertyDescriptor(global, 'Promise').value is Promise
PASS [Worker] Object.getOwnPropertyDescriptor(global, 'Promise').hasOwnProperty('get') is false
PASS [Worker] Object.getOwnPropertyDescriptor(global, 'Promise').hasOwnProperty('set') is false
Modified: trunk/Source/WebCore/ChangeLog (201925 => 201926)
--- trunk/Source/WebCore/ChangeLog 2016-06-10 14:47:37 UTC (rev 201925)
+++ trunk/Source/WebCore/ChangeLog 2016-06-10 16:19:44 UTC (rev 201926)
@@ -1,5 +1,23 @@
2016-06-10 Chris Dumez <[email protected]>
+ ErrorEvent / ProgressEvent should be exposed to workers
+ https://bugs.webkit.org/show_bug.cgi?id=158606
+
+ Reviewed by Brady Eidson.
+
+ ErrorEvent / ProgressEvent should be exposed to workers:
+ - https://html.spec.whatwg.org/multipage/webappapis.html#errorevent
+ - https://xhr.spec.whatwg.org/#interface-progressevent
+
+ Firefox and Chrome both already expose those.
+
+ No new tests, rebaselined existing test.
+
+ * dom/ErrorEvent.idl:
+ * dom/ProgressEvent.idl:
+
+2016-06-10 Chris Dumez <[email protected]>
+
MessagePort should be exposed to workers
https://bugs.webkit.org/show_bug.cgi?id=158607
Modified: trunk/Source/WebCore/dom/ErrorEvent.idl (201925 => 201926)
--- trunk/Source/WebCore/dom/ErrorEvent.idl 2016-06-10 14:47:37 UTC (rev 201925)
+++ trunk/Source/WebCore/dom/ErrorEvent.idl 2016-06-10 16:19:44 UTC (rev 201926)
@@ -29,7 +29,8 @@
*/
[
- ConstructorTemplate=Event
+ ConstructorTemplate=Event,
+ Exposed=(Window,Worker),
] interface ErrorEvent : Event {
[InitializedByEventConstructor] readonly attribute DOMString message;
[InitializedByEventConstructor] readonly attribute DOMString filename;
Modified: trunk/Source/WebCore/dom/ProgressEvent.idl (201925 => 201926)
--- trunk/Source/WebCore/dom/ProgressEvent.idl 2016-06-10 14:47:37 UTC (rev 201925)
+++ trunk/Source/WebCore/dom/ProgressEvent.idl 2016-06-10 16:19:44 UTC (rev 201926)
@@ -25,6 +25,7 @@
[
ConstructorTemplate=Event,
+ Exposed=(Window,Worker),
] interface ProgressEvent : Event {
[InitializedByEventConstructor] readonly attribute boolean lengthComputable;
[InitializedByEventConstructor] readonly attribute unsigned long long loaded;
