Title: [201932] trunk/Tools
- Revision
- 201932
- Author
- [email protected]
- Date
- 2016-06-10 11:43:11 -0700 (Fri, 10 Jun 2016)
Log Message
REGRESSION(r201928?) API test WTF.StringOperators failing
https://bugs.webkit.org/show_bug.cgi?id=158623
Unreviewed, but buddy coded with Alex Christensen.
* TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
(TestWebKitAPI::LifetimeLogger::fullName): Only one file in all of TestWebKitAPI is allowed
to use string concatenation, otherwise the linker will mess up on the symbol related to
this bizarre WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING macro expansion.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (201931 => 201932)
--- trunk/Tools/ChangeLog 2016-06-10 18:41:11 UTC (rev 201931)
+++ trunk/Tools/ChangeLog 2016-06-10 18:43:11 UTC (rev 201932)
@@ -1,5 +1,17 @@
2016-06-10 Brady Eidson <[email protected]>
+ REGRESSION(r201928?) API test WTF.StringOperators failing
+ https://bugs.webkit.org/show_bug.cgi?id=158623
+
+ Unreviewed, but buddy coded with Alex Christensen.
+
+ * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
+ (TestWebKitAPI::LifetimeLogger::fullName): Only one file in all of TestWebKitAPI is allowed
+ to use string concatenation, otherwise the linker will mess up on the symbol related to
+ this bizarre WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING macro expansion.
+
+2016-06-10 Brady Eidson <[email protected]>
+
WTF_CrossThreadTask.Basic fails in all non mac ports.
https://bugs.webkit.org/show_bug.cgi?id=158612
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp (201931 => 201932)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp 2016-06-10 18:41:11 UTC (rev 201931)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp 2016-06-10 18:43:11 UTC (rev 201932)
@@ -25,9 +25,9 @@
#include "config.h"
-#include <string>
#include <wtf/CrossThreadTask.h>
#include <wtf/HashCountedSet.h>
+#include <wtf/text/StringBuilder.h>
#include <wtf/text/StringHash.h>
namespace TestWebKitAPI {
@@ -81,7 +81,14 @@
String fullName()
{
- return makeString(&name, "-", String::number(copyGeneration), "-", String::number(moveGeneration));
+ StringBuilder builder;
+ builder.append(&name);
+ builder.append("-");
+ builder.append(String::number(copyGeneration));
+ builder.append("-");
+ builder.append(String::number(moveGeneration));
+
+ return builder.toString();
}
const char& name { *"<default>" };
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
