Title: [201937] trunk/Source/WebInspectorUI
- Revision
- 201937
- Author
- [email protected]
- Date
- 2016-06-10 12:59:20 -0700 (Fri, 10 Jun 2016)
Log Message
Web Inspector: rendering frames timeline "60fps" horizontal guide is mispositioned after switching timeline modes
https://bugs.webkit.org/show_bug.cgi?id=158587
<rdar://problem/26728174>
Reviewed by Timothy Hatcher.
When the view mode changes we iterate over all overview graphs, updating
their visibility as needed. Graphs being shown perform layout, even though
the overview's state is in transition: its offset height may still change.
A simple fix is to use TimelineOverviewGraph.height instead of the graph
element's offset height when performing layout.
* UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
(WebInspector.RenderingFrameTimelineOverviewGraph.prototype.layout):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (201936 => 201937)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-06-10 19:56:18 UTC (rev 201936)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-06-10 19:59:20 UTC (rev 201937)
@@ -1,5 +1,23 @@
2016-06-10 Matt Baker <[email protected]>
+ Web Inspector: rendering frames timeline "60fps" horizontal guide is mispositioned after switching timeline modes
+ https://bugs.webkit.org/show_bug.cgi?id=158587
+ <rdar://problem/26728174>
+
+ Reviewed by Timothy Hatcher.
+
+ When the view mode changes we iterate over all overview graphs, updating
+ their visibility as needed. Graphs being shown perform layout, even though
+ the overview's state is in transition: its offset height may still change.
+
+ A simple fix is to use TimelineOverviewGraph.height instead of the graph
+ element's offset height when performing layout.
+
+ * UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
+ (WebInspector.RenderingFrameTimelineOverviewGraph.prototype.layout):
+
+2016-06-10 Matt Baker <[email protected]>
+
REGRESSION (r201538): Web Inspector: 1px gap above timeline progress view
https://bugs.webkit.org/show_bug.cgi?id=158626
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineOverviewGraph.js (201936 => 201937)
--- trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineOverviewGraph.js 2016-06-10 19:56:18 UTC (rev 201936)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineOverviewGraph.js 2016-06-10 19:59:20 UTC (rev 201937)
@@ -178,7 +178,7 @@
if (this.graphHeightSeconds === 0)
return;
- var overviewGraphHeight = this.element.offsetHeight;
+ let overviewGraphHeight = this.height;
function createDividerAtPosition(framesPerSecond)
{
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
