Title: [201949] trunk/Source/WebInspectorUI
- Revision
- 201949
- Author
- [email protected]
- Date
- 2016-06-10 16:05:52 -0700 (Fri, 10 Jun 2016)
Log Message
Web Inspector: heap snapshot comparison view shows nothing if later snapshot is chosen first
https://bugs.webkit.org/show_bug.cgi?id=158584
<rdar://problem/26727849>
Reviewed by Timothy Hatcher.
ALways compare the the later snapshot to the earlier snapshot,
regardless of selection order.
* UserInterface/Views/HeapAllocationsTimelineView.js:
(WebInspector.HeapAllocationsTimelineView):
(WebInspector.HeapAllocationsTimelineView.prototype._dataGridNodeSelected):
Swap shapshots if the first has a greater identifier than the second.
Drive-by cleanup: null out `_baselineDataGridNode` since it isn't used
after the comparison completes.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (201948 => 201949)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-06-10 23:00:09 UTC (rev 201948)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-06-10 23:05:52 UTC (rev 201949)
@@ -1,5 +1,23 @@
2016-06-10 Matt Baker <[email protected]>
+ Web Inspector: heap snapshot comparison view shows nothing if later snapshot is chosen first
+ https://bugs.webkit.org/show_bug.cgi?id=158584
+ <rdar://problem/26727849>
+
+ Reviewed by Timothy Hatcher.
+
+ ALways compare the the later snapshot to the earlier snapshot,
+ regardless of selection order.
+
+ * UserInterface/Views/HeapAllocationsTimelineView.js:
+ (WebInspector.HeapAllocationsTimelineView):
+ (WebInspector.HeapAllocationsTimelineView.prototype._dataGridNodeSelected):
+ Swap shapshots if the first has a greater identifier than the second.
+ Drive-by cleanup: null out `_baselineDataGridNode` since it isn't used
+ after the comparison completes.
+
+2016-06-10 Matt Baker <[email protected]>
+
Web Inspector: rendering frames timeline "60fps" horizontal guide is mispositioned after switching timeline modes
https://bugs.webkit.org/show_bug.cgi?id=158587
<rdar://problem/26728174>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js (201948 => 201949)
--- trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js 2016-06-10 23:00:09 UTC (rev 201948)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineView.js 2016-06-10 23:05:52 UTC (rev 201949)
@@ -417,6 +417,9 @@
// Selected Comparison.
let snapshot1 = this._baselineHeapSnapshotTimelineRecord.heapSnapshot;
let snapshot2 = heapAllocationsTimelineRecord.heapSnapshot;
+ if (snapshot1.identifier > snapshot2.identifier)
+ [snapshot1, snapshot2] = [snapshot2, snapshot1];
+
let workerProxy = WebInspector.HeapSnapshotWorkerProxy.singleton();
workerProxy.createSnapshotDiff(snapshot1.proxyObjectId, snapshot2.proxyObjectId, ({objectId, snapshotDiff: serializedSnapshotDiff}) => {
let diff = WebInspector.HeapSnapshotDiffProxy.deserialize(objectId, serializedSnapshotDiff);
@@ -424,6 +427,7 @@
});
this._baselineDataGridNode.clearBaseline();
+ this._baselineDataGridNode = null;
this._selectingComparisonHeapSnapshots = false;
this._compareHeapSnapshotsButtonItem.activated = false;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
