Title: [201974] trunk/Source/_javascript_Core
Revision
201974
Author
[email protected]
Date
2016-06-11 11:53:58 -0700 (Sat, 11 Jun 2016)

Log Message

Tests that overflows the stack should not be run with the sampling profiler.
https://bugs.webkit.org/show_bug.cgi?id=158663

Reviewed by Saam Barati.

The sampling profiler will be sampling the whole stack, and the amount of memory
churn will make this tests time out, especially with debug builds.  Hence,
let's not run the test with the sampling profiler configuration.

* tests/stress/mutual-tail-call-no-stack-overflow.js:
(shouldThrow):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (201973 => 201974)


--- trunk/Source/_javascript_Core/ChangeLog	2016-06-11 18:07:05 UTC (rev 201973)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-06-11 18:53:58 UTC (rev 201974)
@@ -1,3 +1,17 @@
+2016-06-11  Mark Lam  <[email protected]>
+
+        Tests that overflows the stack should not be run with the sampling profiler.
+        https://bugs.webkit.org/show_bug.cgi?id=158663
+
+        Reviewed by Saam Barati.
+
+        The sampling profiler will be sampling the whole stack, and the amount of memory
+        churn will make this tests time out, especially with debug builds.  Hence,
+        let's not run the test with the sampling profiler configuration.
+
+        * tests/stress/mutual-tail-call-no-stack-overflow.js:
+        (shouldThrow):
+
 2016-06-10  Yusuke Suzuki  <[email protected]>
 
         Unreviewed, attempt to fix r201964 failure on Apple ports

Modified: trunk/Source/_javascript_Core/tests/stress/mutual-tail-call-no-stack-overflow.js (201973 => 201974)


--- trunk/Source/_javascript_Core/tests/stress/mutual-tail-call-no-stack-overflow.js	2016-06-11 18:07:05 UTC (rev 201973)
+++ trunk/Source/_javascript_Core/tests/stress/mutual-tail-call-no-stack-overflow.js	2016-06-11 18:53:58 UTC (rev 201974)
@@ -1,3 +1,5 @@
+//@ defaultNoSamplingProfilerRun
+
 function shouldThrow(func, errorMessage) {
     var errorThrown = false;
     var error = null;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to