Title: [202006] trunk/Source/WebCore
Revision
202006
Author
[email protected]
Date
2016-06-13 15:00:49 -0700 (Mon, 13 Jun 2016)

Log Message

Decrease PiP flicker by not removing window prematurely.
https://bugs.webkit.org/show_bug.cgi?id=158436
<rdar://problem/19052639>

Patch by Jeremy Jones <[email protected]> on 2016-06-13
Reviewed by Darin Adler.

UIWindow shouldn't be removed until cleanupFullscreen, so the video layer has a chance
to be reparented in the DOM first.

* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::didStopPictureInPicture):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (202005 => 202006)


--- trunk/Source/WebCore/ChangeLog	2016-06-13 21:58:53 UTC (rev 202005)
+++ trunk/Source/WebCore/ChangeLog	2016-06-13 22:00:49 UTC (rev 202006)
@@ -1,3 +1,17 @@
+2016-06-13  Jeremy Jones  <[email protected]>
+
+        Decrease PiP flicker by not removing window prematurely.
+        https://bugs.webkit.org/show_bug.cgi?id=158436
+        <rdar://problem/19052639>
+
+        Reviewed by Darin Adler.
+
+        UIWindow shouldn't be removed until cleanupFullscreen, so the video layer has a chance
+        to be reparented in the DOM first.
+
+        * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+        (WebVideoFullscreenInterfaceAVKit::didStopPictureInPicture):
+
 2016-06-13  Alex Christensen  <[email protected]>
 
         Add WebSocketProvider stub

Modified: trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm (202005 => 202006)


--- trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm	2016-06-13 21:58:53 UTC (rev 202005)
+++ trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm	2016-06-13 22:00:49 UTC (rev 202006)
@@ -971,8 +971,6 @@
     [[m_playerViewController view] setBackgroundColor:[getUIColorClass() clearColor]];
 
     clearMode(HTMLMediaElementEnums::VideoFullscreenModePictureInPicture);
-    [m_window setHidden:YES];
-    [[m_playerViewController view] setHidden:YES];
     
     if (m_fullscreenChangeObserver)
         m_fullscreenChangeObserver->didExitFullscreen();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to