Title: [202014] trunk/Source/WebCore
Revision
202014
Author
[email protected]
Date
2016-06-13 16:05:20 -0700 (Mon, 13 Jun 2016)

Log Message

AX: CrashTracer: com.apple.WebKit.WebContent at WebCore::AccessibilityRenderObject::remoteSVGRootElement const + 227
https://bugs.webkit.org/show_bug.cgi?id=158685

Reviewed by David Kilzer.

Crash reports show a null access at a line that tries to dereference a pointer.
I still don't have a way to layout test this, as it seems tied to tear down of the main document.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::remoteSVGRootElement):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (202013 => 202014)


--- trunk/Source/WebCore/ChangeLog	2016-06-13 22:57:31 UTC (rev 202013)
+++ trunk/Source/WebCore/ChangeLog	2016-06-13 23:05:20 UTC (rev 202014)
@@ -1,3 +1,16 @@
+2016-06-13  Chris Fleizach  <[email protected]>
+
+        AX: CrashTracer: com.apple.WebKit.WebContent at WebCore::AccessibilityRenderObject::remoteSVGRootElement const + 227
+        https://bugs.webkit.org/show_bug.cgi?id=158685
+
+        Reviewed by David Kilzer.
+
+        Crash reports show a null access at a line that tries to dereference a pointer. 
+        I still don't have a way to layout test this, as it seems tied to tear down of the main document.
+
+        * accessibility/AccessibilityRenderObject.cpp:
+        (WebCore::AccessibilityRenderObject::remoteSVGRootElement):
+
 2016-06-13  Jeremy Jones  <[email protected]>
 
         Use two video layer solution only on mac.

Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (202013 => 202014)


--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp	2016-06-13 22:57:31 UTC (rev 202013)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp	2016-06-13 23:05:20 UTC (rev 202014)
@@ -3014,7 +3014,7 @@
     // In order to connect the AX hierarchy from the SVG root element from the loaded resource
     // the parent must be set, because there's no other way to get back to who created the image.
     ASSERT(!createIfNecessary || rootSVGObject);
-    if (!is<AccessibilitySVGRoot>(*rootSVGObject))
+    if (!is<AccessibilitySVGRoot>(rootSVGObject))
         return nullptr;
     
     return downcast<AccessibilitySVGRoot>(rootSVGObject);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to