Title: [202039] trunk/Source/WebCore
- Revision
- 202039
- Author
- [email protected]
- Date
- 2016-06-14 01:08:43 -0700 (Tue, 14 Jun 2016)
Log Message
The vector of mediastreams should be passed via a reference to RTCPeerConnection::addTrack()
https://bugs.webkit.org/show_bug.cgi?id=158701
Pass vector of mediastreams by reference.
Reviewed by Youenn Fablet.
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::addTrack):
* Modules/mediastream/RTCPeerConnection.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (202038 => 202039)
--- trunk/Source/WebCore/ChangeLog 2016-06-14 07:52:25 UTC (rev 202038)
+++ trunk/Source/WebCore/ChangeLog 2016-06-14 08:08:43 UTC (rev 202039)
@@ -1,3 +1,16 @@
+2016-06-14 Nael Ouedraogo <[email protected]>
+
+ The vector of mediastreams should be passed via a reference to RTCPeerConnection::addTrack()
+ https://bugs.webkit.org/show_bug.cgi?id=158701
+
+ Pass vector of mediastreams by reference.
+
+ Reviewed by Youenn Fablet.
+
+ * Modules/mediastream/RTCPeerConnection.cpp:
+ (WebCore::RTCPeerConnection::addTrack):
+ * Modules/mediastream/RTCPeerConnection.h:
+
2016-06-14 Ryosuke Niwa <[email protected]>
Crash inside firstPositionInNode in checkLoadCompleteForThisFrame
Modified: trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp (202038 => 202039)
--- trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2016-06-14 07:52:25 UTC (rev 202038)
+++ trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp 2016-06-14 08:08:43 UTC (rev 202039)
@@ -100,7 +100,7 @@
stop();
}
-RefPtr<RTCRtpSender> RTCPeerConnection::addTrack(Ref<MediaStreamTrack>&& track, Vector<MediaStream*> streams, ExceptionCode& ec)
+RefPtr<RTCRtpSender> RTCPeerConnection::addTrack(Ref<MediaStreamTrack>&& track, const Vector<MediaStream*>& streams, ExceptionCode& ec)
{
if (m_signalingState == SignalingState::Closed) {
ec = INVALID_STATE_ERR;
Modified: trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.h (202038 => 202039)
--- trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.h 2016-06-14 07:52:25 UTC (rev 202038)
+++ trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.h 2016-06-14 08:08:43 UTC (rev 202039)
@@ -67,7 +67,7 @@
const Vector<RefPtr<RTCRtpReceiver>>& getReceivers() const { return m_transceiverSet->getReceivers(); }
const Vector<RefPtr<RTCRtpTransceiver>>& getTransceivers() const override { return m_transceiverSet->list(); }
- RefPtr<RTCRtpSender> addTrack(Ref<MediaStreamTrack>&&, Vector<MediaStream*>, ExceptionCode&);
+ RefPtr<RTCRtpSender> addTrack(Ref<MediaStreamTrack>&&, const Vector<MediaStream*>&, ExceptionCode&);
void removeTrack(RTCRtpSender&, ExceptionCode&);
// This enum is mirrored in RTCRtpTransceiver.h
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
