Title: [202078] trunk/Tools
Revision
202078
Author
[email protected]
Date
2016-06-14 18:45:25 -0700 (Tue, 14 Jun 2016)

Log Message

Debug crash logs are not fully symbolicated on Yosemite
https://bugs.webkit.org/show_bug.cgi?id=158760

Reviewed by Darin Adler.

* BuildSlaveSupport/build.webkit.org-config/master.cfg: Don't enable dSYM generation
for debug builds on Yosemite.

Modified Paths

Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (202077 => 202078)


--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2016-06-15 01:31:00 UTC (rev 202077)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2016-06-15 01:45:25 UTC (rev 202078)
@@ -219,7 +219,9 @@
             self.setCommand(self.command + ['ARCHS=' + architecture])
             if platform == 'ios':
                 self.setCommand(self.command + ['_ONLY_ACTIVE_ARCH_=NO'])
-        if platform in ('mac', 'ios') and buildOnly:
+        # Generating dSYM files is slow, but these are needed to have line numbers in crash reports on testers.
+        # Debug builds on Yosemite can't use dSYMs, because crash logs end up unsymbolicated.
+        if platform in ('mac', 'ios') and buildOnly and (fullPlatform != "mac-yosemite" || configuration != "debug"):
             self.setCommand(self.command + ['DEBUG_INFORMATION_FORMAT=dwarf-with-dsym'])
 
         appendCustomBuildFlags(self, platform, self.getProperty('fullPlatform'))

Modified: trunk/Tools/ChangeLog (202077 => 202078)


--- trunk/Tools/ChangeLog	2016-06-15 01:31:00 UTC (rev 202077)
+++ trunk/Tools/ChangeLog	2016-06-15 01:45:25 UTC (rev 202078)
@@ -1,5 +1,15 @@
 2016-06-14  Alexey Proskuryakov  <[email protected]>
 
+        Debug crash logs are not fully symbolicated on Yosemite
+        https://bugs.webkit.org/show_bug.cgi?id=158760
+
+        Reviewed by Darin Adler.
+
+        * BuildSlaveSupport/build.webkit.org-config/master.cfg: Don't enable dSYM generation
+        for debug builds on Yosemite.
+
+2016-06-14  Alexey Proskuryakov  <[email protected]>
+
         Tests don't work in iOS Simulator when ASan is enabled
         https://bugs.webkit.org/show_bug.cgi?id=158726
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to