Title: [202106] trunk/Source/WebInspectorUI
- Revision
- 202106
- Author
- [email protected]
- Date
- 2016-06-15 14:15:13 -0700 (Wed, 15 Jun 2016)
Log Message
Uncaught Exception: TypeError: undefined is not an object (evaluating 'imageElement.classList')
https://bugs.webkit.org/show_bug.cgi?id=158808
<rdar://problem/26821034>
Patch by Joseph Pecoraro <[email protected]> on 2016-06-15
Reviewed by Brian Burg.
* UserInterface/Views/HeapAllocationsTimelineOverviewGraph.js:
(WebInspector.HeapAllocationsTimelineOverviewGraph.prototype._updateSnapshotMarkers):
If the record is out of the layout bounds of the overview graph, the overview graph
may not have created an image element yet, so bail. Later, when the image element
is created, it would get the appropriate style if the record is selected.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (202105 => 202106)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-06-15 20:59:07 UTC (rev 202105)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-06-15 21:15:13 UTC (rev 202106)
@@ -1,3 +1,17 @@
+2016-06-15 Joseph Pecoraro <[email protected]>
+
+ Uncaught Exception: TypeError: undefined is not an object (evaluating 'imageElement.classList')
+ https://bugs.webkit.org/show_bug.cgi?id=158808
+ <rdar://problem/26821034>
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/HeapAllocationsTimelineOverviewGraph.js:
+ (WebInspector.HeapAllocationsTimelineOverviewGraph.prototype._updateSnapshotMarkers):
+ If the record is out of the layout bounds of the overview graph, the overview graph
+ may not have created an image element yet, so bail. Later, when the image element
+ is created, it would get the appropriate style if the record is selected.
+
2016-06-14 Matt Baker <[email protected]>
Web Inspector: Rename DataGrid.showColumn to setColumnVisible
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineOverviewGraph.js (202105 => 202106)
--- trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineOverviewGraph.js 2016-06-15 20:59:07 UTC (rev 202105)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/HeapAllocationsTimelineOverviewGraph.js 2016-06-15 21:15:13 UTC (rev 202106)
@@ -108,7 +108,9 @@
}
let imageElement = this.selectedRecord[WebInspector.HeapAllocationsTimelineOverviewGraph.RecordElementAssociationSymbol];
- console.assert(imageElement, "Missing snapshot image element for selected record", this.selectedRecord);
+ if (!imageElement)
+ return;
+
imageElement.classList.add("selected");
this._selectedImageElement = imageElement;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
