Title: [202144] trunk/Source/WebCore
Revision
202144
Author
[email protected]
Date
2016-06-16 15:55:53 -0700 (Thu, 16 Jun 2016)

Log Message

Use StringView::toAtomicString() in HTMLImageElement::setBestFitURLAndDPRFromImageCandidate()
https://bugs.webkit.org/show_bug.cgi?id=158853

Reviewed by Brent Fulgham.

Use StringView::toAtomicString() in HTMLImageElement::setBestFitURLAndDPRFromImageCandidate()
as m_bestFitImageURL data member is an AtomicString. This avoids constructing a String and
then atomizing it.

* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::setBestFitURLAndDPRFromImageCandidate):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (202143 => 202144)


--- trunk/Source/WebCore/ChangeLog	2016-06-16 22:47:02 UTC (rev 202143)
+++ trunk/Source/WebCore/ChangeLog	2016-06-16 22:55:53 UTC (rev 202144)
@@ -1,3 +1,17 @@
+2016-06-16  Chris Dumez  <[email protected]>
+
+        Use StringView::toAtomicString() in HTMLImageElement::setBestFitURLAndDPRFromImageCandidate()
+        https://bugs.webkit.org/show_bug.cgi?id=158853
+
+        Reviewed by Brent Fulgham.
+
+        Use StringView::toAtomicString() in HTMLImageElement::setBestFitURLAndDPRFromImageCandidate()
+        as m_bestFitImageURL data member is an AtomicString. This avoids constructing a String and
+        then atomizing it.
+
+        * html/HTMLImageElement.cpp:
+        (WebCore::HTMLImageElement::setBestFitURLAndDPRFromImageCandidate):
+
 2016-06-16  Benjamin Poulain  <[email protected]>
 
         :in-range & :out-of-range CSS pseudo-classes shouldn't match inputs without range limitations

Modified: trunk/Source/WebCore/html/HTMLImageElement.cpp (202143 => 202144)


--- trunk/Source/WebCore/html/HTMLImageElement.cpp	2016-06-16 22:47:02 UTC (rev 202143)
+++ trunk/Source/WebCore/html/HTMLImageElement.cpp	2016-06-16 22:55:53 UTC (rev 202144)
@@ -134,7 +134,7 @@
 
 void HTMLImageElement::setBestFitURLAndDPRFromImageCandidate(const ImageCandidate& candidate)
 {
-    m_bestFitImageURL = candidate.string.toString();
+    m_bestFitImageURL = candidate.string.toAtomicString();
     m_currentSrc = AtomicString(document().completeURL(imageSourceURL()).string());
     if (candidate.density >= 0)
         m_imageDevicePixelRatio = 1 / candidate.density;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to