Title: [202164] trunk/LayoutTests
- Revision
- 202164
- Author
- [email protected]
- Date
- 2016-06-17 04:46:14 -0700 (Fri, 17 Jun 2016)
Log Message
Update test-expected file for failing fullscreen test
https://bugs.webkit.org/show_bug.cgi?id=158838
Patch by Romain Bellessort <[email protected]> on 2016-06-17
Reviewed by Carlos Garcia Campos.
Used MAC version of the test as the default version since only MAC and
GTK do not skip this test and expect the same result. Removed
test-expected files specific to each port when there was one. Prior to
this patch, GTK test was failing unexpectedly.
* fullscreen/video-controls-override-expected.txt:
* platform/efl/fullscreen/video-controls-override-expected.txt: Removed.
* platform/gtk/fullscreen/video-controls-override-expected.txt: Removed.
* platform/mac/fullscreen/video-controls-override-expected.txt: Removed.
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (202163 => 202164)
--- trunk/LayoutTests/ChangeLog 2016-06-17 11:19:32 UTC (rev 202163)
+++ trunk/LayoutTests/ChangeLog 2016-06-17 11:46:14 UTC (rev 202164)
@@ -1,3 +1,20 @@
+2016-06-17 Romain Bellessort <[email protected]>
+
+ Update test-expected file for failing fullscreen test
+ https://bugs.webkit.org/show_bug.cgi?id=158838
+
+ Reviewed by Carlos Garcia Campos.
+
+ Used MAC version of the test as the default version since only MAC and
+ GTK do not skip this test and expect the same result. Removed
+ test-expected files specific to each port when there was one. Prior to
+ this patch, GTK test was failing unexpectedly.
+
+ * fullscreen/video-controls-override-expected.txt:
+ * platform/efl/fullscreen/video-controls-override-expected.txt: Removed.
+ * platform/gtk/fullscreen/video-controls-override-expected.txt: Removed.
+ * platform/mac/fullscreen/video-controls-override-expected.txt: Removed.
+
2016-06-17 Youenn Fablet <[email protected]>
CORS preflight with a non-200 response should be a preflight failure
Modified: trunk/LayoutTests/fullscreen/video-controls-override-expected.txt (202163 => 202164)
--- trunk/LayoutTests/fullscreen/video-controls-override-expected.txt 2016-06-17 11:19:32 UTC (rev 202163)
+++ trunk/LayoutTests/fullscreen/video-controls-override-expected.txt 2016-06-17 11:46:14 UTC (rev 202164)
@@ -6,8 +6,8 @@
EXPECTED (panel = mediaControlsElement(shadowRoot.firstChild, '-webkit-media-controls-panel') != 'null') OK
EXPECTED (internals.shadowPseudoId(panel) == '-webkit-media-controls-panel') OK
EXPECTED (document.defaultView.getComputedStyle(panel)['display'] != 'none') OK
-EXPECTED (document.defaultView.getComputedStyle(panel)['height'] >= '20px') OK
+EXPECTED (parseInt(document.defaultView.getComputedStyle(panel)['height']) >= '20') OK
EVENT(webkitfullscreenchange)
-EXPECTED (document.defaultView.getComputedStyle(panel)['display'] == 'none') OK
+EXPECTED (document.defaultView.getComputedStyle(panel)['display'] == 'none'), OBSERVED '' FAIL
END OF TEST
Deleted: trunk/LayoutTests/platform/efl/fullscreen/video-controls-override-expected.txt (202163 => 202164)
--- trunk/LayoutTests/platform/efl/fullscreen/video-controls-override-expected.txt 2016-06-17 11:19:32 UTC (rev 202163)
+++ trunk/LayoutTests/platform/efl/fullscreen/video-controls-override-expected.txt 2016-06-17 11:46:14 UTC (rev 202164)
@@ -1,13 +0,0 @@
-This tests that the video element's "controls" attribute is overridden in full screen mode, and that the controls are correctly hidden upon exiting full screen. Press any key to continue.
-
-
-EVENT(webkitfullscreenchange)
-EXPECTED (shadowRoot = internals.shadowRoot(video) != 'null') OK
-EXPECTED (panel = mediaControlsElement(shadowRoot.firstChild, '-webkit-media-controls-panel') != 'null') OK
-EXPECTED (internals.shadowPseudoId(panel) == '-webkit-media-controls-panel') OK
-EXPECTED (document.defaultView.getComputedStyle(panel)['display'] != 'none') OK
-EXPECTED (document.defaultView.getComputedStyle(panel)['height'] >= '20px') OK
-EVENT(webkitfullscreenchange)
-EXPECTED (document.defaultView.getComputedStyle(panel)['display'] == 'none'), OBSERVED '' FAIL
-END OF TEST
-
Deleted: trunk/LayoutTests/platform/gtk/fullscreen/video-controls-override-expected.txt (202163 => 202164)
--- trunk/LayoutTests/platform/gtk/fullscreen/video-controls-override-expected.txt 2016-06-17 11:19:32 UTC (rev 202163)
+++ trunk/LayoutTests/platform/gtk/fullscreen/video-controls-override-expected.txt 2016-06-17 11:46:14 UTC (rev 202164)
@@ -1,13 +0,0 @@
-This tests that the video element's "controls" attribute is overridden in full screen mode, and that the controls are correctly hidden upon exiting full screen. Press any key to continue.
-
-
-EVENT(webkitfullscreenchange)
-EXPECTED (shadowRoot = internals.shadowRoot(video) != 'null') OK
-EXPECTED (panel = mediaControlsElement(shadowRoot.firstChild, '-webkit-media-controls-panel') != 'null') OK
-EXPECTED (internals.shadowPseudoId(panel) == '-webkit-media-controls-panel') OK
-EXPECTED (document.defaultView.getComputedStyle(panel)['display'] != 'none') OK
-EXPECTED (document.defaultView.getComputedStyle(panel)['height'] >= '20px') OK
-EVENT(webkitfullscreenchange)
-EXPECTED (document.defaultView.getComputedStyle(panel)['display'] == 'none'), OBSERVED '' FAIL
-END OF TEST
-
Deleted: trunk/LayoutTests/platform/mac/fullscreen/video-controls-override-expected.txt (202163 => 202164)
--- trunk/LayoutTests/platform/mac/fullscreen/video-controls-override-expected.txt 2016-06-17 11:19:32 UTC (rev 202163)
+++ trunk/LayoutTests/platform/mac/fullscreen/video-controls-override-expected.txt 2016-06-17 11:46:14 UTC (rev 202164)
@@ -1,13 +0,0 @@
-This tests that the video element's "controls" attribute is overridden in full screen mode, and that the controls are correctly hidden upon exiting full screen. Press any key to continue.
-
-
-EVENT(webkitfullscreenchange)
-EXPECTED (shadowRoot = internals.shadowRoot(video) != 'null') OK
-EXPECTED (panel = mediaControlsElement(shadowRoot.firstChild, '-webkit-media-controls-panel') != 'null') OK
-EXPECTED (internals.shadowPseudoId(panel) == '-webkit-media-controls-panel') OK
-EXPECTED (document.defaultView.getComputedStyle(panel)['display'] != 'none') OK
-EXPECTED (parseInt(document.defaultView.getComputedStyle(panel)['height']) >= '20') OK
-EVENT(webkitfullscreenchange)
-EXPECTED (document.defaultView.getComputedStyle(panel)['display'] == 'none'), OBSERVED '' FAIL
-END OF TEST
-
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
