Title: [202332] trunk/Source/WebCore
Revision
202332
Author
[email protected]
Date
2016-06-22 10:14:02 -0700 (Wed, 22 Jun 2016)

Log Message

Update document's isPlayingMedia() state whenever media element's media state changes
https://bugs.webkit.org/show_bug.cgi?id=159018
<rdar://problem/26586630>

Reviewed by Beth Dakin.

The Document can end up with a stale m_mediaState if its own value isn't updated when
its constituent HTMLMediaElement's m_mediaStates change.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateMediaState):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (202331 => 202332)


--- trunk/Source/WebCore/ChangeLog	2016-06-22 17:00:23 UTC (rev 202331)
+++ trunk/Source/WebCore/ChangeLog	2016-06-22 17:14:02 UTC (rev 202332)
@@ -1,3 +1,17 @@
+2016-06-22  Jer Noble  <[email protected]>
+
+        Update document's isPlayingMedia() state whenever media element's media state changes
+        https://bugs.webkit.org/show_bug.cgi?id=159018
+        <rdar://problem/26586630>
+
+        Reviewed by Beth Dakin.
+
+        The Document can end up with a stale m_mediaState if its own value isn't updated when
+        its constituent HTMLMediaElement's m_mediaStates change.
+
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::updateMediaState):
+
 2016-06-22  Simon Fraser  <[email protected]>
 
         Crash under GraphicsLayerCA::recursiveCommitChanges() with deep layer trees

Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (202331 => 202332)


--- trunk/Source/WebCore/html/HTMLMediaElement.cpp	2016-06-22 17:00:23 UTC (rev 202331)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp	2016-06-22 17:14:02 UTC (rev 202332)
@@ -6861,6 +6861,11 @@
 
     m_mediaState = state;
     m_mediaSession->mediaStateDidChange(*this, m_mediaState);
+#if ENABLE(MEDIA_SESSION)
+    document().updateIsPlayingMedia(m_elementID);
+#else
+    document().updateIsPlayingMedia();
+#endif
 }
 #endif
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to