Title: [202338] trunk/LayoutTests/imported/w3c
Revision
202338
Author
[email protected]
Date
2016-06-22 11:14:10 -0700 (Wed, 22 Jun 2016)

Log Message

imported/w3c/web-platform-tests/streams/readable-streams/general.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=155760

Patch by Youenn Fablet <[email protected]> on 2016-06-22
Reviewed by Alexey Proskuryakov.

Making test more predictable.
Upstreamed to w3c repository as https://github.com/w3c/web-platform-tests/pull/3203.

* web-platform-tests/streams/readable-streams/general.js:
(promise_test):

Modified Paths

Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (202337 => 202338)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-06-22 18:12:46 UTC (rev 202337)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-06-22 18:14:10 UTC (rev 202338)
@@ -1,3 +1,16 @@
+2016-06-22  Youenn Fablet  <[email protected]>
+
+        imported/w3c/web-platform-tests/streams/readable-streams/general.https.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=155760
+
+        Reviewed by Alexey Proskuryakov.
+
+        Making test more predictable.
+        Upstreamed to w3c repository as https://github.com/w3c/web-platform-tests/pull/3203.
+
+        * web-platform-tests/streams/readable-streams/general.js:
+        (promise_test):
+
 2016-06-21  Youenn Fablet  <[email protected]>
 
         [Fetch API] Rename 'origin-only' referrer policy to 'origin'

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/general.js (202337 => 202338)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/general.js	2016-06-22 18:12:46 UTC (rev 202337)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/streams/readable-streams/general.js	2016-06-22 18:14:10 UTC (rev 202338)
@@ -293,8 +293,12 @@
 promise_test(() => {
 
   let pullCount = 0;
+  const startPromise = Promise.resolve();
 
   const rs = new ReadableStream({
+    start() {
+      return startPromise;
+    },
     pull(c) {
       // Don't enqueue immediately after start. We want the stream to be empty when we call .read() on it.
       if (pullCount > 0) {
@@ -304,10 +308,9 @@
     }
   });
 
-  // WEBKIT modification: delay(1) replaced by delay(10) to ensure that pull promise is resolved before calling below thened code.
-  return delay(10).then(() => {
+  return startPromise.then(() => {
     assert_equals(pullCount, 1, 'pull should be called once start finishes');
-
+  }).then(() => {
     const reader = rs.getReader();
     const read = reader.read();
     assert_equals(pullCount, 2, 'pull should be called when read is called');
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to