Title: [202461] trunk/Tools
- Revision
- 202461
- Author
- [email protected]
- Date
- 2016-06-24 16:49:15 -0700 (Fri, 24 Jun 2016)
Log Message
REGRESSION: Weak symbol warning when linking TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=159104
Reviewed by Mark Lam.
The problem is that the tests were not compiled with -fvisibility=hidden like the rest of
WK.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (202460 => 202461)
--- trunk/Tools/ChangeLog 2016-06-24 23:34:45 UTC (rev 202460)
+++ trunk/Tools/ChangeLog 2016-06-24 23:49:15 UTC (rev 202461)
@@ -1,3 +1,15 @@
+2016-06-24 Filip Pizlo <[email protected]>
+
+ REGRESSION: Weak symbol warning when linking TestWebKitAPI
+ https://bugs.webkit.org/show_bug.cgi?id=159104
+
+ Reviewed by Mark Lam.
+
+ The problem is that the tests were not compiled with -fvisibility=hidden like the rest of
+ WK.
+
+ * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+
2016-06-24 David Kilzer <[email protected]>
parser_unittests.pl should not hardcode list of tests
Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (202460 => 202461)
--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2016-06-24 23:34:45 UTC (rev 202460)
+++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2016-06-24 23:49:15 UTC (rev 202461)
@@ -2332,6 +2332,11 @@
isa = XCBuildConfiguration;
baseConfigurationReference = 7C83E0271D0A5B8D00FEBCF3 /* TestWTFLibrary.xcconfig */;
buildSettings = {
+ OTHER_CPLUSPLUSFLAGS = (
+ "$(inherited)",
+ "-ftemplate-depth=256",
+ "-fvisibility=hidden",
+ );
};
name = Debug;
};
@@ -2339,6 +2344,11 @@
isa = XCBuildConfiguration;
baseConfigurationReference = 7C83E0271D0A5B8D00FEBCF3 /* TestWTFLibrary.xcconfig */;
buildSettings = {
+ OTHER_CPLUSPLUSFLAGS = (
+ "$(inherited)",
+ "-ftemplate-depth=256",
+ "-fvisibility=hidden",
+ );
};
name = Release;
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
