Title: [202469] trunk/Tools
- Revision
- 202469
- Author
- [email protected]
- Date
- 2016-06-25 12:07:15 -0700 (Sat, 25 Jun 2016)
Log Message
REGRESSION: Weak symbol warning when linking TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=159104
Reviewed by Dan Bernstein.
This uses a better approach to turn on -fvisility=hidden. All of the other projects set
this flag in xcconfig, using "GCC_SYMBOLS_PRIVATE_EXTERN = YES;".
* TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
* TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Revert r202461.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (202468 => 202469)
--- trunk/Tools/ChangeLog 2016-06-25 09:00:47 UTC (rev 202468)
+++ trunk/Tools/ChangeLog 2016-06-25 19:07:15 UTC (rev 202469)
@@ -1,3 +1,17 @@
+2016-06-25 Filip Pizlo <[email protected]>
+
+ REGRESSION: Weak symbol warning when linking TestWebKitAPI
+ https://bugs.webkit.org/show_bug.cgi?id=159104
+
+ Reviewed by Dan Bernstein.
+
+ This uses a better approach to turn on -fvisility=hidden. All of the other projects set
+ this flag in xcconfig, using "GCC_SYMBOLS_PRIVATE_EXTERN = YES;".
+
+ * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
+ * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
+ * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Revert r202461.
+
2016-06-25 Per Arne Vollan <[email protected]>
[Win] The test fast/events/wheel-event-destroys-frame.html is timing out.
Modified: trunk/Tools/TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig (202468 => 202469)
--- trunk/Tools/TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig 2016-06-25 09:00:47 UTC (rev 202468)
+++ trunk/Tools/TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig 2016-06-25 19:07:15 UTC (rev 202469)
@@ -27,3 +27,4 @@
PRODUCT_NAME = TestWTF;
SKIP_INSTALL = YES;
+GCC_SYMBOLS_PRIVATE_EXTERN = YES;
Modified: trunk/Tools/TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig (202468 => 202469)
--- trunk/Tools/TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig 2016-06-25 09:00:47 UTC (rev 202468)
+++ trunk/Tools/TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig 2016-06-25 19:07:15 UTC (rev 202469)
@@ -27,3 +27,4 @@
PRODUCT_NAME = TestWebKitAPI;
SKIP_INSTALL = YES;
+GCC_SYMBOLS_PRIVATE_EXTERN = YES;
Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (202468 => 202469)
--- trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2016-06-25 09:00:47 UTC (rev 202468)
+++ trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj 2016-06-25 19:07:15 UTC (rev 202469)
@@ -2332,11 +2332,6 @@
isa = XCBuildConfiguration;
baseConfigurationReference = 7C83E0271D0A5B8D00FEBCF3 /* TestWTFLibrary.xcconfig */;
buildSettings = {
- OTHER_CPLUSPLUSFLAGS = (
- "$(inherited)",
- "-ftemplate-depth=256",
- "-fvisibility=hidden",
- );
};
name = Debug;
};
@@ -2344,11 +2339,6 @@
isa = XCBuildConfiguration;
baseConfigurationReference = 7C83E0271D0A5B8D00FEBCF3 /* TestWTFLibrary.xcconfig */;
buildSettings = {
- OTHER_CPLUSPLUSFLAGS = (
- "$(inherited)",
- "-ftemplate-depth=256",
- "-fvisibility=hidden",
- );
};
name = Release;
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
