Title: [202482] trunk/Source/WebCore
- Revision
- 202482
- Author
- [email protected]
- Date
- 2016-06-27 02:21:51 -0700 (Mon, 27 Jun 2016)
Log Message
[GStreamer] top/bottom black bars added needlessly in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=158980
Patch by Philippe Normand <[email protected]> on 2016-06-27
Reviewed by Carlos Garcia Campos.
The natural video size calculation depends on the validity of the
current sample, so whenever the first sample reached the sink it's a
good idea to reflect this on the player which will update its natural
size accordingly.
Fixes an issue where black borders were added on top and bottom of
fullscreen video.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (202481 => 202482)
--- trunk/Source/WebCore/ChangeLog 2016-06-27 09:01:57 UTC (rev 202481)
+++ trunk/Source/WebCore/ChangeLog 2016-06-27 09:21:51 UTC (rev 202482)
@@ -1,3 +1,21 @@
+2016-06-27 Philippe Normand <[email protected]>
+
+ [GStreamer] top/bottom black bars added needlessly in fullscreen
+ https://bugs.webkit.org/show_bug.cgi?id=158980
+
+ Reviewed by Carlos Garcia Campos.
+
+ The natural video size calculation depends on the validity of the
+ current sample, so whenever the first sample reached the sink it's a
+ good idea to reflect this on the player which will update its natural
+ size accordingly.
+
+ Fixes an issue where black borders were added on top and bottom of
+ fullscreen video.
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+ (WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
+
2016-06-27 Youenn Fablet <[email protected]>
Remove didFailRedirectCheck ThreadableLoaderClient callback
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (202481 => 202482)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2016-06-27 09:01:57 UTC (rev 202481)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2016-06-27 09:21:51 UTC (rev 202482)
@@ -534,11 +534,18 @@
void MediaPlayerPrivateGStreamerBase::triggerRepaint(GstSample* sample)
{
+ bool triggerResize;
{
WTF::GMutexLocker<GMutex> lock(m_sampleMutex);
+ triggerResize = !m_sample;
m_sample = sample;
}
+ if (triggerResize) {
+ LOG_MEDIA_MESSAGE("First sample reached the sink, triggering video dimensions update");
+ m_player->sizeChanged();
+ }
+
#if USE(COORDINATED_GRAPHICS_THREADED)
#if USE(GSTREAMER_GL)
pushTextureToCompositor();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
