Title: [202488] trunk/Source/WebCore
Revision
202488
Author
[email protected]
Date
2016-06-27 10:33:38 -0700 (Mon, 27 Jun 2016)

Log Message

Small refactoring MathMLInlineContainerElement::createElementRenderer
https://bugs.webkit.org/show_bug.cgi?id=159131

Reviewed by Brent Fulgham.

Many of the MathML renderer classes have been merged during the MathML refactoring. We
simplify how instances are created in MathMLInlineContainerElement::createElementRenderer
by removing duplicate createRenderer calls.

No new tests, behavior unchanged.

* mathml/MathMLInlineContainerElement.cpp:
(WebCore::MathMLInlineContainerElement::createElementRenderer):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (202487 => 202488)


--- trunk/Source/WebCore/ChangeLog	2016-06-27 16:48:31 UTC (rev 202487)
+++ trunk/Source/WebCore/ChangeLog	2016-06-27 17:33:38 UTC (rev 202488)
@@ -1,3 +1,19 @@
+2016-06-27  Frederic Wang  <[email protected]>
+
+        Small refactoring MathMLInlineContainerElement::createElementRenderer
+        https://bugs.webkit.org/show_bug.cgi?id=159131
+
+        Reviewed by Brent Fulgham.
+
+        Many of the MathML renderer classes have been merged during the MathML refactoring. We
+        simplify how instances are created in MathMLInlineContainerElement::createElementRenderer
+        by removing duplicate createRenderer calls.
+
+        No new tests, behavior unchanged.
+
+        * mathml/MathMLInlineContainerElement.cpp:
+        (WebCore::MathMLInlineContainerElement::createElementRenderer):
+
 2016-06-27  Miguel Gomez  <[email protected]>
 
         [GTK][EFL] Build with threaded compositor enabled is broken

Modified: trunk/Source/WebCore/mathml/MathMLInlineContainerElement.cpp (202487 => 202488)


--- trunk/Source/WebCore/mathml/MathMLInlineContainerElement.cpp	2016-06-27 16:48:31 UTC (rev 202487)
+++ trunk/Source/WebCore/mathml/MathMLInlineContainerElement.cpp	2016-06-27 17:33:38 UTC (rev 202488)
@@ -65,24 +65,12 @@
 
 RenderPtr<RenderElement> MathMLInlineContainerElement::createElementRenderer(RenderStyle&& style, const RenderTreePosition&)
 {
-    if (hasTagName(annotation_xmlTag))
+    if (hasTagName(annotation_xmlTag) || hasTagName(merrorTag) || hasTagName(mphantomTag) || hasTagName(mrowTag) || hasTagName(mstyleTag))
         return createRenderer<RenderMathMLRow>(*this, WTFMove(style));
-    if (hasTagName(merrorTag) || hasTagName(mphantomTag) || hasTagName(mrowTag) || hasTagName(mstyleTag))
-        return createRenderer<RenderMathMLRow>(*this, WTFMove(style));
-    if (hasTagName(msubTag))
+    if (hasTagName(msubTag) || hasTagName(msupTag) || hasTagName(msubsupTag) || hasTagName(mmultiscriptsTag))
         return createRenderer<RenderMathMLScripts>(*this, WTFMove(style));
-    if (hasTagName(msupTag))
-        return createRenderer<RenderMathMLScripts>(*this, WTFMove(style));
-    if (hasTagName(msubsupTag))
-        return createRenderer<RenderMathMLScripts>(*this, WTFMove(style));
-    if (hasTagName(mmultiscriptsTag))
-        return createRenderer<RenderMathMLScripts>(*this, WTFMove(style));
-    if (hasTagName(moverTag))
+    if (hasTagName(moverTag) || hasTagName(munderTag) || hasTagName(munderoverTag))
         return createRenderer<RenderMathMLUnderOver>(*this, WTFMove(style));
-    if (hasTagName(munderTag))
-        return createRenderer<RenderMathMLUnderOver>(*this, WTFMove(style));
-    if (hasTagName(munderoverTag))
-        return createRenderer<RenderMathMLUnderOver>(*this, WTFMove(style));
     if (hasTagName(mfracTag))
         return createRenderer<RenderMathMLFraction>(*this, WTFMove(style));
     if (hasTagName(msqrtTag) || hasTagName(mrootTag))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to