Title: [202499] trunk/Source/WebCore
Revision
202499
Author
[email protected]
Date
2016-06-27 11:28:00 -0700 (Mon, 27 Jun 2016)

Log Message

No error message when passing an invalid API version to ApplePaySession constructor
https://bugs.webkit.org/show_bug.cgi?id=159154

Reviewed by Tim Horton.

Log an error message if the version is not supported. Also, check for version 0 since that is also not supported.

* Modules/applepay/ApplePaySession.cpp:
(WebCore::ApplePaySession::create):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (202498 => 202499)


--- trunk/Source/WebCore/ChangeLog	2016-06-27 18:18:37 UTC (rev 202498)
+++ trunk/Source/WebCore/ChangeLog	2016-06-27 18:28:00 UTC (rev 202499)
@@ -1,3 +1,15 @@
+2016-06-27  Anders Carlsson  <[email protected]>
+
+        No error message when passing an invalid API version to ApplePaySession constructor
+        https://bugs.webkit.org/show_bug.cgi?id=159154
+
+        Reviewed by Tim Horton.
+
+        Log an error message if the version is not supported. Also, check for version 0 since that is also not supported.
+
+        * Modules/applepay/ApplePaySession.cpp:
+        (WebCore::ApplePaySession::create):
+
 2016-06-27  Joanmarie Diggs  <[email protected]>
 
         AX: Anonymous RenderMathMLOperators are not exposed to the accessibility tree

Modified: trunk/Source/WebCore/Modules/applepay/ApplePaySession.cpp (202498 => 202499)


--- trunk/Source/WebCore/Modules/applepay/ApplePaySession.cpp	2016-06-27 18:18:37 UTC (rev 202498)
+++ trunk/Source/WebCore/Modules/applepay/ApplePaySession.cpp	2016-06-27 18:28:00 UTC (rev 202499)
@@ -649,7 +649,8 @@
 
     auto& paymentCoordinator = document.frame()->mainFrame().paymentCoordinator();
 
-    if (!paymentCoordinator.supportsVersion(version)) {
+    if (!version || !paymentCoordinator.supportsVersion(version)) {
+        window.printErrorMessage(makeString("\"" + String::number(version), "\" is not a supported version."));
         ec = INVALID_ACCESS_ERR;
         return nullptr;
     }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to