Title: [202515] trunk/Source/_javascript_Core
- Revision
- 202515
- Author
- [email protected]
- Date
- 2016-06-27 14:50:46 -0700 (Mon, 27 Jun 2016)
Log Message
Web Inspector: CRASH in backend at Inspector::HeapFrontendDispatcher::garbageCollected + 552 when closing frontend/inspected page
https://bugs.webkit.org/show_bug.cgi?id=159075
<rdar://problem/26094341>
Reviewed by Filip Pizlo.
This change caused JSC stress tests to all hit an assertion in RunLoop.
We should use RunLoop::current() to create the RunLoop::Timer since JSC-only
clients like testapi and jsc don't ever call initializeMainRunLoop().
* inspector/agents/InspectorHeapAgent.cpp:
(Inspector::SendGarbageCollectionEventsTask::SendGarbageCollectionEventsTask):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (202514 => 202515)
--- trunk/Source/_javascript_Core/ChangeLog 2016-06-27 21:45:49 UTC (rev 202514)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-06-27 21:50:46 UTC (rev 202515)
@@ -1,3 +1,18 @@
+2016-06-27 Brian Burg <[email protected]>
+
+ Web Inspector: CRASH in backend at Inspector::HeapFrontendDispatcher::garbageCollected + 552 when closing frontend/inspected page
+ https://bugs.webkit.org/show_bug.cgi?id=159075
+ <rdar://problem/26094341>
+
+ Reviewed by Filip Pizlo.
+
+ This change caused JSC stress tests to all hit an assertion in RunLoop.
+ We should use RunLoop::current() to create the RunLoop::Timer since JSC-only
+ clients like testapi and jsc don't ever call initializeMainRunLoop().
+
+ * inspector/agents/InspectorHeapAgent.cpp:
+ (Inspector::SendGarbageCollectionEventsTask::SendGarbageCollectionEventsTask):
+
2016-06-27 Filip Pizlo <[email protected]>
B3::Procedure::resetReachability() can create dangling references from Upsilons to Phis
Modified: trunk/Source/_javascript_Core/inspector/agents/InspectorHeapAgent.cpp (202514 => 202515)
--- trunk/Source/_javascript_Core/inspector/agents/InspectorHeapAgent.cpp 2016-06-27 21:45:49 UTC (rev 202514)
+++ trunk/Source/_javascript_Core/inspector/agents/InspectorHeapAgent.cpp 2016-06-27 21:50:46 UTC (rev 202515)
@@ -61,7 +61,7 @@
SendGarbageCollectionEventsTask::SendGarbageCollectionEventsTask(HeapFrontendDispatcher& frontendDispatcher)
: m_frontendDispatcher(frontendDispatcher)
- , m_timer(RunLoop::main(), this, &SendGarbageCollectionEventsTask::timerFired)
+ , m_timer(RunLoop::current(), this, &SendGarbageCollectionEventsTask::timerFired)
{
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
