Title: [202537] trunk/Source/WebCore
Revision
202537
Author
[email protected]
Date
2016-06-27 20:25:47 -0700 (Mon, 27 Jun 2016)

Log Message

Don't keep all newly created potential custom elements alive when the feature is disabled
https://bugs.webkit.org/show_bug.cgi?id=159113

Reviewed by Daniel Bates.

Don't keep all HTML unknown elements which has a valid custom element alive when the feature is turned off.

Ideally we want to conform to the behavior in the Custom Elements specification and only upgrade an element
that is inserted into the document. We'll implement that later.

* dom/Document.cpp:
(WebCore::createHTMLElementWithNameValidation):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (202536 => 202537)


--- trunk/Source/WebCore/ChangeLog	2016-06-28 02:58:16 UTC (rev 202536)
+++ trunk/Source/WebCore/ChangeLog	2016-06-28 03:25:47 UTC (rev 202537)
@@ -1,3 +1,18 @@
+2016-06-24  Ryosuke Niwa  <[email protected]>
+
+        Don't keep all newly created potential custom elements alive when the feature is disabled
+        https://bugs.webkit.org/show_bug.cgi?id=159113
+
+        Reviewed by Daniel Bates.
+
+        Don't keep all HTML unknown elements which has a valid custom element alive when the feature is turned off.
+
+        Ideally we want to conform to the behavior in the Custom Elements specification and only upgrade an element
+        that is inserted into the document. We'll implement that later.
+
+        * dom/Document.cpp:
+        (WebCore::createHTMLElementWithNameValidation):
+
 2016-06-27  Simon Fraser  <[email protected]>
 
         [iOS] -webkit-overflow-scrolling: touch prevents repaint with RTL

Modified: trunk/Source/WebCore/dom/Document.cpp (202536 => 202537)


--- trunk/Source/WebCore/dom/Document.cpp	2016-06-28 02:58:16 UTC (rev 202536)
+++ trunk/Source/WebCore/dom/Document.cpp	2016-06-28 03:25:47 UTC (rev 202537)
@@ -896,7 +896,8 @@
     QualifiedName qualifiedName(nullAtom, localName, xhtmlNamespaceURI);
 
 #if ENABLE(CUSTOM_ELEMENTS)
-    if (Document::validateCustomElementName(localName) == CustomElementNameValidationStatus::Valid) {
+    if (RuntimeEnabledFeatures::sharedFeatures().customElementsEnabled()
+        && Document::validateCustomElementName(localName) == CustomElementNameValidationStatus::Valid) {
         Ref<HTMLElement> element = HTMLElement::create(qualifiedName, document);
         element->setIsUnresolvedCustomElement();
         document.ensureCustomElementDefinitions().addUpgradeCandidate(element.get());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to