Title: [202562] trunk/Source/WebCore
- Revision
- 202562
- Author
- [email protected]
- Date
- 2016-06-28 07:16:36 -0700 (Tue, 28 Jun 2016)
Log Message
AX: Remove dead code in AccessibilityRenderObject::textUnderElement
https://bugs.webkit.org/show_bug.cgi?id=159205
Patch by Frederic Wang <[email protected]> on 2016-06-28
Reviewed by Joanmarie Diggs.
RenderMathMLOperator used to destroy its descendants and to replace them with an anonymous
text node wrapped inside anonymous blocks. After r202420, it just behaves as any other token
elements. Hence we remove the code in AccessibilityRenderObject::textUnderElement that was
used to handle this specific render tree structure.
No new tests, already covered by accessibility/math-text.html.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement): Remove dead code for RenderText and RenderMathMLOperator.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (202561 => 202562)
--- trunk/Source/WebCore/ChangeLog 2016-06-28 14:10:03 UTC (rev 202561)
+++ trunk/Source/WebCore/ChangeLog 2016-06-28 14:16:36 UTC (rev 202562)
@@ -1,3 +1,20 @@
+2016-06-28 Frederic Wang <[email protected]>
+
+ AX: Remove dead code in AccessibilityRenderObject::textUnderElement
+ https://bugs.webkit.org/show_bug.cgi?id=159205
+
+ Reviewed by Joanmarie Diggs.
+
+ RenderMathMLOperator used to destroy its descendants and to replace them with an anonymous
+ text node wrapped inside anonymous blocks. After r202420, it just behaves as any other token
+ elements. Hence we remove the code in AccessibilityRenderObject::textUnderElement that was
+ used to handle this specific render tree structure.
+
+ No new tests, already covered by accessibility/math-text.html.
+
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::textUnderElement): Remove dead code for RenderText and RenderMathMLOperator.
+
2016-06-28 Per Arne Vollan <[email protected]>
[Win] Custom elements tests are failing.
Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (202561 => 202562)
--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2016-06-28 14:10:03 UTC (rev 202561)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2016-06-28 14:16:36 UTC (rev 202562)
@@ -632,16 +632,10 @@
bool isRenderText = is<RenderText>(*m_renderer);
#if ENABLE(MATHML)
- // Math operators create RenderText nodes on the fly that are not tied into the DOM in a reasonable way,
- // so rangeOfContents does not work for them (nor does regular text selection).
- if (isRenderText && m_renderer->isAnonymous() && ancestorsOfType<RenderMathMLOperator>(*m_renderer).first())
- return downcast<RenderText>(*m_renderer).text();
if (isAnonymousMathOperator()) {
UChar operatorChar = downcast<RenderMathMLOperator>(*m_renderer).textContent();
return operatorChar ? String(&operatorChar, 1) : String();
}
- if (is<RenderMathMLOperator>(*m_renderer) && !m_renderer->isAnonymous())
- return downcast<RenderMathMLOperator>(*m_renderer).element().textContent();
#endif
if (shouldGetTextFromNode(mode))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
