Title: [202592] trunk/Source/WebCore
- Revision
- 202592
- Author
- [email protected]
- Date
- 2016-06-28 15:11:45 -0700 (Tue, 28 Jun 2016)
Log Message
Remove incorrect comments in HTMLCanvasElement
https://bugs.webkit.org/show_bug.cgi?id=159229
Reviewed by Sam Weinig.
These comments are wrong.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::probablySupportsContext):
(WebCore::HTMLCanvasElement::getContext): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (202591 => 202592)
--- trunk/Source/WebCore/ChangeLog 2016-06-28 22:09:06 UTC (rev 202591)
+++ trunk/Source/WebCore/ChangeLog 2016-06-28 22:11:45 UTC (rev 202592)
@@ -1,3 +1,16 @@
+2016-06-28 Dean Jackson <[email protected]>
+
+ Remove incorrect comments in HTMLCanvasElement
+ https://bugs.webkit.org/show_bug.cgi?id=159229
+
+ Reviewed by Sam Weinig.
+
+ These comments are wrong.
+
+ * html/HTMLCanvasElement.cpp:
+ (WebCore::HTMLCanvasElement::probablySupportsContext):
+ (WebCore::HTMLCanvasElement::getContext): Deleted.
+
2016-06-28 Geoffrey Garen <[email protected]>
CrashTracer beneath JSC::MarkedBlock::specializedSweep
Modified: trunk/Source/WebCore/html/HTMLCanvasElement.cpp (202591 => 202592)
--- trunk/Source/WebCore/html/HTMLCanvasElement.cpp 2016-06-28 22:09:06 UTC (rev 202591)
+++ trunk/Source/WebCore/html/HTMLCanvasElement.cpp 2016-06-28 22:11:45 UTC (rev 202592)
@@ -206,14 +206,6 @@
CanvasRenderingContext* HTMLCanvasElement::getContext(const String& type, CanvasContextAttributes* attrs)
{
- // A Canvas can either be "2D" or "webgl" but never both. If you request a 2D canvas and the existing
- // context is already 2D, just return that. If the existing context is WebGL, then destroy it
- // before creating a new 2D context. Vice versa when requesting a WebGL canvas. Requesting a
- // context with any other type string will destroy any existing context.
-
- // FIXME: The code depends on the context not going away once created, to prevent JS from
- // seeing a dangling pointer. So for now we will disallow the context from being changed
- // once it is created. https://bugs.webkit.org/show_bug.cgi?id=117095
if (is2dType(type)) {
if (m_context && !m_context->is2d())
return nullptr;
@@ -271,11 +263,8 @@
bool HTMLCanvasElement::probablySupportsContext(const String& type, CanvasContextAttributes*)
{
- // FIXME: Provide implementation that accounts for attributes. Bugzilla bug 117093
+ // FIXME: Provide implementation that accounts for attributes.
// https://bugs.webkit.org/show_bug.cgi?id=117093
-
- // FIXME: The code depends on the context not going away once created (as getContext
- // is implemented under this assumption) https://bugs.webkit.org/show_bug.cgi?id=117095
if (is2dType(type))
return !m_context || m_context->is2d();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
