Title: [202606] trunk/Tools
- Revision
- 202606
- Author
- [email protected]
- Date
- 2016-06-28 20:56:18 -0700 (Tue, 28 Jun 2016)
Log Message
Use a regex to check if a test step is for _javascript_Core
https://bugs.webkit.org/show_bug.cgi?id=159224
Patch by Srinivasan Vijayaraghavan <[email protected]> on 2016-06-28
Reviewed by Geoffrey Garen.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
(BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype._parseData): Replace array membership test with regex test.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js (202605 => 202606)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js 2016-06-29 03:53:16 UTC (rev 202605)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js 2016-06-29 03:56:18 UTC (rev 202606)
@@ -109,7 +109,7 @@
var message = this.revisionContentForIteration(mostRecentFinishedIteration, mostRecentFinishedIteration.productive ? mostRecentSuccessfulIteration : null);
if (!mostRecentFinishedIteration.productive) {
var status = StatusLineView.Status.Danger;
- } else if (mostRecentFinishedIteration.failedTestSteps.length === 1 && ["jscore-test", "webkit-32bit-jsc-test", "webkit-jsc-cloop-test"].indexOf(mostRecentFinishedIteration.failedTestSteps[0].name) >= 0) {
+ } else if (mostRecentFinishedIteration.failedTestSteps.length === 1 && /(?=.*test)(?=.*jsc)/.test(mostRecentFinishedIteration.failedTestSteps[0].name)) {
var failedStep = mostRecentFinishedIteration.failedTestSteps[0];
var URL = "" failedStep.name);
var statusView = new StatusLineView(message, StatusLineView.Status.Bad, this._testStepFailureDescription(failedStep), failedStep.failureCount, URL);
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js (202605 => 202606)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2016-06-29 03:53:16 UTC (rev 202605)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2016-06-29 03:56:18 UTC (rev 202606)
@@ -251,7 +251,7 @@
var results = new BuildbotTestResults(step);
if (step.name === "layout-test")
this.layoutTestResults = results;
- else if (["jscore-test", "webkit-32bit-jsc-test", "webkit-jsc-cloop-test"].indexOf(step.name) >= 0)
+ else if (/(?=.*test)(?=.*jsc)/.test(step.name))
this._javascript_CoreTestResults = results;
if (results.allPassed)
return;
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js (202605 => 202606)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js 2016-06-29 03:53:16 UTC (rev 202605)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js 2016-06-29 03:56:18 UTC (rev 202606)
@@ -105,7 +105,7 @@
if (failedStep.name === "layout-test") {
var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, this._testStepFailureDescription(failedStep), failedStep.tooManyFailures ? failedStep.failureCount + "\uff0b" : failedStep.failureCount, iteration.queue.buildbot.layoutTestResultsURLForIteration(iteration));
new PopoverTracker(status.statusBubbleElement, this._presentPopoverForLayoutTestRegressions.bind(this), iteration);
- } else if (["jscore-test", "webkit-32bit-jsc-test", "webkit-jsc-cloop-test"].indexOf(failedStep.name) >= 0) {
+ } else if (/(?=.*test)(?=.*jsc)/.test(failedStep.name)) {
var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, this._testStepFailureDescription(failedStep), failedStep.failureCount, iteration.queue.buildbot._javascript_CoreTestStdioUrlForIteration(iteration, failedStep.name));
new PopoverTracker(status.statusBubbleElement, this._presentPopoverForJavaScriptCoreTestRegressions.bind(this, failedStep.name), iteration);
} else {
Modified: trunk/Tools/ChangeLog (202605 => 202606)
--- trunk/Tools/ChangeLog 2016-06-29 03:53:16 UTC (rev 202605)
+++ trunk/Tools/ChangeLog 2016-06-29 03:56:18 UTC (rev 202606)
@@ -1,3 +1,17 @@
+2016-06-28 Srinivasan Vijayaraghavan <[email protected]>
+
+ Use a regex to check if a test step is for _javascript_Core
+ https://bugs.webkit.org/show_bug.cgi?id=159224
+
+ Reviewed by Geoffrey Garen.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
+ (BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
+ (BuildbotIteration.prototype._parseData): Replace array membership test with regex test.
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
+ (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test.
+
2016-06-28 Michael Saboff <[email protected]>
btjs no longer accepts optional frame count argument
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
