Title: [202781] trunk/Source/WTF
Revision
202781
Author
[email protected]
Date
2016-07-02 10:47:52 -0700 (Sat, 02 Jul 2016)

Log Message

Unreviewed, roll back unintentional commit in r202778.

* benchmarks/LockFairnessTest.cpp:
(main):

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (202780 => 202781)


--- trunk/Source/WTF/ChangeLog	2016-07-02 17:45:57 UTC (rev 202780)
+++ trunk/Source/WTF/ChangeLog	2016-07-02 17:47:52 UTC (rev 202781)
@@ -1,3 +1,10 @@
+2016-07-02  Filip Pizlo  <[email protected]>
+
+        Unreviewed, roll back unintentional commit in r202778.
+
+        * benchmarks/LockFairnessTest.cpp:
+        (main):
+
 2016-07-01  Jer Noble  <[email protected]>
 
         Deadlock inside -[WebCoreNSURLSession dealloc]

Modified: trunk/Source/WTF/benchmarks/LockFairnessTest.cpp (202780 => 202781)


--- trunk/Source/WTF/benchmarks/LockFairnessTest.cpp	2016-07-02 17:45:57 UTC (rev 202780)
+++ trunk/Source/WTF/benchmarks/LockFairnessTest.cpp	2016-07-02 17:47:52 UTC (rev 202781)
@@ -48,13 +48,12 @@
 
 NO_RETURN void usage()
 {
-    printf("Usage: LockFairnessTest yieldspinlock|pausespinlock|wordlock|lock|barginglock|bargingwordlock|thunderlock|thunderwordlock|cascadelock|cascadewordlockhandofflock|mutex|all <num threads> <seconds per test> <microseconds in critical section>\n");
+    printf("Usage: LockFairnessTest yieldspinlock|pausespinlock|wordlock|lock|barginglock|bargingwordlock|thunderlock|thunderwordlock|cascadelock|cascadewordlockhandofflock|mutex|all <num threads> <seconds per test>\n");
     exit(1);
 }
 
 unsigned numThreads;
 double secondsPerTest;
-unsigned microsecondsInCriticalSection;
 
 struct Benchmark {
     template<typename LockType>
@@ -73,19 +72,9 @@
             threads[threadIndex] = createThread(
                 "Benchmark Thread",
                 [&, threadIndex] () {
-                    if (!microsecondsInCriticalSection) {
-                        while (keepGoing) {
-                            lock.lock();
-                            counts[threadIndex]++;
-                            lock.unlock();
-                        }
-                        return;
-                    }
-                    
                     while (keepGoing) {
                         lock.lock();
                         counts[threadIndex]++;
-                        usleep(microsecondsInCriticalSection);
                         lock.unlock();
                     }
                 });
@@ -117,10 +106,9 @@
 {
     WTF::initializeThreading();
     
-    if (argc != 5
+    if (argc != 4
         || sscanf(argv[2], "%u", &numThreads) != 1
-        || sscanf(argv[3], "%lf", &secondsPerTest) != 1
-        || sscanf(argv[4], "%u", &microsecondsInCriticalSection) != 1)
+        || sscanf(argv[3], "%lf", &secondsPerTest) != 1)
         usage();
     
     runEverything<Benchmark>(argv[1]);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to