Title: [202804] trunk/Tools
- Revision
- 202804
- Author
- [email protected]
- Date
- 2016-07-04 01:06:05 -0700 (Mon, 04 Jul 2016)
Log Message
webkit-patch failure-reason always raises TypeError
https://bugs.webkit.org/show_bug.cgi?id=159394
Patch by Fujii Hironori <[email protected]> on 2016-07-04
Reviewed by Benjamin Poulain.
In r170637 (Bug 133067), the first and second arguments of
pluralize were swapped.
* Scripts/webkitpy/tool/commands/queries.py:
(FailureReason._builder_to_explain): Swap the first and second
arguments of pluralize.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (202803 => 202804)
--- trunk/Tools/ChangeLog 2016-07-04 07:44:06 UTC (rev 202803)
+++ trunk/Tools/ChangeLog 2016-07-04 08:06:05 UTC (rev 202804)
@@ -1,3 +1,17 @@
+2016-07-04 Fujii Hironori <[email protected]>
+
+ webkit-patch failure-reason always raises TypeError
+ https://bugs.webkit.org/show_bug.cgi?id=159394
+
+ Reviewed by Benjamin Poulain.
+
+ In r170637 (Bug 133067), the first and second arguments of
+ pluralize were swapped.
+
+ * Scripts/webkitpy/tool/commands/queries.py:
+ (FailureReason._builder_to_explain): Swap the first and second
+ arguments of pluralize.
+
2016-07-02 Youenn Fablet <[email protected]>
Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/queries.py (202803 => 202804)
--- trunk/Tools/Scripts/webkitpy/tool/commands/queries.py 2016-07-04 07:44:06 UTC (rev 202803)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/queries.py 2016-07-04 08:06:05 UTC (rev 202804)
@@ -315,7 +315,7 @@
def _builder_to_explain(self):
builder_statuses = self._tool.buildbot.builder_statuses()
red_statuses = [status for status in builder_statuses if not status["is_green"]]
- print "%s failing" % (pluralize("builder", len(red_statuses)))
+ print "%s failing" % (pluralize(len(red_statuses), "builder"))
builder_choices = [status["name"] for status in red_statuses]
# We could offer an "All" choice here.
chosen_name = self._tool.user.prompt_with_list("Which builder to diagnose:", builder_choices)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
