Title: [202872] trunk/Source/WebCore
- Revision
- 202872
- Author
- [email protected]
- Date
- 2016-07-06 13:03:09 -0700 (Wed, 06 Jul 2016)
Log Message
Do not animate video fullscreen exit when page has navigated away.
https://bugs.webkit.org/show_bug.cgi?id=159479
Patch by Jeremy Jones <[email protected]> on 2016-07-06
Reviewed by Eric Carlson.
No new tests there is no effect on the DOM. The only effect is to video fullscreen window animation.
When the page has been navigated away, the fullscreen or picture-in-picture window should
not animate back inline in the page, since the page has already navigated to a new page.
Instead exit the fullscreen mode without animating.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::exitFullscreen):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (202871 => 202872)
--- trunk/Source/WebCore/ChangeLog 2016-07-06 20:02:11 UTC (rev 202871)
+++ trunk/Source/WebCore/ChangeLog 2016-07-06 20:03:09 UTC (rev 202872)
@@ -1,5 +1,21 @@
2016-07-06 Jeremy Jones <[email protected]>
+ Do not animate video fullscreen exit when page has navigated away.
+ https://bugs.webkit.org/show_bug.cgi?id=159479
+
+ Reviewed by Eric Carlson.
+
+ No new tests there is no effect on the DOM. The only effect is to video fullscreen window animation.
+
+ When the page has been navigated away, the fullscreen or picture-in-picture window should
+ not animate back inline in the page, since the page has already navigated to a new page.
+ Instead exit the fullscreen mode without animating.
+
+ * html/HTMLMediaElement.cpp:
+ (WebCore::HTMLMediaElement::exitFullscreen):
+
+2016-07-06 Jeremy Jones <[email protected]>
+
Signal that media element is prepared for inline when being stopped since script won't be able to.
https://bugs.webkit.org/show_bug.cgi?id=159163
rdar://problem/26844557
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (202871 => 202872)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2016-07-06 20:02:11 UTC (rev 202871)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2016-07-06 20:03:09 UTC (rev 202872)
@@ -5441,6 +5441,11 @@
if (m_mediaSession->requiresFullscreenForVideoPlayback(*this) && (!document().settings() || !document().settings()->allowsInlineMediaPlaybackAfterFullscreen()))
pauseInternal();
+#if PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE)
+ if (document().activeDOMObjectsAreSuspended() || document().activeDOMObjectsAreStopped())
+ document().page()->chrome().client().exitVideoFullscreenToModeWithoutAnimation(downcast<HTMLVideoElement>(*this), VideoFullscreenModeNone);
+ else
+#endif
if (document().page()->chrome().client().supportsVideoFullscreen(oldVideoFullscreenMode)) {
document().page()->chrome().client().exitVideoFullscreenForVideoElement(downcast<HTMLVideoElement>(*this));
scheduleEvent(eventNames().webkitendfullscreenEvent);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
