Title: [202929] trunk
Revision
202929
Author
[email protected]
Date
2016-07-07 13:53:41 -0700 (Thu, 07 Jul 2016)

Log Message

Unreviewed, rolling out r202905 and r202911.
https://bugs.webkit.org/show_bug.cgi?id=159522

This test is fails on El Capitan and Sierra WK1 (Requested by
ryanhaddad on #webkit).

Reverted changesets:

"Add a test for media control dropoff"
https://bugs.webkit.org/show_bug.cgi?id=151287
http://trac.webkit.org/changeset/202905

"Add a test for media control dropoff"
https://bugs.webkit.org/show_bug.cgi?id=151287
http://trac.webkit.org/changeset/202911

Patch by Commit Queue <[email protected]> on 2016-07-07

Modified Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (202928 => 202929)


--- trunk/LayoutTests/ChangeLog	2016-07-07 20:13:58 UTC (rev 202928)
+++ trunk/LayoutTests/ChangeLog	2016-07-07 20:53:41 UTC (rev 202929)
@@ -1,3 +1,21 @@
+2016-07-07  Commit Queue  <[email protected]>
+
+        Unreviewed, rolling out r202905 and r202911.
+        https://bugs.webkit.org/show_bug.cgi?id=159522
+
+        This test is fails on El Capitan and Sierra WK1 (Requested by
+        ryanhaddad on #webkit).
+
+        Reverted changesets:
+
+        "Add a test for media control dropoff"
+        https://bugs.webkit.org/show_bug.cgi?id=151287
+        http://trac.webkit.org/changeset/202905
+
+        "Add a test for media control dropoff"
+        https://bugs.webkit.org/show_bug.cgi?id=151287
+        http://trac.webkit.org/changeset/202911
+
 2016-07-07  Benjamin Poulain  <[email protected]>
 
         [JSC] Array.prototype.includes uses ToInt32 instead of ToInteger on the index argument

Deleted: trunk/LayoutTests/media/controls/inline-elements-dropoff-order-expected.txt (202928 => 202929)


--- trunk/LayoutTests/media/controls/inline-elements-dropoff-order-expected.txt	2016-07-07 20:13:58 UTC (rev 202928)
+++ trunk/LayoutTests/media/controls/inline-elements-dropoff-order-expected.txt	2016-07-07 20:53:41 UTC (rev 202929)
@@ -1,359 +0,0 @@
-Test control element visibility at different element widths.
-
-This test only runs in DRT!
-
-
-EVENT: error
-PASS: We are using the Apple idiom
-
-*** Test the controls layout without video ***
-
-* Width 60px:
-PASS: Play Button is visible
-PASS: Status Display is visible
-PASS: Rewind Button is not visible
-PASS: Mute Box is not visible
-PASS: AppleTV Device Picker is not visible
-PASS: Picture-in-picture Button is not visible
-PASS: Caption Button is not visible
-PASS: Fullscreen Button is not visible
-PASS: Timeline is not visible
-PASS: Current Time is not visible
-PASS: Thumbnail Track is not visible
-PASS: Time Remaining is not visible
-
-* Width 90px:
-PASS: Play Button is visible
-PASS: Rewind Button is visible
-PASS: Status Display is visible
-PASS: Mute Box is not visible
-PASS: AppleTV Device Picker is not visible
-PASS: Picture-in-picture Button is not visible
-PASS: Caption Button is not visible
-PASS: Fullscreen Button is not visible
-PASS: Timeline is not visible
-PASS: Current Time is not visible
-PASS: Thumbnail Track is not visible
-PASS: Time Remaining is not visible
-
-* Width 200px:
-PASS: Play Button is visible
-PASS: Rewind Button is visible
-PASS: Status Display is visible
-PASS: Mute Box is visible
-PASS: AppleTV Device Picker is not visible
-PASS: Picture-in-picture Button is not visible
-PASS: Caption Button is not visible
-PASS: Fullscreen Button is not visible
-PASS: Timeline is not visible
-PASS: Current Time is not visible
-PASS: Thumbnail Track is not visible
-PASS: Time Remaining is not visible
-
-
-*** Test the controls layout with video ***
-
-EVENT: canplaythrough
-* Width 60px:
-PASS: Play Button is visible
-PASS: Rewind Button is not visible
-PASS: Status Display is not visible
-PASS: Mute Box is not visible
-PASS: AppleTV Device Picker is not visible
-PASS: Picture-in-picture Button is not visible
-PASS: Caption Button is not visible
-PASS: Fullscreen Button is not visible
-PASS: Timeline is not visible
-PASS: Current Time is not visible
-PASS: Thumbnail Track is not visible
-PASS: Time Remaining is not visible
-
-* Width 90px:
-PASS: Play Button is visible
-PASS: Fullscreen Button is visible
-PASS: Rewind Button is not visible
-PASS: Status Display is not visible
-PASS: Mute Box is not visible
-PASS: AppleTV Device Picker is not visible
-PASS: Picture-in-picture Button is not visible
-PASS: Caption Button is not visible
-PASS: Timeline is not visible
-PASS: Current Time is not visible
-PASS: Thumbnail Track is not visible
-PASS: Time Remaining is not visible
-
-* Width 120px:
-PASS: Play Button is visible
-PASS: Rewind Button is visible
-PASS: Fullscreen Button is visible
-PASS: Status Display is not visible
-PASS: Mute Box is not visible
-PASS: AppleTV Device Picker is not visible
-PASS: Picture-in-picture Button is not visible
-PASS: Caption Button is not visible
-PASS: Timeline is not visible
-PASS: Current Time is not visible
-PASS: Thumbnail Track is not visible
-PASS: Time Remaining is not visible
-
-* Width 150px:
-PASS: Play Button is visible
-PASS: Rewind Button is visible
-PASS: Mute Box is visible
-PASS: Fullscreen Button is visible
-PASS: Status Display is not visible
-PASS: AppleTV Device Picker is not visible
-PASS: Picture-in-picture Button is not visible
-PASS: Caption Button is not visible
-PASS: Timeline is not visible
-PASS: Current Time is not visible
-PASS: Thumbnail Track is not visible
-PASS: Time Remaining is not visible
-
-* Width 200px:
-PASS: Play Button is visible
-PASS: Rewind Button is visible
-PASS: Mute Box is visible
-PASS: Picture-in-picture Button is visible
-PASS: Fullscreen Button is visible
-PASS: Status Display is not visible
-PASS: AppleTV Device Picker is not visible
-PASS: Caption Button is not visible
-PASS: Timeline is not visible
-PASS: Current Time is not visible
-PASS: Thumbnail Track is not visible
-PASS: Time Remaining is not visible
-
-* Width 400px:
-PASS: Play Button is visible
-PASS: Rewind Button is visible
-PASS: Timeline is visible
-PASS: Current Time is visible
-PASS: Thumbnail Track is visible
-PASS: Time Remaining is visible
-PASS: Mute Box is visible
-PASS: Picture-in-picture Button is visible
-PASS: Fullscreen Button is visible
-PASS: Status Display is not visible
-PASS: AppleTV Device Picker is not visible
-PASS: Caption Button is not visible
-
-
-*** Test the controls layout with video and a caption track ***
-
-* Width 60px:
-PASS: Play Button is visible
-PASS: Rewind Button is not visible
-PASS: Status Display is not visible
-PASS: Mute Box is not visible
-PASS: AppleTV Device Picker is not visible
-PASS: Picture-in-picture Button is not visible
-PASS: Caption Button is not visible
-PASS: Fullscreen Button is not visible
-PASS: Timeline is not visible
-PASS: Current Time is not visible
-PASS: Thumbnail Track is not visible
-PASS: Time Remaining is not visible
-
-* Width 90px:
-PASS: Play Button is visible
-PASS: Fullscreen Button is visible
-PASS: Rewind Button is not visible
-PASS: Status Display is not visible
-PASS: Mute Box is not visible
-PASS: AppleTV Device Picker is not visible
-PASS: Picture-in-picture Button is not visible
-PASS: Caption Button is not visible
-PASS: Timeline is not visible
-PASS: Current Time is not visible
-PASS: Thumbnail Track is not visible
-PASS: Time Remaining is not visible
-
-* Width 120px:
-PASS: Play Button is visible
-PASS: Rewind Button is visible
-PASS: Fullscreen Button is visible
-PASS: Status Display is not visible
-PASS: Mute Box is not visible
-PASS: AppleTV Device Picker is not visible
-PASS: Picture-in-picture Button is not visible
-PASS: Caption Button is not visible
-PASS: Timeline is not visible
-PASS: Current Time is not visible
-PASS: Thumbnail Track is not visible
-PASS: Time Remaining is not visible
-
-* Width 150px:
-PASS: Play Button is visible
-PASS: Rewind Button is visible
-PASS: Mute Box is visible
-PASS: Fullscreen Button is visible
-PASS: Status Display is not visible
-PASS: AppleTV Device Picker is not visible
-PASS: Picture-in-picture Button is not visible
-PASS: Caption Button is not visible
-PASS: Timeline is not visible
-PASS: Current Time is not visible
-PASS: Thumbnail Track is not visible
-PASS: Time Remaining is not visible
-
-* Width 180px:
-PASS: Play Button is visible
-PASS: Rewind Button is visible
-PASS: Mute Box is visible
-PASS: Caption Button is visible
-PASS: Fullscreen Button is visible
-PASS: Status Display is not visible
-PASS: AppleTV Device Picker is not visible
-PASS: Picture-in-picture Button is not visible
-PASS: Timeline is not visible
-PASS: Current Time is not visible
-PASS: Thumbnail Track is not visible
-PASS: Time Remaining is not visible
-
-* Width 200px:
-PASS: Play Button is visible
-PASS: Rewind Button is visible
-PASS: Mute Box is visible
-PASS: Caption Button is visible
-PASS: Picture-in-picture Button is visible
-PASS: Fullscreen Button is visible
-PASS: Status Display is not visible
-PASS: AppleTV Device Picker is not visible
-PASS: Timeline is not visible
-PASS: Current Time is not visible
-PASS: Thumbnail Track is not visible
-PASS: Time Remaining is not visible
-
-* Width 400px:
-PASS: Play Button is visible
-PASS: Rewind Button is visible
-PASS: Current Time is visible
-PASS: Timeline is visible
-PASS: Thumbnail Track is visible
-PASS: Time Remaining is visible
-PASS: Mute Box is visible
-PASS: Caption Button is visible
-PASS: Picture-in-picture Button is visible
-PASS: Fullscreen Button is visible
-PASS: Status Display is not visible
-PASS: AppleTV Device Picker is not visible
-
-
-*** Test the controls layout with video, a caption track, and AppleTV ***
-
-* Width 60px:
-PASS: Play Button is visible
-PASS: Rewind Button is not visible
-PASS: Status Display is not visible
-PASS: Mute Box is not visible
-PASS: AppleTV Device Picker is not visible
-PASS: Picture-in-picture Button is not visible
-PASS: Caption Button is not visible
-PASS: Fullscreen Button is not visible
-PASS: Timeline is not visible
-PASS: Current Time is not visible
-PASS: Thumbnail Track is not visible
-PASS: Time Remaining is not visible
-
-* Width 90px:
-PASS: Play Button is visible
-PASS: Fullscreen Button is visible
-PASS: Rewind Button is not visible
-PASS: Status Display is not visible
-PASS: Mute Box is not visible
-PASS: AppleTV Device Picker is not visible
-PASS: Picture-in-picture Button is not visible
-PASS: Caption Button is not visible
-PASS: Timeline is not visible
-PASS: Current Time is not visible
-PASS: Thumbnail Track is not visible
-PASS: Time Remaining is not visible
-
-* Width 120px:
-PASS: Play Button is visible
-PASS: Rewind Button is visible
-PASS: Fullscreen Button is visible
-PASS: Status Display is not visible
-PASS: Mute Box is not visible
-PASS: AppleTV Device Picker is not visible
-PASS: Picture-in-picture Button is not visible
-PASS: Caption Button is not visible
-PASS: Timeline is not visible
-PASS: Current Time is not visible
-PASS: Thumbnail Track is not visible
-PASS: Time Remaining is not visible
-
-* Width 150px:
-PASS: Play Button is visible
-PASS: Rewind Button is visible
-PASS: Mute Box is visible
-PASS: Fullscreen Button is visible
-PASS: Status Display is not visible
-PASS: AppleTV Device Picker is not visible
-PASS: Picture-in-picture Button is not visible
-PASS: Caption Button is not visible
-PASS: Timeline is not visible
-PASS: Current Time is not visible
-PASS: Thumbnail Track is not visible
-PASS: Time Remaining is not visible
-
-* Width 180px:
-PASS: Play Button is visible
-PASS: Rewind Button is visible
-PASS: Mute Box is visible
-PASS: Caption Button is visible
-PASS: Fullscreen Button is visible
-PASS: Status Display is not visible
-PASS: AppleTV Device Picker is not visible
-PASS: Picture-in-picture Button is not visible
-PASS: Timeline is not visible
-PASS: Current Time is not visible
-PASS: Thumbnail Track is not visible
-PASS: Time Remaining is not visible
-
-* Width 200px:
-PASS: Play Button is visible
-PASS: Rewind Button is visible
-PASS: Mute Box is visible
-PASS: Caption Button is visible
-PASS: Picture-in-picture Button is visible
-PASS: Fullscreen Button is visible
-PASS: Status Display is not visible
-PASS: AppleTV Device Picker is not visible
-PASS: Timeline is not visible
-PASS: Current Time is not visible
-PASS: Thumbnail Track is not visible
-PASS: Time Remaining is not visible
-
-* Width 350px:
-PASS: Play Button is visible
-PASS: Rewind Button is visible
-PASS: Mute Box is visible
-PASS: AppleTV Device Picker is visible
-PASS: Caption Button is visible
-PASS: Picture-in-picture Button is visible
-PASS: Fullscreen Button is visible
-PASS: Status Display is not visible
-PASS: Timeline is not visible
-PASS: Current Time is not visible
-PASS: Thumbnail Track is not visible
-PASS: Time Remaining is not visible
-
-* Width 400px:
-PASS: Play Button is visible
-PASS: Rewind Button is visible
-PASS: Current Time is visible
-PASS: Timeline is visible
-PASS: Thumbnail Track is visible
-PASS: Time Remaining is visible
-PASS: Mute Box is visible
-PASS: AppleTV Device Picker is visible
-PASS: Caption Button is visible
-PASS: Picture-in-picture Button is visible
-PASS: Fullscreen Button is visible
-PASS: Status Display is not visible
-
-
-Testing finished.
-

Deleted: trunk/LayoutTests/media/controls/inline-elements-dropoff-order.html (202928 => 202929)


--- trunk/LayoutTests/media/controls/inline-elements-dropoff-order.html	2016-07-07 20:13:58 UTC (rev 202928)
+++ trunk/LayoutTests/media/controls/inline-elements-dropoff-order.html	2016-07-07 20:53:41 UTC (rev 202929)
@@ -1,160 +0,0 @@
-<!DOCTYPE html>
-<html>
-    <head>
-        <script src=""
-        <script src=""
-        <script>
-
-            const allButtons = [
-                "Play Button", "Rewind Button", "Status Display", "Mute Box", "AppleTV Device Picker", 
-                "Picture-in-picture Button", "Caption Button", "Fullscreen Button", "Timeline", 
-                "Current Time", "Thumbnail Track", "Time Remaining"
-            ];
-            const tester = new ControlsTest("non-existent-media-file", "error")
-                .whenReady(setup)
-                .start();
-
-            function setup()
-            {
-                internals.settings.setAllowsPictureInPictureMediaPlayback(true);
-
-                tester.test("We are using the Apple idiom")
-                    .value(tester.currentState.idiom)
-                    .isEqualTo("apple");
-                tester.startNewSection("*** Test the controls layout without video ***");
-                runTestsWithoutVideo();
-            }
-
-            function testControls(data, nextTest)
-            {
-                if (!data.length) {
-                    if (typeof nextTest === "function")
-                        nextTest();
-                    else
-                        tester.end();
-                    return;
-                }
-                
-                const test = data.shift();
-                
-                if (typeof tester.media.webkitSupportsPresentationMode !== "function" || !tester.media.webkitSupportsPresentationMode('picture-in-picture'))
-                    test.visible = test.visible.filter(name => name.indexOf("Picture-in-picture Button") === -1);
-                if (!internals.setMockMediaPlaybackTargetPickerState)
-                    test.visible = test.visible.filter(name => name.indexOf("AppleTV Device Picker") === -1);
-
-                tester.media.style.width = test.width + "px";
-                window.setTimeout( () => {
-                    tester.logMessage(`* Width ${tester.media.style.width}:`);
-
-                    const isVisible = (state, name) => { 
-                        if (state === null || typeof state.className !== "string")
-                            return false;
-                        return state.className.indexOf("dropped") === -1 && state.className.indexOf("hidden") === -1;
-                    }
-
-                    test.visible.forEach(name => {
-                        const state = tester.stateForControlsElement(name, true);
-                        tester.test(`${name} is visible`)
-                            .value(isVisible(state))
-                            .isTrue();
-                    });
-
-                    allButtons.filter(name => test.visible.indexOf(name) === -1).forEach(name => {
-                        const state = tester.stateForControlsElement(name, true);
-                        tester.test(`${name} is not visible`)
-                            .value(isVisible(state))
-                            .isFalse();
-                    });
-
-                    tester.logBlankLine();
-                    testControls(data, nextTest);
-                }, 100);
-            }
-
-            function runTestsWithoutVideo()
-            {
-                const setupNextTest = () => {
-                    tester.resetEventTrigger("canplaythrough")
-                        .whenReady(runTestsWithVideo)
-                        .media.src = "" "../content/test");
-                    tester.startNewSection("*** Test the controls layout with video ***");
-                };
-
-                const data = [
-                    { width: 60, visible : ["Play Button", "Status Display"] },
-                    { width: 90, visible : ["Play Button", "Rewind Button", "Status Display"] },
-                    { width: 200, visible : ["Play Button", "Rewind Button", "Status Display", "Mute Box"] },
-                ];
-                testControls(data, setupNextTest);
-            }
-
-            function runTestsWithVideo()
-            {
-                const setupNextTest = () => {
-                    tester.startNewSection("*** Test the controls layout with video and a caption track ***")
-                    const track = document.createElement("track");
-                    track.kind = "captions";
-                    track.src = "" --> 00:00:01.000\nCaption 1\n")}`;
-                    tester.media.appendChild(track);
-                    
-                    runTestsWithTextTrack();
-                };
-
-                const data = [
-                    { width: 60,  visible : ["Play Button"] },
-                    { width: 90,  visible : ["Play Button", "Fullscreen Button"] },
-                    { width: 120, visible : ["Play Button", "Rewind Button", "Fullscreen Button"] },
-                    { width: 150, visible : ["Play Button", "Rewind Button", "Mute Box", "Fullscreen Button"] },
-                    { width: 200, visible : ["Play Button", "Rewind Button", "Mute Box", "Picture-in-picture Button", "Fullscreen Button"] },
-                    { width: 400, visible : ["Play Button", "Rewind Button", "Timeline", "Current Time", "Thumbnail Track", "Time Remaining", "Mute Box", "Picture-in-picture Button", "Fullscreen Button"] },
-                ];
-
-                testControls(data, setupNextTest);
-            }
-
-            function runTestsWithTextTrack()
-            {
-                const setupNextTest = () => {
-                    tester.startNewSection("*** Test the controls layout with video, a caption track, and AppleTV ***");
-                    internals.setMockMediaPlaybackTargetPickerState("Sleepy TV", "DeviceAvailable");
-                    runTestsWithVideoAndAppleTV();
-                };
-
-                const data = [
-                    { width: 60,  visible : ["Play Button"] },
-                    { width: 90,  visible : ["Play Button", "Fullscreen Button"] },
-                    { width: 120, visible : ["Play Button", "Rewind Button", "Fullscreen Button"] },
-                    { width: 150, visible : ["Play Button", "Rewind Button", "Mute Box", "Fullscreen Button"] },
-                    { width: 180, visible : ["Play Button", "Rewind Button", "Mute Box", "Caption Button", "Fullscreen Button"] },
-                    { width: 200, visible : ["Play Button", "Rewind Button", "Mute Box", "Caption Button", "Picture-in-picture Button", "Fullscreen Button"] },
-                    { width: 400, visible : ["Play Button", "Rewind Button", "Current Time", "Timeline", "Thumbnail Track", "Time Remaining", "Mute Box", "Caption Button", "Picture-in-picture Button", "Fullscreen Button"] },
-                ];
-                
-                testControls(data, internals.setMockMediaPlaybackTargetPickerState ? setupNextTest : null);
-            }
-
-            function runTestsWithVideoAndAppleTV()
-            {
-                const data = [
-                    { width: 60,  visible : ["Play Button"] },
-                    { width: 90,  visible : ["Play Button", "Fullscreen Button"] },
-                    { width: 120, visible : ["Play Button", "Rewind Button", "Fullscreen Button"] },
-                    { width: 150, visible : ["Play Button", "Rewind Button", "Mute Box", "Fullscreen Button"] },
-                    { width: 180, visible : ["Play Button", "Rewind Button", "Mute Box", "Caption Button", "Fullscreen Button"] },
-                    { width: 200, visible : ["Play Button", "Rewind Button", "Mute Box", "Caption Button", "Picture-in-picture Button", "Fullscreen Button"] },
-                    { width: 350, visible : ["Play Button", "Rewind Button", "Mute Box", "AppleTV Device Picker", "Caption Button", "Picture-in-picture Button", "Fullscreen Button"] },
-                    { width: 400, visible : ["Play Button", "Rewind Button", "Current Time", "Timeline", "Thumbnail Track", "Time Remaining", "Mute Box", "AppleTV Device Picker", "Caption Button", "Picture-in-picture Button", "Fullscreen Button"] },
-                ];
-
-                testControls(data);
-            }
-
-
-        </script>
-    </head>
-    <body>
-        <p>Test control element visibility at different element widths.</p>
-        <p>This test only runs in DRT!</p>
-        <video controls></video>
-    </body>
-</html>

Modified: trunk/Source/WebCore/ChangeLog (202928 => 202929)


--- trunk/Source/WebCore/ChangeLog	2016-07-07 20:13:58 UTC (rev 202928)
+++ trunk/Source/WebCore/ChangeLog	2016-07-07 20:53:41 UTC (rev 202929)
@@ -1,3 +1,21 @@
+2016-07-07  Commit Queue  <[email protected]>
+
+        Unreviewed, rolling out r202905 and r202911.
+        https://bugs.webkit.org/show_bug.cgi?id=159522
+
+        This test is fails on El Capitan and Sierra WK1 (Requested by
+        ryanhaddad on #webkit).
+
+        Reverted changesets:
+
+        "Add a test for media control dropoff"
+        https://bugs.webkit.org/show_bug.cgi?id=151287
+        http://trac.webkit.org/changeset/202905
+
+        "Add a test for media control dropoff"
+        https://bugs.webkit.org/show_bug.cgi?id=151287
+        http://trac.webkit.org/changeset/202911
+
 2016-07-07  Antoine Quint  <[email protected]>
 
         <img> with a wide gamut PDF does not display using a wide gamut color space

Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js (202928 => 202929)


--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js	2016-07-07 20:13:58 UTC (rev 202928)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js	2016-07-07 20:53:41 UTC (rev 202929)
@@ -2288,37 +2288,33 @@
             {
                 name: "Show Controls",
                 object: this.showControlsButton,
-                extraProperties: ["hidden"],
+                extraProperties: ["hidden"]
             },
             {
                 name: "Status Display",
                 object: this.controls.statusDisplay,
                 styleValues: ["display"],
-                extraProperties: ["textContent"],
+                extraProperties: ["textContent"]
             },
             {
                 name: "Play Button",
-                object: this.controls.playButton,
-                extraProperties: ["hidden"],
+                object: this.controls.playButton
             },
             {
                 name: "Rewind Button",
-                object: this.controls.rewindButton,
-                extraProperties: ["hidden"],
+                object: this.controls.rewindButton
             },
             {
                 name: "Timeline Box",
-                object: this.controls.timelineBox,
+                object: this.controls.timelineBox
             },
             {
                 name: "Mute Box",
-                object: this.controls.muteBox,
-                extraProperties: ["hidden"],
+                object: this.controls.muteBox
             },
             {
                 name: "Fullscreen Button",
-                object: this.controls.fullscreenButton,
-                extraProperties: ["hidden"],
+                object: this.controls.fullscreenButton
             },
             {
                 name: "AppleTV Device Picker",
@@ -2330,36 +2326,10 @@
                 name: "Picture-in-picture Button",
                 object: this.controls.pictureInPictureButton,
                 extraProperties: ["parentElement"],
-                extraProperties: ["hidden"],
             },
             {
-                name: "Caption Button",
-                object: this.controls.captionButton,
-                extraProperties: ["hidden"],
-            },
-            {
-                name: "Timeline",
-                object: this.controls.timeline,
-                extraProperties: ["hidden"],
-            },
-            {
-                name: "Current Time",
-                object: this.controls.currentTime,
-                extraProperties: ["hidden"],
-            },
-            {
-                name: "Thumbnail Track",
-                object: this.controls.thumbnailTrack,
-                extraProperties: ["hidden"],
-            },
-            {
-                name: "Time Remaining",
-                object: this.controls.remainingTime,
-                extraProperties: ["hidden"],
-            },
-            {
                 name: "Track Menu",
-                object: this.captionMenu,
+                object: this.captionMenu
             },
             {
                 name: "Inline playback placeholder",
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to