Title: [202957] trunk
- Revision
- 202957
- Author
- [email protected]
- Date
- 2016-07-07 22:12:14 -0700 (Thu, 07 Jul 2016)
Log Message
API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
https://bugs.webkit.org/show_bug.cgi?id=159532
-and corresponding-
rdar://problem/27177179
Reviewed by Tim Horton.
Source/WebKit/mac:
* WebView/WebView.mm:
(-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
(-[WebView forceRequestCandidatesForTesting]):
(-[WebView shouldRequestCandidates]):
* WebView/WebViewPrivate.h:
Tools:
* TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
(-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (202956 => 202957)
--- trunk/Source/WebKit/mac/ChangeLog 2016-07-08 04:10:00 UTC (rev 202956)
+++ trunk/Source/WebKit/mac/ChangeLog 2016-07-08 05:12:14 UTC (rev 202957)
@@ -1,3 +1,18 @@
+2016-07-07 Beth Dakin <[email protected]>
+
+ API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
+ https://bugs.webkit.org/show_bug.cgi?id=159532
+ -and corresponding-
+ rdar://problem/27177179
+
+ Reviewed by Tim Horton.
+
+ * WebView/WebView.mm:
+ (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
+ (-[WebView forceRequestCandidatesForTesting]):
+ (-[WebView shouldRequestCandidates]):
+ * WebView/WebViewPrivate.h:
+
2016-07-07 Andy Estes <[email protected]>
[Content Filtering] Load blocked pages more like other error pages are loaded
Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (202956 => 202957)
--- trunk/Source/WebKit/mac/WebView/WebView.mm 2016-07-08 04:10:00 UTC (rev 202956)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2016-07-08 05:12:14 UTC (rev 202957)
@@ -6723,6 +6723,10 @@
{
}
+- (void)forceRequestCandidatesForTesting
+{
+}
+
- (BOOL)shouldRequestCandidates
{
return NO;
Modified: trunk/Source/WebKit/mac/WebView/WebViewPrivate.h (202956 => 202957)
--- trunk/Source/WebKit/mac/WebView/WebViewPrivate.h 2016-07-08 04:10:00 UTC (rev 202956)
+++ trunk/Source/WebKit/mac/WebView/WebViewPrivate.h 2016-07-08 05:12:14 UTC (rev 202957)
@@ -1069,6 +1069,7 @@
@interface WebView (WebShowCandidates)
- (void)showCandidates:(NSArray *)candidates forString:(NSString *)string inRect:(NSRect)rectOfTypedString forSelectedRange:(NSRange)range view:(NSView *)view completionHandler:(void (^)(NSTextCheckingResult *acceptedCandidate))completionBlock;
+- (void)forceRequestCandidatesForTesting;
@end
#ifdef __cplusplus
Modified: trunk/Tools/ChangeLog (202956 => 202957)
--- trunk/Tools/ChangeLog 2016-07-08 04:10:00 UTC (rev 202956)
+++ trunk/Tools/ChangeLog 2016-07-08 05:12:14 UTC (rev 202957)
@@ -1,3 +1,15 @@
+2016-07-07 Beth Dakin <[email protected]>
+
+ API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
+ https://bugs.webkit.org/show_bug.cgi?id=159532
+ -and corresponding-
+ rdar://problem/27177179
+
+ Reviewed by Tim Horton.
+
+ * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
+ (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
+
2016-07-07 Andy Estes <[email protected]>
[Content Filtering] Load blocked pages more like other error pages are loaded
Modified: trunk/Tools/TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm (202956 => 202957)
--- trunk/Tools/TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm 2016-07-08 04:10:00 UTC (rev 202956)
+++ trunk/Tools/TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm 2016-07-08 05:12:14 UTC (rev 202957)
@@ -62,6 +62,7 @@
- (void)webView:(WebView *)sender didFinishLoadForFrame:(WebFrame *)frame
{
+ [sender forceRequestCandidatesForTesting];
didFinishLoad = true;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
