Title: [202976] trunk
Revision
202976
Author
[email protected]
Date
2016-07-08 05:22:31 -0700 (Fri, 08 Jul 2016)

Log Message

Unreviewed, rolling out r202967.
https://bugs.webkit.org/show_bug.cgi?id=159556

This patch caused crashes in https tests on Windows (Requested
by perarne on #webkit).

Reverted changeset:

"[Win] The test http/tests/security/contentSecurityPolicy
/upgrade-insecure-requests/basic-upgrade.https.html is
failing."
https://bugs.webkit.org/show_bug.cgi?id=159510
http://trac.webkit.org/changeset/202967

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (202975 => 202976)


--- trunk/Source/WebCore/ChangeLog	2016-07-08 10:42:25 UTC (rev 202975)
+++ trunk/Source/WebCore/ChangeLog	2016-07-08 12:22:31 UTC (rev 202976)
@@ -1,3 +1,19 @@
+2016-07-08  Commit Queue  <[email protected]>
+
+        Unreviewed, rolling out r202967.
+        https://bugs.webkit.org/show_bug.cgi?id=159556
+
+        This patch caused crashes in https tests on Windows (Requested
+        by perarne on #webkit).
+
+        Reverted changeset:
+
+        "[Win] The test http/tests/security/contentSecurityPolicy
+        /upgrade-insecure-requests/basic-upgrade.https.html is
+        failing."
+        https://bugs.webkit.org/show_bug.cgi?id=159510
+        http://trac.webkit.org/changeset/202967
+
 2016-07-08  Youenn Fablet  <[email protected]>
 
         Generate WebCore builtin wrapper files

Modified: trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp (202975 => 202976)


--- trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp	2016-07-08 10:42:25 UTC (rev 202975)
+++ trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp	2016-07-08 12:22:31 UTC (rev 202976)
@@ -173,9 +173,7 @@
         CFDictionaryAddValue(sslProps.get(), kCFStreamSSLAllowsAnyRoot, kCFBooleanTrue);
         CFDictionaryAddValue(sslProps.get(), kCFStreamSSLAllowsExpiredRoots, kCFBooleanTrue);
         CFDictionaryAddValue(sslProps.get(), kCFStreamSSLAllowsExpiredCertificates, kCFBooleanTrue);
-#if !PLATFORM(WIN) // Remove platform #ifdef when <rdar://problem/26768077> is fixed.
         CFDictionaryAddValue(sslProps.get(), kCFStreamSSLValidatesCertificateChain, kCFBooleanFalse);
-#endif
     }
 
     auto clientCert = clientCertificates().find(firstRequest().url().host());

Modified: trunk/Tools/ChangeLog (202975 => 202976)


--- trunk/Tools/ChangeLog	2016-07-08 10:42:25 UTC (rev 202975)
+++ trunk/Tools/ChangeLog	2016-07-08 12:22:31 UTC (rev 202976)
@@ -1,3 +1,19 @@
+2016-07-08  Commit Queue  <[email protected]>
+
+        Unreviewed, rolling out r202967.
+        https://bugs.webkit.org/show_bug.cgi?id=159556
+
+        This patch caused crashes in https tests on Windows (Requested
+        by perarne on #webkit).
+
+        Reverted changeset:
+
+        "[Win] The test http/tests/security/contentSecurityPolicy
+        /upgrade-insecure-requests/basic-upgrade.https.html is
+        failing."
+        https://bugs.webkit.org/show_bug.cgi?id=159510
+        http://trac.webkit.org/changeset/202967
+
 2016-07-08  Youenn Fablet  <[email protected]>
 
         Generate WebCore builtin wrapper files

Modified: trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp (202975 => 202976)


--- trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp	2016-07-08 10:42:25 UTC (rev 202975)
+++ trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp	2016-07-08 12:22:31 UTC (rev 202976)
@@ -1138,7 +1138,6 @@
 
     request->initWithURL(urlBStr, WebURLRequestUseProtocolCachePolicy, 60);
     request->setHTTPMethod(methodBStr);
-    request->setAllowsAnyHTTPSCertificate();
     frame->loadRequest(request.get());
 
     while (true) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to