Title: [202997] trunk/Source/_javascript_Core
Revision
202997
Author
[email protected]
Date
2016-07-08 11:48:25 -0700 (Fri, 08 Jul 2016)

Log Message

speculateTypedArrayIsNotNeutered has an inverted speculation
https://bugs.webkit.org/show_bug.cgi?id=159571

Reviewed by Mark Lam.

For some confusing reason FTLLowerDFGToB3 takes the condition the
speculation wants to be false. This issue caused
typedarray-access-monomorphic-neutered.js to fail on the bots.

* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::speculateTypedArrayIsNotNeutered):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (202996 => 202997)


--- trunk/Source/_javascript_Core/ChangeLog	2016-07-08 18:34:39 UTC (rev 202996)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-07-08 18:48:25 UTC (rev 202997)
@@ -1,3 +1,17 @@
+2016-07-08  Keith Miller  <[email protected]>
+
+        speculateTypedArrayIsNotNeutered has an inverted speculation
+        https://bugs.webkit.org/show_bug.cgi?id=159571
+
+        Reviewed by Mark Lam.
+
+        For some confusing reason FTLLowerDFGToB3 takes the condition the
+        speculation wants to be false. This issue caused
+        typedarray-access-monomorphic-neutered.js to fail on the bots.
+
+        * ftl/FTLLowerDFGToB3.cpp:
+        (JSC::FTL::DFG::LowerDFGToB3::speculateTypedArrayIsNotNeutered):
+
 2016-07-08  Mark Lam  <[email protected]>
 
         Rename jsCPUStackLimit to osStackLimitWithReserve and jsEmulatedStackLimit to cloopStackLimit.

Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp (202996 => 202997)


--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp	2016-07-08 18:34:39 UTC (rev 202996)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp	2016-07-08 18:48:25 UTC (rev 202997)
@@ -10604,7 +10604,7 @@
 
         LBasicBlock lastNext = m_out.appendTo(isWasteful, continuation);
         LValue vector = m_out.loadPtr(base, m_heaps.JSArrayBufferView_vector);
-        speculate(Uncountable, jsValueValue(vector), m_node, m_out.notZero64(vector));
+        speculate(Uncountable, jsValueValue(vector), m_node, m_out.isZero64(vector));
         m_out.jump(continuation);
 
         m_out.appendTo(continuation, lastNext);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to