Title: [203005] trunk/Source/WebCore
Revision
203005
Author
[email protected]
Date
2016-07-08 14:06:33 -0700 (Fri, 08 Jul 2016)

Log Message

Prevent fullscreen video dimension state from being reset after configuring.
https://bugs.webkit.org/show_bug.cgi?id=159578

Patch by Jeremy Jones <[email protected]> on 2016-07-08
Reviewed by Jer Noble.

This change moves setVideoElement() to after setMediaElement(), since setMediaElement() resets the
mediaState, undoing the configuration done by setVideoElement().

This change is fragile, but minimal. The proper, more comprehinsive fix will come later from
https://bugs.webkit.org/show_bug.cgi?id=159580.

* platform/ios/WebVideoFullscreenControllerAVKit.mm:
(WebVideoFullscreenControllerContext::setUpFullscreen):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (203004 => 203005)


--- trunk/Source/WebCore/ChangeLog	2016-07-08 20:52:15 UTC (rev 203004)
+++ trunk/Source/WebCore/ChangeLog	2016-07-08 21:06:33 UTC (rev 203005)
@@ -1,3 +1,19 @@
+2016-07-08  Jeremy Jones  <[email protected]>
+
+        Prevent fullscreen video dimension state from being reset after configuring.
+        https://bugs.webkit.org/show_bug.cgi?id=159578
+
+        Reviewed by Jer Noble.
+
+        This change moves setVideoElement() to after setMediaElement(), since setMediaElement() resets the
+        mediaState, undoing the configuration done by setVideoElement().
+
+        This change is fragile, but minimal. The proper, more comprehinsive fix will come later from
+        https://bugs.webkit.org/show_bug.cgi?id=159580.
+
+        * platform/ios/WebVideoFullscreenControllerAVKit.mm:
+        (WebVideoFullscreenControllerContext::setUpFullscreen):
+
 2016-07-08  Andy Estes  <[email protected]>
 
         [Content Filtering] Load blocked pages more like other error pages are loaded

Modified: trunk/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm (203004 => 203005)


--- trunk/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm	2016-07-08 20:52:15 UTC (rev 203004)
+++ trunk/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm	2016-07-08 21:06:33 UTC (rev 203005)
@@ -661,8 +661,8 @@
         WebThreadRun([protectedThis, this, viewRef, mode] {
             m_model = WebVideoFullscreenModelVideoElement::create(WebPlaybackSessionModelMediaElement::create().get());
             m_model->setWebVideoFullscreenInterface(this);
+            m_model->playbackSessionModel().setMediaElement(m_videoElement.get());
             m_model->setVideoElement(m_videoElement.get());
-            m_model->playbackSessionModel().setMediaElement(m_videoElement.get());
 
             IntRect videoElementClientRect = elementRectInWindow(m_videoElement.get());
             FloatRect videoLayerFrame = FloatRect(FloatPoint(), videoElementClientRect.size());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to