Title: [203009] trunk
Revision
203009
Author
[email protected]
Date
2016-07-08 17:04:32 -0700 (Fri, 08 Jul 2016)

Log Message

Setting table.tFoot or calling table.createTFoot() should append HTML tfont element to the end of the table
https://bugs.webkit.org/show_bug.cgi?id=159583
<rdar://problem/27255292>

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Update expected result now that we append the HTML tfoot element to the end of the table.

* web-platform-tests/html/semantics/tabular-data/the-table-element/tFoot-expected.txt:

Source/WebCore:

he HTML standard has long since been revised to describe that assignment to property table.tFoot
or invoking table.createTFoot() will append the HTML tfoot element to the end of the table. This
behavior is defined in <https://html.spec.whatwg.org/multipage/tables.html#dom-table-tfoot> (8 July 2016)
and <https://html.spec.whatwg.org/multipage/tables.html#dom-table-createtfoot> for the property
table.tFoot and table.createTFoot(), respectively. This change makes our behavior match the
behavior in Mozilla Firefox, Microsoft Edge, Microsoft Internet Explorer 8 and later.

* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::setTFoot): Append <tfoot> to the end of the table. Use RefPtr<>&& instead of PassRefPtr.
(WebCore::HTMLTableElement::createTFoot): Use RefPtr<>&& instead of PassRefPtr.
* html/HTMLTableElement.h:

LayoutTests:

Update expected results now that we append the HTML tfoot element to the end of the table.

* platform/efl/tables/mozilla/bugs/bug30418-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug30418-expected.txt:
* platform/ios-simulator/tables/mozilla/bugs/bug30418-expected.txt:
* platform/mac/tables/mozilla/bugs/bug30418-expected.txt:
* platform/win/tables/mozilla/bugs/bug30418-expected.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (203008 => 203009)


--- trunk/LayoutTests/ChangeLog	2016-07-08 23:49:15 UTC (rev 203008)
+++ trunk/LayoutTests/ChangeLog	2016-07-09 00:04:32 UTC (rev 203009)
@@ -1,3 +1,19 @@
+2016-07-08  Daniel Bates  <[email protected]>
+
+        Setting table.tFoot or calling table.createTFoot() should append HTML tfont element to the end of the table
+        https://bugs.webkit.org/show_bug.cgi?id=159583
+        <rdar://problem/27255292>
+
+        Reviewed by Chris Dumez.
+
+        Update expected results now that we append the HTML tfoot element to the end of the table.
+
+        * platform/efl/tables/mozilla/bugs/bug30418-expected.txt:
+        * platform/gtk/tables/mozilla/bugs/bug30418-expected.txt:
+        * platform/ios-simulator/tables/mozilla/bugs/bug30418-expected.txt:
+        * platform/mac/tables/mozilla/bugs/bug30418-expected.txt:
+        * platform/win/tables/mozilla/bugs/bug30418-expected.txt:
+
 2016-07-08  Chris Dumez  <[email protected]>
 
         Object.defineProperty() should maintain existing getter / setter if not overridden in the new descriptor

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (203008 => 203009)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-07-08 23:49:15 UTC (rev 203008)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-07-09 00:04:32 UTC (rev 203009)
@@ -1,3 +1,15 @@
+2016-07-08  Daniel Bates  <[email protected]>
+
+        Setting table.tFoot or calling table.createTFoot() should append HTML tfont element to the end of the table
+        https://bugs.webkit.org/show_bug.cgi?id=159583
+        <rdar://problem/27255292>
+
+        Reviewed by Chris Dumez.
+
+        Update expected result now that we append the HTML tfoot element to the end of the table.
+
+        * web-platform-tests/html/semantics/tabular-data/the-table-element/tFoot-expected.txt:
+
 2016-07-07  Chris Dumez  <[email protected]>
 
         tdody.deleteRow(-1) and tr.deleteCell(-1) should not throw when there are no rows / cells

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-table-element/tFoot-expected.txt (203008 => 203009)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-table-element/tFoot-expected.txt	2016-07-08 23:49:15 UTC (rev 203008)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/the-table-element/tFoot-expected.txt	2016-07-09 00:04:32 UTC (rev 203009)
@@ -1,3 +1,3 @@
 
-FAIL tFoot tests assert_equals: expected Element node <tbody id="tbody2"></tbody> but got Element node <thead id="thead"></thead>
+PASS tFoot tests 
 

Modified: trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug30418-expected.txt (203008 => 203009)


--- trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug30418-expected.txt	2016-07-08 23:49:15 UTC (rev 203008)
+++ trunk/LayoutTests/platform/efl/tables/mozilla/bugs/bug30418-expected.txt	2016-07-09 00:04:32 UTC (rev 203009)
@@ -30,6 +30,32 @@
             RenderTableCell {TD} at (240,2) size 32x22 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
               RenderText {#text} at (2,2) size 16x17
                 text run at (2,2) width 16: "h7"
+        RenderTableSection {TBODY} at (4,30) size 274x24
+          RenderTableRow {TR} at (0,0) size 274x22
+            RenderTableCell {TD} at (2,0) size 32x22 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 28x17
+                text run at (2,2) width 28: "r0c0"
+            RenderTableCell {TD} at (36,0) size 32x22 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 28x17
+                text run at (2,2) width 28: "r0c1"
+            RenderTableCell {TD} at (70,0) size 32x22 [border: (1px inset #808080)] [r=0 c=2 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 28x17
+                text run at (2,2) width 28: "r0c2"
+            RenderTableCell {TD} at (104,0) size 32x22 [border: (1px inset #808080)] [r=0 c=3 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 28x17
+                text run at (2,2) width 28: "r0c3"
+            RenderTableCell {TD} at (138,0) size 32x22 [border: (1px inset #808080)] [r=0 c=4 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 28x17
+                text run at (2,2) width 28: "r0c4"
+            RenderTableCell {TD} at (172,0) size 32x22 [border: (1px inset #808080)] [r=0 c=5 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 28x17
+                text run at (2,2) width 28: "r0c5"
+            RenderTableCell {TD} at (206,0) size 32x22 [border: (1px inset #808080)] [r=0 c=6 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 28x17
+                text run at (2,2) width 28: "r0c6"
+            RenderTableCell {TD} at (240,0) size 32x22 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 28x17
+                text run at (2,2) width 28: "r0c7"
         RenderTableSection {TFOOT} at (4,54) size 274x24
           RenderTableRow {TR} at (0,0) size 274x22
             RenderTableCell {TD} at (2,0) size 32x22 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
@@ -56,29 +82,3 @@
             RenderTableCell {TD} at (240,0) size 32x22 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
               RenderText {#text} at (2,2) size 13x17
                 text run at (2,2) width 13: "f7"
-        RenderTableSection {TBODY} at (4,30) size 274x24
-          RenderTableRow {TR} at (0,0) size 274x22
-            RenderTableCell {TD} at (2,0) size 32x22 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 28x17
-                text run at (2,2) width 28: "r0c0"
-            RenderTableCell {TD} at (36,0) size 32x22 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 28x17
-                text run at (2,2) width 28: "r0c1"
-            RenderTableCell {TD} at (70,0) size 32x22 [border: (1px inset #808080)] [r=0 c=2 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 28x17
-                text run at (2,2) width 28: "r0c2"
-            RenderTableCell {TD} at (104,0) size 32x22 [border: (1px inset #808080)] [r=0 c=3 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 28x17
-                text run at (2,2) width 28: "r0c3"
-            RenderTableCell {TD} at (138,0) size 32x22 [border: (1px inset #808080)] [r=0 c=4 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 28x17
-                text run at (2,2) width 28: "r0c4"
-            RenderTableCell {TD} at (172,0) size 32x22 [border: (1px inset #808080)] [r=0 c=5 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 28x17
-                text run at (2,2) width 28: "r0c5"
-            RenderTableCell {TD} at (206,0) size 32x22 [border: (1px inset #808080)] [r=0 c=6 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 28x17
-                text run at (2,2) width 28: "r0c6"
-            RenderTableCell {TD} at (240,0) size 32x22 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 28x17
-                text run at (2,2) width 28: "r0c7"

Modified: trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug30418-expected.txt (203008 => 203009)


--- trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug30418-expected.txt	2016-07-08 23:49:15 UTC (rev 203008)
+++ trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug30418-expected.txt	2016-07-09 00:04:32 UTC (rev 203009)
@@ -30,6 +30,32 @@
             RenderTableCell {TD} at (240,2) size 32x21 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
               RenderText {#text} at (2,2) size 16x17
                 text run at (2,2) width 16: "h7"
+        RenderTableSection {TBODY} at (4,29) size 274x23
+          RenderTableRow {TR} at (0,0) size 274x21
+            RenderTableCell {TD} at (2,0) size 32x21 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 28x17
+                text run at (2,2) width 28: "r0c0"
+            RenderTableCell {TD} at (36,0) size 32x21 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 28x17
+                text run at (2,2) width 28: "r0c1"
+            RenderTableCell {TD} at (70,0) size 32x21 [border: (1px inset #808080)] [r=0 c=2 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 28x17
+                text run at (2,2) width 28: "r0c2"
+            RenderTableCell {TD} at (104,0) size 32x21 [border: (1px inset #808080)] [r=0 c=3 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 28x17
+                text run at (2,2) width 28: "r0c3"
+            RenderTableCell {TD} at (138,0) size 32x21 [border: (1px inset #808080)] [r=0 c=4 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 28x17
+                text run at (2,2) width 28: "r0c4"
+            RenderTableCell {TD} at (172,0) size 32x21 [border: (1px inset #808080)] [r=0 c=5 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 28x17
+                text run at (2,2) width 28: "r0c5"
+            RenderTableCell {TD} at (206,0) size 32x21 [border: (1px inset #808080)] [r=0 c=6 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 28x17
+                text run at (2,2) width 28: "r0c6"
+            RenderTableCell {TD} at (240,0) size 32x21 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 28x17
+                text run at (2,2) width 28: "r0c7"
         RenderTableSection {TFOOT} at (4,52) size 274x23
           RenderTableRow {TR} at (0,0) size 274x21
             RenderTableCell {TD} at (2,0) size 32x21 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
@@ -56,29 +82,3 @@
             RenderTableCell {TD} at (240,0) size 32x21 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
               RenderText {#text} at (2,2) size 13x17
                 text run at (2,2) width 13: "f7"
-        RenderTableSection {TBODY} at (4,29) size 274x23
-          RenderTableRow {TR} at (0,0) size 274x21
-            RenderTableCell {TD} at (2,0) size 32x21 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 28x17
-                text run at (2,2) width 28: "r0c0"
-            RenderTableCell {TD} at (36,0) size 32x21 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 28x17
-                text run at (2,2) width 28: "r0c1"
-            RenderTableCell {TD} at (70,0) size 32x21 [border: (1px inset #808080)] [r=0 c=2 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 28x17
-                text run at (2,2) width 28: "r0c2"
-            RenderTableCell {TD} at (104,0) size 32x21 [border: (1px inset #808080)] [r=0 c=3 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 28x17
-                text run at (2,2) width 28: "r0c3"
-            RenderTableCell {TD} at (138,0) size 32x21 [border: (1px inset #808080)] [r=0 c=4 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 28x17
-                text run at (2,2) width 28: "r0c4"
-            RenderTableCell {TD} at (172,0) size 32x21 [border: (1px inset #808080)] [r=0 c=5 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 28x17
-                text run at (2,2) width 28: "r0c5"
-            RenderTableCell {TD} at (206,0) size 32x21 [border: (1px inset #808080)] [r=0 c=6 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 28x17
-                text run at (2,2) width 28: "r0c6"
-            RenderTableCell {TD} at (240,0) size 32x21 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 28x17
-                text run at (2,2) width 28: "r0c7"

Modified: trunk/LayoutTests/platform/ios-simulator/tables/mozilla/bugs/bug30418-expected.txt (203008 => 203009)


--- trunk/LayoutTests/platform/ios-simulator/tables/mozilla/bugs/bug30418-expected.txt	2016-07-08 23:49:15 UTC (rev 203008)
+++ trunk/LayoutTests/platform/ios-simulator/tables/mozilla/bugs/bug30418-expected.txt	2016-07-09 00:04:32 UTC (rev 203009)
@@ -30,6 +30,32 @@
             RenderTableCell {TD} at (243,2) size 33x24 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
               RenderText {#text} at (2,2) size 16x19
                 text run at (2,2) width 16: "h7"
+        RenderTableSection {TBODY} at (4,32) size 278x26
+          RenderTableRow {TR} at (0,0) size 278x24
+            RenderTableCell {TD} at (2,0) size 33x24 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 29x19
+                text run at (2,2) width 29: "r0c0"
+            RenderTableCell {TD} at (36,0) size 33x24 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 29x19
+                text run at (2,2) width 29: "r0c1"
+            RenderTableCell {TD} at (70,0) size 34x24 [border: (1px inset #808080)] [r=0 c=2 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 29x19
+                text run at (2,2) width 29: "r0c2"
+            RenderTableCell {TD} at (105,0) size 33x24 [border: (1px inset #808080)] [r=0 c=3 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 29x19
+                text run at (2,2) width 29: "r0c3"
+            RenderTableCell {TD} at (139,0) size 34x24 [border: (1px inset #808080)] [r=0 c=4 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 29x19
+                text run at (2,2) width 29: "r0c4"
+            RenderTableCell {TD} at (174,0) size 33x24 [border: (1px inset #808080)] [r=0 c=5 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 29x19
+                text run at (2,2) width 29: "r0c5"
+            RenderTableCell {TD} at (208,0) size 34x24 [border: (1px inset #808080)] [r=0 c=6 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 29x19
+                text run at (2,2) width 29: "r0c6"
+            RenderTableCell {TD} at (243,0) size 33x24 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 29x19
+                text run at (2,2) width 29: "r0c7"
         RenderTableSection {TFOOT} at (4,58) size 278x26
           RenderTableRow {TR} at (0,0) size 278x24
             RenderTableCell {TD} at (2,0) size 33x24 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
@@ -56,29 +82,3 @@
             RenderTableCell {TD} at (243,0) size 33x24 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
               RenderText {#text} at (2,2) size 14x19
                 text run at (2,2) width 14: "f7"
-        RenderTableSection {TBODY} at (4,32) size 278x26
-          RenderTableRow {TR} at (0,0) size 278x24
-            RenderTableCell {TD} at (2,0) size 33x24 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 29x19
-                text run at (2,2) width 29: "r0c0"
-            RenderTableCell {TD} at (36,0) size 33x24 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 29x19
-                text run at (2,2) width 29: "r0c1"
-            RenderTableCell {TD} at (70,0) size 34x24 [border: (1px inset #808080)] [r=0 c=2 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 29x19
-                text run at (2,2) width 29: "r0c2"
-            RenderTableCell {TD} at (105,0) size 33x24 [border: (1px inset #808080)] [r=0 c=3 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 29x19
-                text run at (2,2) width 29: "r0c3"
-            RenderTableCell {TD} at (139,0) size 34x24 [border: (1px inset #808080)] [r=0 c=4 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 29x19
-                text run at (2,2) width 29: "r0c4"
-            RenderTableCell {TD} at (174,0) size 33x24 [border: (1px inset #808080)] [r=0 c=5 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 29x19
-                text run at (2,2) width 29: "r0c5"
-            RenderTableCell {TD} at (208,0) size 34x24 [border: (1px inset #808080)] [r=0 c=6 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 29x19
-                text run at (2,2) width 29: "r0c6"
-            RenderTableCell {TD} at (243,0) size 33x24 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 29x19
-                text run at (2,2) width 29: "r0c7"

Modified: trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug30418-expected.txt (203008 => 203009)


--- trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug30418-expected.txt	2016-07-08 23:49:15 UTC (rev 203008)
+++ trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug30418-expected.txt	2016-07-09 00:04:32 UTC (rev 203009)
@@ -30,6 +30,32 @@
             RenderTableCell {TD} at (243,2) size 33x22 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
               RenderText {#text} at (2,2) size 16x18
                 text run at (2,2) width 16: "h7"
+        RenderTableSection {TBODY} at (4,30) size 278x24
+          RenderTableRow {TR} at (0,0) size 278x22
+            RenderTableCell {TD} at (2,0) size 33x22 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 29x18
+                text run at (2,2) width 29: "r0c0"
+            RenderTableCell {TD} at (36,0) size 33x22 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 29x18
+                text run at (2,2) width 29: "r0c1"
+            RenderTableCell {TD} at (70,0) size 34x22 [border: (1px inset #808080)] [r=0 c=2 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 29x18
+                text run at (2,2) width 29: "r0c2"
+            RenderTableCell {TD} at (105,0) size 33x22 [border: (1px inset #808080)] [r=0 c=3 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 29x18
+                text run at (2,2) width 29: "r0c3"
+            RenderTableCell {TD} at (139,0) size 34x22 [border: (1px inset #808080)] [r=0 c=4 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 29x18
+                text run at (2,2) width 29: "r0c4"
+            RenderTableCell {TD} at (174,0) size 33x22 [border: (1px inset #808080)] [r=0 c=5 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 29x18
+                text run at (2,2) width 29: "r0c5"
+            RenderTableCell {TD} at (208,0) size 34x22 [border: (1px inset #808080)] [r=0 c=6 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 29x18
+                text run at (2,2) width 29: "r0c6"
+            RenderTableCell {TD} at (243,0) size 33x22 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 29x18
+                text run at (2,2) width 29: "r0c7"
         RenderTableSection {TFOOT} at (4,54) size 278x24
           RenderTableRow {TR} at (0,0) size 278x22
             RenderTableCell {TD} at (2,0) size 33x22 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
@@ -56,29 +82,3 @@
             RenderTableCell {TD} at (243,0) size 33x22 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
               RenderText {#text} at (2,2) size 14x18
                 text run at (2,2) width 14: "f7"
-        RenderTableSection {TBODY} at (4,30) size 278x24
-          RenderTableRow {TR} at (0,0) size 278x22
-            RenderTableCell {TD} at (2,0) size 33x22 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 29x18
-                text run at (2,2) width 29: "r0c0"
-            RenderTableCell {TD} at (36,0) size 33x22 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 29x18
-                text run at (2,2) width 29: "r0c1"
-            RenderTableCell {TD} at (70,0) size 34x22 [border: (1px inset #808080)] [r=0 c=2 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 29x18
-                text run at (2,2) width 29: "r0c2"
-            RenderTableCell {TD} at (105,0) size 33x22 [border: (1px inset #808080)] [r=0 c=3 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 29x18
-                text run at (2,2) width 29: "r0c3"
-            RenderTableCell {TD} at (139,0) size 34x22 [border: (1px inset #808080)] [r=0 c=4 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 29x18
-                text run at (2,2) width 29: "r0c4"
-            RenderTableCell {TD} at (174,0) size 33x22 [border: (1px inset #808080)] [r=0 c=5 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 29x18
-                text run at (2,2) width 29: "r0c5"
-            RenderTableCell {TD} at (208,0) size 34x22 [border: (1px inset #808080)] [r=0 c=6 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 29x18
-                text run at (2,2) width 29: "r0c6"
-            RenderTableCell {TD} at (243,0) size 33x22 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 29x18
-                text run at (2,2) width 29: "r0c7"

Modified: trunk/LayoutTests/platform/win/tables/mozilla/bugs/bug30418-expected.txt (203008 => 203009)


--- trunk/LayoutTests/platform/win/tables/mozilla/bugs/bug30418-expected.txt	2016-07-08 23:49:15 UTC (rev 203008)
+++ trunk/LayoutTests/platform/win/tables/mozilla/bugs/bug30418-expected.txt	2016-07-09 00:04:32 UTC (rev 203009)
@@ -30,6 +30,32 @@
             RenderTableCell {TD} at (240,2) size 32x22 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
               RenderText {#text} at (2,2) size 16x18
                 text run at (2,2) width 16: "h7"
+        RenderTableSection {TBODY} at (4,30) size 274x24
+          RenderTableRow {TR} at (0,0) size 274x22
+            RenderTableCell {TD} at (2,0) size 32x22 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 28x18
+                text run at (2,2) width 28: "r0c0"
+            RenderTableCell {TD} at (36,0) size 32x22 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 28x18
+                text run at (2,2) width 28: "r0c1"
+            RenderTableCell {TD} at (70,0) size 32x22 [border: (1px inset #808080)] [r=0 c=2 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 28x18
+                text run at (2,2) width 28: "r0c2"
+            RenderTableCell {TD} at (104,0) size 32x22 [border: (1px inset #808080)] [r=0 c=3 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 28x18
+                text run at (2,2) width 28: "r0c3"
+            RenderTableCell {TD} at (138,0) size 32x22 [border: (1px inset #808080)] [r=0 c=4 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 28x18
+                text run at (2,2) width 28: "r0c4"
+            RenderTableCell {TD} at (172,0) size 32x22 [border: (1px inset #808080)] [r=0 c=5 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 28x18
+                text run at (2,2) width 28: "r0c5"
+            RenderTableCell {TD} at (206,0) size 32x22 [border: (1px inset #808080)] [r=0 c=6 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 28x18
+                text run at (2,2) width 28: "r0c6"
+            RenderTableCell {TD} at (240,0) size 32x22 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
+              RenderText {#text} at (2,2) size 28x18
+                text run at (2,2) width 28: "r0c7"
         RenderTableSection {TFOOT} at (4,54) size 274x24
           RenderTableRow {TR} at (0,0) size 274x22
             RenderTableCell {TD} at (2,0) size 32x22 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
@@ -56,29 +82,3 @@
             RenderTableCell {TD} at (240,0) size 32x22 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
               RenderText {#text} at (2,2) size 13x18
                 text run at (2,2) width 13: "f7"
-        RenderTableSection {TBODY} at (4,30) size 274x24
-          RenderTableRow {TR} at (0,0) size 274x22
-            RenderTableCell {TD} at (2,0) size 32x22 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 28x18
-                text run at (2,2) width 28: "r0c0"
-            RenderTableCell {TD} at (36,0) size 32x22 [border: (1px inset #808080)] [r=0 c=1 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 28x18
-                text run at (2,2) width 28: "r0c1"
-            RenderTableCell {TD} at (70,0) size 32x22 [border: (1px inset #808080)] [r=0 c=2 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 28x18
-                text run at (2,2) width 28: "r0c2"
-            RenderTableCell {TD} at (104,0) size 32x22 [border: (1px inset #808080)] [r=0 c=3 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 28x18
-                text run at (2,2) width 28: "r0c3"
-            RenderTableCell {TD} at (138,0) size 32x22 [border: (1px inset #808080)] [r=0 c=4 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 28x18
-                text run at (2,2) width 28: "r0c4"
-            RenderTableCell {TD} at (172,0) size 32x22 [border: (1px inset #808080)] [r=0 c=5 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 28x18
-                text run at (2,2) width 28: "r0c5"
-            RenderTableCell {TD} at (206,0) size 32x22 [border: (1px inset #808080)] [r=0 c=6 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 28x18
-                text run at (2,2) width 28: "r0c6"
-            RenderTableCell {TD} at (240,0) size 32x22 [border: (1px inset #808080)] [r=0 c=7 rs=1 cs=1]
-              RenderText {#text} at (2,2) size 28x18
-                text run at (2,2) width 28: "r0c7"

Modified: trunk/Source/WebCore/ChangeLog (203008 => 203009)


--- trunk/Source/WebCore/ChangeLog	2016-07-08 23:49:15 UTC (rev 203008)
+++ trunk/Source/WebCore/ChangeLog	2016-07-09 00:04:32 UTC (rev 203009)
@@ -1,3 +1,23 @@
+2016-07-08  Daniel Bates  <[email protected]>
+
+        Setting table.tFoot or calling table.createTFoot() should append HTML tfont element to the end of the table
+        https://bugs.webkit.org/show_bug.cgi?id=159583
+        <rdar://problem/27255292>
+
+        Reviewed by Chris Dumez.
+
+        he HTML standard has long since been revised to describe that assignment to property table.tFoot
+        or invoking table.createTFoot() will append the HTML tfoot element to the end of the table. This
+        behavior is defined in <https://html.spec.whatwg.org/multipage/tables.html#dom-table-tfoot> (8 July 2016)
+        and <https://html.spec.whatwg.org/multipage/tables.html#dom-table-createtfoot> for the property
+        table.tFoot and table.createTFoot(), respectively. This change makes our behavior match the
+        behavior in Mozilla Firefox, Microsoft Edge, Microsoft Internet Explorer 8 and later.
+
+        * html/HTMLTableElement.cpp:
+        (WebCore::HTMLTableElement::setTFoot): Append <tfoot> to the end of the table. Use RefPtr<>&& instead of PassRefPtr.
+        (WebCore::HTMLTableElement::createTFoot): Use RefPtr<>&& instead of PassRefPtr.
+        * html/HTMLTableElement.h:
+
 2016-07-08  Jer Noble  <[email protected]>
 
         Crash in layout test /media/video-buffered-range-contains-currentTime.html

Modified: trunk/Source/WebCore/html/HTMLTableElement.cpp (203008 => 203009)


--- trunk/Source/WebCore/html/HTMLTableElement.cpp	2016-07-08 23:49:15 UTC (rev 203008)
+++ trunk/Source/WebCore/html/HTMLTableElement.cpp	2016-07-09 00:04:32 UTC (rev 203009)
@@ -122,7 +122,7 @@
     return nullptr;
 }
 
-void HTMLTableElement::setTFoot(PassRefPtr<HTMLTableSectionElement> newFoot, ExceptionCode& ec)
+void HTMLTableElement::setTFoot(RefPtr<HTMLTableSectionElement>&& newFoot, ExceptionCode& ec)
 {
     if (UNLIKELY(newFoot && !newFoot->hasTagName(tfootTag))) {
         ec = HIERARCHY_REQUEST_ERR;
@@ -134,12 +134,7 @@
     if (!newFoot)
         return;
 
-    Node* child;
-    for (child = firstChild(); child; child = child->nextSibling())
-        if (child->isElementNode() && !child->hasTagName(captionTag) && !child->hasTagName(colgroupTag) && !child->hasTagName(theadTag))
-            break;
-
-    insertBefore(*newFoot, child, ec);
+    appendChild(*newFoot, ec);
 }
 
 Ref<HTMLTableSectionElement> HTMLTableElement::createTHead()
@@ -162,7 +157,7 @@
     if (HTMLTableSectionElement* existingFoot = tFoot())
         return *existingFoot;
     Ref<HTMLTableSectionElement> foot = HTMLTableSectionElement::create(tfootTag, document());
-    setTFoot(foot.ptr(), IGNORE_EXCEPTION);
+    setTFoot(WTFMove(foot), IGNORE_EXCEPTION);
     return foot;
 }
 

Modified: trunk/Source/WebCore/html/HTMLTableElement.h (203008 => 203009)


--- trunk/Source/WebCore/html/HTMLTableElement.h	2016-07-08 23:49:15 UTC (rev 203008)
+++ trunk/Source/WebCore/html/HTMLTableElement.h	2016-07-09 00:04:32 UTC (rev 203009)
@@ -47,7 +47,7 @@
     void setTHead(PassRefPtr<HTMLTableSectionElement>, ExceptionCode&);
 
     HTMLTableSectionElement* tFoot() const;
-    void setTFoot(PassRefPtr<HTMLTableSectionElement>, ExceptionCode&);
+    void setTFoot(RefPtr<HTMLTableSectionElement>&&, ExceptionCode&);
 
     Ref<HTMLTableSectionElement> createTHead();
     void deleteTHead();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to