Title: [203011] trunk/Source/WebCore
Revision
203011
Author
[email protected]
Date
2016-07-08 17:19:13 -0700 (Fri, 08 Jul 2016)

Log Message

Setting table.tFoot or calling table.createTFoot() should append HTML tfont element to the end of the table
https://bugs.webkit.org/show_bug.cgi?id=159583
<rdar://problem/27255292>

In HTMLTableElement::createTFoot() I inadvertently made use of WTFMove() to move the instantiated
HTMLTableSectionElement into the argument passed to setTFoot(). We should use Ref::copyRef() instead
because we want this function to return the instantiated table section.

* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::createTFoot):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (203010 => 203011)


--- trunk/Source/WebCore/ChangeLog	2016-07-09 00:15:16 UTC (rev 203010)
+++ trunk/Source/WebCore/ChangeLog	2016-07-09 00:19:13 UTC (rev 203011)
@@ -4,6 +4,19 @@
         https://bugs.webkit.org/show_bug.cgi?id=159583
         <rdar://problem/27255292>
 
+        In HTMLTableElement::createTFoot() I inadvertently made use of WTFMove() to move the instantiated
+        HTMLTableSectionElement into the argument passed to setTFoot(). We should use Ref::copyRef() instead
+        because we want this function to return the instantiated table section.
+
+        * html/HTMLTableElement.cpp:
+        (WebCore::HTMLTableElement::createTFoot):
+
+2016-07-08  Daniel Bates  <[email protected]>
+
+        Setting table.tFoot or calling table.createTFoot() should append HTML tfont element to the end of the table
+        https://bugs.webkit.org/show_bug.cgi?id=159583
+        <rdar://problem/27255292>
+
         Reviewed by Chris Dumez.
 
         he HTML standard has long since been revised to describe that assignment to property table.tFoot

Modified: trunk/Source/WebCore/html/HTMLTableElement.cpp (203010 => 203011)


--- trunk/Source/WebCore/html/HTMLTableElement.cpp	2016-07-09 00:15:16 UTC (rev 203010)
+++ trunk/Source/WebCore/html/HTMLTableElement.cpp	2016-07-09 00:19:13 UTC (rev 203011)
@@ -157,7 +157,7 @@
     if (HTMLTableSectionElement* existingFoot = tFoot())
         return *existingFoot;
     Ref<HTMLTableSectionElement> foot = HTMLTableSectionElement::create(tfootTag, document());
-    setTFoot(WTFMove(foot), IGNORE_EXCEPTION);
+    setTFoot(foot.copyRef(), IGNORE_EXCEPTION);
     return foot;
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to