Diff
Modified: trunk/Source/WebCore/ChangeLog (203157 => 203158)
--- trunk/Source/WebCore/ChangeLog 2016-07-13 11:00:43 UTC (rev 203157)
+++ trunk/Source/WebCore/ChangeLog 2016-07-13 11:37:48 UTC (rev 203158)
@@ -1,5 +1,21 @@
2016-07-13 Carlos Garcia Campos <[email protected]>
+ Unreviewed. Fix GObject DOM bindings API breaks after r203047-
+
+ webkit_dom_document_set_title() and webkit_dom_html_title_element_set_text() now can raise exceptions.
+
+ * bindings/gobject/WebKitDOMDeprecated.cpp:
+ (webkit_dom_document_set_title):
+ (webkit_dom_html_title_element_set_text):
+ * bindings/gobject/WebKitDOMDeprecated.h:
+ * bindings/gobject/WebKitDOMDeprecated.symbols:
+ * bindings/gobject/webkitdom.symbols:
+ * bindings/scripts/CodeGeneratorGObject.pm:
+ (GenerateProperty):
+ (FunctionUsedToNotRaiseException):
+
+2016-07-13 Carlos Garcia Campos <[email protected]>
+
[Coordinated Graphics] Remove toCoordinatedGraphicsLayer and use downcast instead
https://bugs.webkit.org/show_bug.cgi?id=159469
Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp (203157 => 203158)
--- trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp 2016-07-13 11:00:43 UTC (rev 203157)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp 2016-07-13 11:37:48 UTC (rev 203158)
@@ -24,6 +24,7 @@
#include "JSMainThreadExecState.h"
#include "WebKitDOMDocumentPrivate.h"
#include "WebKitDOMElementPrivate.h"
+#include "WebKitDOMHTMLTitleElement.h"
#include "WebKitDOMNodeListPrivate.h"
#include <wtf/GetPtr.h>
#include <wtf/RefPtr.h>
@@ -132,6 +133,16 @@
return webkit_dom_node_clone_node_with_error(self, deep, nullptr);
}
+void webkit_dom_document_set_title(WebKitDOMDocument* self, const gchar* title)
+{
+ webkit_dom_document_set_title_with_error(self, title, nullptr);
+}
+
+void webkit_dom_html_title_element_set_text(WebKitDOMHTMLTitleElement* self, const gchar* text)
+{
+ webkit_dom_html_title_element_set_text_with_error(self, text, nullptr);
+}
+
G_DEFINE_TYPE(WebKitDOMEntityReference, webkit_dom_entity_reference, WEBKIT_DOM_TYPE_NODE)
static void webkit_dom_entity_reference_init(WebKitDOMEntityReference*)
Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h (203157 => 203158)
--- trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h 2016-07-13 11:00:43 UTC (rev 203157)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h 2016-07-13 11:37:48 UTC (rev 203158)
@@ -171,7 +171,26 @@
WEBKIT_DEPRECATED_FOR(webkit_dom_node_clone_node_with_error) WebKitDOMNode*
webkit_dom_node_clone_node(WebKitDOMNode* self, gboolean deep, GError** error);
+/**
+ * webkit_dom_document_set_title:
+ * @self: A #WebKitDOMDocument
+ * @title: A #gchar
+ *
+ * Deprecated: 2.14: Use webkit_dom_document_set_title_with_error() instead.
+ */
+WEBKIT_DEPRECATED_FOR(webkit_dom_document_set_title_with_error) void
+webkit_dom_document_set_title(WebKitDOMDocument* self, const gchar* title);
+/**
+ * webkit_dom_html_title_element_set_text:
+ * @self: A #WebKitDOMHTMLTitleElement
+ * @text: A #gchar
+ *
+ * Deprecated: 2.14: Use webkit_dom_html_title_element_set_text_with_error() instead.
+ */
+WEBKIT_DEPRECATED_FOR(webkit_dom_html_title_element_set_text_with_error) void
+webkit_dom_html_title_element_set_text(WebKitDOMHTMLTitleElement* self, const gchar* text);
+
#define WEBKIT_DOM_TYPE_ENTITY_REFERENCE (webkit_dom_entity_reference_get_type())
#define WEBKIT_DOM_ENTITY_REFERENCE(obj) (G_TYPE_CHECK_INSTANCE_CAST((obj), WEBKIT_DOM_TYPE_ENTITY_REFERENCE, WebKitDOMEntityReference))
#define WEBKIT_DOM_ENTITY_REFERENCE_CLASS(klass) (G_TYPE_CHECK_CLASS_CAST((klass), WEBKIT_DOM_TYPE_ENTITY_REFERENCE, WebKitDOMEntityReferenceClass)
Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols (203157 => 203158)
--- trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols 2016-07-13 11:00:43 UTC (rev 203157)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols 2016-07-13 11:37:48 UTC (rev 203158)
@@ -21,3 +21,5 @@
void webkit_dom_html_base_font_element_set_face(WebKitDOMHTMLBaseFontElement*, const gchar*)
void webkit_dom_html_base_font_element_set_size(WebKitDOMHTMLBaseFontElement*, glong)
WebKitDOMNode* webkit_dom_node_clone_node(WebKitDOMNode*, gboolean)
+void webkit_dom_document_set_title(WebKitDOMDocument*, const gchar*)
+void webkit_dom_html_title_element_set_text(WebKitDOMHTMLTitleElement*, const gchar*)
Modified: trunk/Source/WebCore/bindings/gobject/webkitdom.symbols (203157 => 203158)
--- trunk/Source/WebCore/bindings/gobject/webkitdom.symbols 2016-07-13 11:00:43 UTC (rev 203157)
+++ trunk/Source/WebCore/bindings/gobject/webkitdom.symbols 2016-07-13 11:37:48 UTC (rev 203158)
@@ -28,6 +28,7 @@
WebKitDOMHTMLCollection* webkit_dom_document_get_images(WebKitDOMDocument*)
gchar* webkit_dom_document_get_title(WebKitDOMDocument*)
void webkit_dom_document_set_title(WebKitDOMDocument*, const gchar*)
+void webkit_dom_document_set_title_with_error(WebKitDOMDocument*, const gchar*, GError**)@2.14
gchar* webkit_dom_document_get_charset(WebKitDOMDocument*)
void webkit_dom_document_set_charset(WebKitDOMDocument*, const gchar*)
gchar* webkit_dom_document_get_default_charset(WebKitDOMDocument*)
@@ -950,6 +951,7 @@
GType webkit_dom_html_title_element_get_type(void)
gchar* webkit_dom_html_title_element_get_text(WebKitDOMHTMLTitleElement*)
void webkit_dom_html_title_element_set_text(WebKitDOMHTMLTitleElement*, const gchar*)
+void webkit_dom_html_title_element_set_text_with_error(WebKitDOMHTMLTitleElement*, const gchar*, GError**)@2.14
GType webkit_dom_html_u_list_element_get_type(void)
gchar* webkit_dom_html_u_list_element_get_type_attr(WebKitDOMHTMLUListElement*)
void webkit_dom_html_u_list_element_set_type_attr(WebKitDOMHTMLUListElement*, const gchar*)
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (203157 => 203158)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2016-07-13 11:00:43 UTC (rev 203157)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2016-07-13 11:37:48 UTC (rev 203158)
@@ -560,6 +560,9 @@
}
my $getterFunctionName = "webkit_dom_${decamelizeInterfaceName}_get_" . $propFunctionName;
+ if (FunctionUsedToNotRaiseException($getterFunctionName)) {
+ $getterFunctionName = $getterFunctionName . "_with_error";
+ }
my @getterArguments = ();
push(@getterArguments, "self");
push(@getterArguments, "nullptr") if $hasGetterException || FunctionUsedToRaiseException($getterFunctionName);
@@ -566,6 +569,9 @@
if (grep {$_ eq $attribute} @writeableProperties) {
my $setterFunctionName = "webkit_dom_${decamelizeInterfaceName}_set_" . $propFunctionName;
+ if (FunctionUsedToNotRaiseException($setterFunctionName)) {
+ $setterFunctionName = $setterFunctionName . "_with_error";
+ }
my @setterArguments = ();
push(@setterArguments, "self, g_value_get_$gtype(value)");
push(@setterArguments, "nullptr") if $hasSetterException || FunctionUsedToRaiseException($setterFunctionName);
@@ -1048,7 +1054,9 @@
sub FunctionUsedToNotRaiseException {
my $functionName = shift;
- return $functionName eq "webkit_dom_node_clone_node";
+ return $functionName eq "webkit_dom_document_set_title"
+ || $functionName eq "webkit_dom_html_title_element_set_text"
+ || $functionName eq "webkit_dom_node_clone_node";
}
sub GenerateFunction {
