Title: [203291] trunk/Websites/webkit.org
- Revision
- 203291
- Author
- [email protected]
- Date
- 2016-07-15 12:27:54 -0700 (Fri, 15 Jul 2016)
Log Message
Fixed content overflow and missing build information behavior.
https://bugs.webkit.org/show_bug.cgi?id=159820
Reviewed by Timothy Hatcher.
* wp-content/themes/webkit/nightly-start.php:
Modified Paths
Diff
Modified: trunk/Websites/webkit.org/ChangeLog (203290 => 203291)
--- trunk/Websites/webkit.org/ChangeLog 2016-07-15 19:01:56 UTC (rev 203290)
+++ trunk/Websites/webkit.org/ChangeLog 2016-07-15 19:27:54 UTC (rev 203291)
@@ -1,3 +1,12 @@
+2016-07-15 Jon Davis <[email protected]>
+
+ Fixed content overflow and missing build information behavior.
+ https://bugs.webkit.org/show_bug.cgi?id=159820
+
+ Reviewed by Timothy Hatcher.
+
+ * wp-content/themes/webkit/nightly-start.php:
+
2016-07-14 Jon Davis <[email protected]>
Improved WebKit Nightly start page design.
Modified: trunk/Websites/webkit.org/wp-content/themes/webkit/nightly-start.php (203290 => 203291)
--- trunk/Websites/webkit.org/wp-content/themes/webkit/nightly-start.php 2016-07-15 19:01:56 UTC (rev 203290)
+++ trunk/Websites/webkit.org/wp-content/themes/webkit/nightly-start.php 2016-07-15 19:27:54 UTC (rev 203291)
@@ -9,17 +9,18 @@
$branch = get_query_var('nightly_branch');
$build = intval(get_query_var('nightly_build'));
-if ($build < 11976 || $build > $latest || empty($branch))
- return show_404_page();
-
get_header();
add_filter('the_content', function ($content) {
$branch = get_query_var('nightly_branch');
$build = intval(get_query_var('nightly_build'));
+
+ if (empty($Build) || empty($branch) || $build < 11976) {
+ $content = preg_replace('/<p>(.*?)%1\$s<\/p>/', '<p></p>', $content);
+ } else {
+ $content = sprintf($content, "r$build", $branch);
+ }
- $content = sprintf($content, "r$build", $branch);
-
return $content;
});
?>
@@ -151,13 +152,12 @@
.update-nag {
background-color: #FF9D00;
color: #000000;
- width: 100vw;
- left: 50%;
+ width: 100%;
+ top: 0;
+ left: 0;
position: absolute;
- transform: translate(-50vw);
- padding: 1.5rem;
+ padding-bottom: 1.5rem;
padding-top: 11.5rem;
- top: 0;
}
.admin-bar .update-nag {
@@ -186,8 +186,6 @@
}
</style>
-<?xml version="1.0" encoding="utf-8"?>
-<!-- Copyright © 2015 Apple Inc. All rights reserved. -->
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" version="1.1" id="icons-sprite">
<style>
svg,symbol { color: white; }
@@ -252,8 +250,9 @@
</defs>
</svg>
<?php if ( (int)$build < (int)$latest ):
- $prompt_text = "A new nightly build is available. Please update before continuing.";
- $prompt_meta = get_post_meta(get_the_ID(), 'prompt', true);
+ $prompt_text = "Please be sure you are running the latest WebKit Nightly build before continuing to test.";
+ if (!empty($build))
+ $prompt_meta = get_post_meta(get_the_ID(), 'prompt', true);
if (!empty($prompt_meta)) $prompt_text = $prompt_meta;
?>
<div class="update-nag">
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
