Title: [203420] trunk/Source/WebCore
- Revision
- 203420
- Author
- [email protected]
- Date
- 2016-07-19 14:14:04 -0700 (Tue, 19 Jul 2016)
Log Message
Fix SharedBuffer leak in MockContentFilter::replacementData().
<https://webkit.org/b/159945>
Reviewed by Andy Estes.
Spotted on leaks bot. This code was pretty explicit about how it's going to leak.
Since this is in the mock filter, it only affected layout tests.
* testing/MockContentFilter.cpp:
(WebCore::MockContentFilter::replacementData):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (203419 => 203420)
--- trunk/Source/WebCore/ChangeLog 2016-07-19 20:52:48 UTC (rev 203419)
+++ trunk/Source/WebCore/ChangeLog 2016-07-19 21:14:04 UTC (rev 203420)
@@ -1,3 +1,16 @@
+2016-07-19 Andreas Kling <[email protected]>
+
+ Fix SharedBuffer leak in MockContentFilter::replacementData().
+ <https://webkit.org/b/159945>
+
+ Reviewed by Andy Estes.
+
+ Spotted on leaks bot. This code was pretty explicit about how it's going to leak.
+ Since this is in the mock filter, it only affected layout tests.
+
+ * testing/MockContentFilter.cpp:
+ (WebCore::MockContentFilter::replacementData):
+
2016-07-19 Zalan Bujtas <[email protected]>
theguardian.co.uk crossword puzzles are sometimes not displaying text
Modified: trunk/Source/WebCore/testing/MockContentFilter.cpp (203419 => 203420)
--- trunk/Source/WebCore/testing/MockContentFilter.cpp 2016-07-19 20:52:48 UTC (rev 203419)
+++ trunk/Source/WebCore/testing/MockContentFilter.cpp 2016-07-19 21:14:04 UTC (rev 203420)
@@ -114,7 +114,7 @@
Ref<SharedBuffer> MockContentFilter::replacementData() const
{
ASSERT(didBlockData());
- return SharedBuffer::create(m_replacementData.data(), m_replacementData.size()).leakRef();
+ return SharedBuffer::create(m_replacementData.data(), m_replacementData.size());
}
ContentFilterUnblockHandler MockContentFilter::unblockHandler() const
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
