Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (98204 => 98205)
--- trunk/Source/_javascript_Core/ChangeLog 2011-10-24 00:11:09 UTC (rev 98204)
+++ trunk/Source/_javascript_Core/ChangeLog 2011-10-24 00:21:52 UTC (rev 98205)
@@ -1,5 +1,18 @@
2011-10-23 Mark Hahnenberg <[email protected]>
+ Add deleteProperty to the MethodTable
+ https://bugs.webkit.org/show_bug.cgi?id=70162
+
+ Reviewed by Sam Weinig.
+
+ * _javascript_Core.exp:
+ * runtime/ClassInfo.h: Added both versions of deleteProperty to the MethodTable.
+ * runtime/JSFunction.h: Changed JSFunction::deleteProperty to
+ be protected rather than private for subclasses who don't provide their own
+ implementation.
+
+2011-10-23 Mark Hahnenberg <[email protected]>
+
Remove getConstructDataVirtual
https://bugs.webkit.org/show_bug.cgi?id=70638
Modified: trunk/Source/_javascript_Core/_javascript_Core.exp (98204 => 98205)
--- trunk/Source/_javascript_Core/_javascript_Core.exp 2011-10-24 00:11:09 UTC (rev 98204)
+++ trunk/Source/_javascript_Core/_javascript_Core.exp 2011-10-24 00:21:52 UTC (rev 98205)
@@ -328,6 +328,7 @@
__ZN3JSC8JSObject17putWithAttributesEPNS_9ExecStateEjNS_7JSValueEj
__ZN3JSC8JSObject18getOwnPropertySlotEPNS_6JSCellEPNS_9ExecStateEjRNS_12PropertySlotE
__ZN3JSC8JSObject19getOwnPropertyNamesEPNS_9ExecStateERNS_17PropertyNameArrayENS_15EnumerationModeE
+__ZN3JSC8JSObject21deletePropertyByIndexEPNS_6JSCellEPNS_9ExecStateEj
__ZN3JSC8JSObject21deletePropertyVirtualEPNS_9ExecStateERKNS_10IdentifierE
__ZN3JSC8JSObject21deletePropertyVirtualEPNS_9ExecStateEj
__ZN3JSC8JSObject21getPropertyDescriptorEPNS_9ExecStateERKNS_10IdentifierERNS_18PropertyDescriptorE
Modified: trunk/Source/_javascript_Core/runtime/ClassInfo.h (98204 => 98205)
--- trunk/Source/_javascript_Core/runtime/ClassInfo.h 2011-10-24 00:11:09 UTC (rev 98204)
+++ trunk/Source/_javascript_Core/runtime/ClassInfo.h 2011-10-24 00:21:52 UTC (rev 98205)
@@ -46,6 +46,12 @@
typedef void (*PutByIndexFunctionPtr)(JSCell*, ExecState*, unsigned propertyName, JSValue);
PutByIndexFunctionPtr putByIndex;
+
+ typedef bool (*DeletePropertyFunctionPtr)(JSCell*, ExecState*, const Identifier&);
+ DeletePropertyFunctionPtr deleteProperty;
+
+ typedef bool (*DeletePropertyByIndexFunctionPtr)(JSCell*, ExecState*, unsigned);
+ DeletePropertyByIndexFunctionPtr deletePropertyByIndex;
};
#define CREATE_METHOD_TABLE(ClassName) { \
@@ -54,6 +60,8 @@
&ClassName::getConstructData, \
&ClassName::put, \
&ClassName::putByIndex, \
+ &ClassName::deleteProperty, \
+ &ClassName::deletePropertyByIndex, \
}, \
sizeof(ClassName)
Modified: trunk/Source/_javascript_Core/runtime/JSFunction.h (98204 => 98205)
--- trunk/Source/_javascript_Core/runtime/JSFunction.h 2011-10-24 00:11:09 UTC (rev 98204)
+++ trunk/Source/_javascript_Core/runtime/JSFunction.h 2011-10-24 00:21:52 UTC (rev 98205)
@@ -137,6 +137,9 @@
virtual void putVirtual(ExecState*, const Identifier& propertyName, JSValue, PutPropertySlot&);
static void put(JSCell*, ExecState*, const Identifier& propertyName, JSValue, PutPropertySlot&);
+ virtual bool deletePropertyVirtual(ExecState*, const Identifier& propertyName);
+ static bool deleteProperty(JSCell*, ExecState*, const Identifier& propertyName);
+
static void visitChildren(JSCell*, SlotVisitor&);
private:
@@ -144,9 +147,6 @@
bool isHostFunctionNonInline() const;
- virtual bool deletePropertyVirtual(ExecState*, const Identifier& propertyName);
- static bool deleteProperty(JSCell*, ExecState*, const Identifier& propertyName);
-
static JSValue argumentsGetter(ExecState*, JSValue, const Identifier&);
static JSValue callerGetter(ExecState*, JSValue, const Identifier&);
static JSValue lengthGetter(ExecState*, JSValue, const Identifier&);
Modified: trunk/Source/WebCore/ChangeLog (98204 => 98205)
--- trunk/Source/WebCore/ChangeLog 2011-10-24 00:11:09 UTC (rev 98204)
+++ trunk/Source/WebCore/ChangeLog 2011-10-24 00:21:52 UTC (rev 98205)
@@ -1,3 +1,14 @@
+2011-10-23 Mark Hahnenberg <[email protected]>
+
+ Add deleteProperty to the MethodTable
+ https://bugs.webkit.org/show_bug.cgi?id=70162
+
+ Reviewed by Sam Weinig.
+
+ No new tests.
+
+ * WebCore.exp.in:
+
2011-10-23 Adam Barth <[email protected]>
Update baselines for run-bindings-tests.
Modified: trunk/Source/WebCore/WebCore.exp.in (98204 => 98205)
--- trunk/Source/WebCore/WebCore.exp.in 2011-10-24 00:11:09 UTC (rev 98204)
+++ trunk/Source/WebCore/WebCore.exp.in 2011-10-24 00:21:52 UTC (rev 98205)
@@ -1699,6 +1699,7 @@
__ZN3JSC8Bindings10RootObjectD1Ev
__ZN3JSC8Bindings13RuntimeObject10putVirtualEPNS_9ExecStateERKNS_10IdentifierENS_7JSValueERNS_15PutPropertySlotE
__ZN3JSC8Bindings13RuntimeObject11getCallDataEPNS_6JSCellERNS_8CallDataE
+__ZN3JSC8Bindings13RuntimeObject14deletePropertyEPNS_6JSCellEPNS_9ExecStateERKNS_10IdentifierE
__ZN3JSC8Bindings13RuntimeObject14finishCreationEPNS_14JSGlobalObjectE
__ZN3JSC8Bindings13RuntimeObject16getConstructDataEPNS_6JSCellERNS_13ConstructDataE
__ZN3JSC8Bindings13RuntimeObject18getOwnPropertySlotEPNS_6JSCellEPNS_9ExecStateERKNS_10IdentifierERNS_12PropertySlotE
