Title: [203422] trunk/Source/WebCore
- Revision
- 203422
- Author
- [email protected]
- Date
- 2016-07-19 14:55:51 -0700 (Tue, 19 Jul 2016)
Log Message
Get rid of a #define private public hack in WebCore
https://bugs.webkit.org/show_bug.cgi?id=159953
Reviewed by Dan Bernstein.
Use @package instead.
* bindings/objc/DOMInternal.h:
* bindings/objc/DOMObject.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (203421 => 203422)
--- trunk/Source/WebCore/ChangeLog 2016-07-19 21:27:01 UTC (rev 203421)
+++ trunk/Source/WebCore/ChangeLog 2016-07-19 21:55:51 UTC (rev 203422)
@@ -1,3 +1,15 @@
+2016-07-19 Anders Carlsson <[email protected]>
+
+ Get rid of a #define private public hack in WebCore
+ https://bugs.webkit.org/show_bug.cgi?id=159953
+
+ Reviewed by Dan Bernstein.
+
+ Use @package instead.
+
+ * bindings/objc/DOMInternal.h:
+ * bindings/objc/DOMObject.h:
+
2016-07-19 Andreas Kling <[email protected]>
Fix SharedBuffer leak in MockContentFilter::replacementData().
Modified: trunk/Source/WebCore/bindings/objc/DOMInternal.h (203421 => 203422)
--- trunk/Source/WebCore/bindings/objc/DOMInternal.h 2016-07-19 21:27:01 UTC (rev 203421)
+++ trunk/Source/WebCore/bindings/objc/DOMInternal.h 2016-07-19 21:55:51 UTC (rev 203422)
@@ -25,13 +25,8 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-// This is lets our internals access DOMObject's _internal field while having
-// it be private for clients outside WebKit.
-#define private public
+#import "DOMNodeFilter.h"
#import "DOMObject.h"
-#undef private
-
-#import "DOMNodeFilter.h"
#import "DOMXPathNSResolver.h"
#import <wtf/Forward.h>
Modified: trunk/Source/WebCore/bindings/objc/DOMObject.h (203421 => 203422)
--- trunk/Source/WebCore/bindings/objc/DOMObject.h 2016-07-19 21:27:01 UTC (rev 203421)
+++ trunk/Source/WebCore/bindings/objc/DOMObject.h 2016-07-19 21:55:51 UTC (rev 203422)
@@ -34,9 +34,8 @@
typedef struct DOMObjectInternal DOMObjectInternal;
WEBKIT_CLASS_AVAILABLE_MAC(10_4)
-@interface DOMObject : WebScriptObject <NSCopying>
-{
-@private
+@interface DOMObject : WebScriptObject <NSCopying> {
+@package
DOMObjectInternal *_internal;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
