Diff
Modified: trunk/LayoutTests/ChangeLog (203437 => 203438)
--- trunk/LayoutTests/ChangeLog 2016-07-20 01:20:23 UTC (rev 203437)
+++ trunk/LayoutTests/ChangeLog 2016-07-20 01:27:24 UTC (rev 203438)
@@ -1,5 +1,20 @@
2016-07-19 Chris Dumez <[email protected]>
+ Drop SVGElement.xmlbase attribute
+ https://bugs.webkit.org/show_bug.cgi?id=159926
+
+ Reviewed by Benjamin Poulain.
+
+ * svg/dom/SVGElement-xmlbase-expected.txt: Added.
+ * svg/dom/SVGElement-xmlbase.html: Added.
+ Check that SVGElement.xmlbase does not exist.
+
+ * svg/dom/svg-element-attribute-js-null-expected.txt:
+ * svg/dom/svg-element-attribute-js-null.xhtml:
+ Drop obsolete testing for SVGElement.xmlbase.
+
+2016-07-19 Chris Dumez <[email protected]>
+
Align CSSStyleDeclaration.setProperty() with the specification
https://bugs.webkit.org/show_bug.cgi?id=159955
Added: trunk/LayoutTests/svg/dom/SVGElement-xmlbase-expected.txt (0 => 203438)
--- trunk/LayoutTests/svg/dom/SVGElement-xmlbase-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/dom/SVGElement-xmlbase-expected.txt 2016-07-20 01:27:24 UTC (rev 203438)
@@ -0,0 +1,10 @@
+Check that SVGElement.xmlbase does not exist.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS svgElement.xmlbase is undefined.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/svg/dom/SVGElement-xmlbase.html (0 => 203438)
--- trunk/LayoutTests/svg/dom/SVGElement-xmlbase.html (rev 0)
+++ trunk/LayoutTests/svg/dom/SVGElement-xmlbase.html 2016-07-20 01:27:24 UTC (rev 203438)
@@ -0,0 +1,13 @@
+<!DOCTYPE html>
+<html>
+<body>
+<script src=""
+<script>
+description("Check that SVGElement.xmlbase does not exist.");
+
+var svgElement = document.createElementNS("http://www.w3.org/2000/svg", "svg");
+shouldBeUndefined("svgElement.xmlbase");
+</script>
+<script src=""
+</body>
+</html>
Modified: trunk/LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt (203437 => 203438)
--- trunk/LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt 2016-07-20 01:20:23 UTC (rev 203437)
+++ trunk/LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt 2016-07-20 01:27:24 UTC (rev 203438)
@@ -1,7 +1,6 @@
This test setting various attributes of a SVG elements to _javascript_ null.
TEST SUCCEEDED: The value was the string 'null'. [tested SVGElement.id]
-TEST SUCCEEDED: The value was the empty string. [tested SVGElement.xmlbase]
TEST SUCCEEDED: The value was the string '0'. [tested SVGAngle.valueAsString]
Modified: trunk/LayoutTests/svg/dom/svg-element-attribute-js-null.xhtml (203437 => 203438)
--- trunk/LayoutTests/svg/dom/svg-element-attribute-js-null.xhtml 2016-07-20 01:20:23 UTC (rev 203437)
+++ trunk/LayoutTests/svg/dom/svg-element-attribute-js-null.xhtml 2016-07-20 01:27:24 UTC (rev 203438)
@@ -53,7 +53,6 @@
elementToUse: svg,
attributes: [
{name: 'id', expectedNull: 'null'},
- {name: 'xmlbase', expectedNull: ''}
]
},
{
Modified: trunk/Source/WebCore/ChangeLog (203437 => 203438)
--- trunk/Source/WebCore/ChangeLog 2016-07-20 01:20:23 UTC (rev 203437)
+++ trunk/Source/WebCore/ChangeLog 2016-07-20 01:27:24 UTC (rev 203438)
@@ -1,5 +1,29 @@
2016-07-19 Chris Dumez <[email protected]>
+ Drop SVGElement.xmlbase attribute
+ https://bugs.webkit.org/show_bug.cgi?id=159926
+
+ Reviewed by Benjamin Poulain.
+
+ Drop SVGElement.xmlbase attribute as it is no longer part of the
+ specification:
+ - https://www.w3.org/TR/SVG2/types.html#InterfaceSVGElement
+
+ Both Firefox and Chrome have already dropped support for
+ SVGElement.xmlbase.
+
+ Chrome's intent to remove:
+ https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/TfwMq4d25hk/C-v_iC_wKfAJ
+
+ Test: svg/dom/SVGElement-xmlbase.html
+
+ * svg/SVGElement.cpp:
+ (WebCore::SVGElement::removedFrom): Deleted.
+ * svg/SVGElement.h:
+ * svg/SVGElement.idl:
+
+2016-07-19 Chris Dumez <[email protected]>
+
Align CSSStyleDeclaration.setProperty() with the specification
https://bugs.webkit.org/show_bug.cgi?id=159955
Modified: trunk/Source/WebCore/svg/SVGElement.cpp (203437 => 203438)
--- trunk/Source/WebCore/svg/SVGElement.cpp 2016-07-20 01:20:23 UTC (rev 203437)
+++ trunk/Source/WebCore/svg/SVGElement.cpp 2016-07-20 01:27:24 UTC (rev 203438)
@@ -367,16 +367,6 @@
return DOMImplementation::hasFeature(feature, version);
}
-String SVGElement::xmlbase() const
-{
- return attributeWithoutSynchronization(XMLNames::baseAttr);
-}
-
-void SVGElement::setXmlbase(const String& value, ExceptionCode&)
-{
- setAttributeWithoutSynchronization(XMLNames::baseAttr, value);
-}
-
void SVGElement::removedFrom(ContainerNode& rootParent)
{
bool wasInDocument = rootParent.inDocument();
Modified: trunk/Source/WebCore/svg/SVGElement.h (203437 => 203438)
--- trunk/Source/WebCore/svg/SVGElement.h 2016-07-20 01:20:23 UTC (rev 203437)
+++ trunk/Source/WebCore/svg/SVGElement.h 2016-07-20 01:27:24 UTC (rev 203438)
@@ -53,9 +53,6 @@
public:
bool isOutermostSVGSVGElement() const;
- String xmlbase() const;
- void setXmlbase(const String&, ExceptionCode&);
-
SVGSVGElement* ownerSVGElement() const;
SVGElement* viewportElement() const;
Modified: trunk/Source/WebCore/svg/SVGElement.idl (203437 => 203438)
--- trunk/Source/WebCore/svg/SVGElement.idl 2016-07-20 01:20:23 UTC (rev 203437)
+++ trunk/Source/WebCore/svg/SVGElement.idl 2016-07-20 01:27:24 UTC (rev 203438)
@@ -23,10 +23,6 @@
[
JSGenerateToNativeObject,
] interface SVGElement : Element {
- // FIXME: the xmlbase attribute is no longer part of SVG2 and Chrome already dropped it.
- // FIXME: This should not use [TreatNullAs=LegacyNullString].
- [TreatNullAs=LegacyNullString, SetterRaisesException] attribute DOMString xmlbase;
-
readonly attribute SVGSVGElement ownerSVGElement;
readonly attribute SVGElement viewportElement;
