Title: [203481] trunk/Source/WebCore
- Revision
- 203481
- Author
- beid...@apple.com
- Date
- 2016-07-20 17:15:58 -0700 (Wed, 20 Jul 2016)
Log Message
Address a small FIXME in IDB code.
https://bugs.webkit.org/show_bug.cgi?id=159999
Reviewed by Andy Estes.
No new tests (No behavior change).
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
* Modules/indexeddb/shared/IDBResourceIdentifier.cpp:
(WebCore::IDBResourceIdentifier::IDBResourceIdentifier): Deleted.
* Modules/indexeddb/shared/IDBResourceIdentifier.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (203480 => 203481)
--- trunk/Source/WebCore/ChangeLog 2016-07-20 23:28:33 UTC (rev 203480)
+++ trunk/Source/WebCore/ChangeLog 2016-07-21 00:15:58 UTC (rev 203481)
@@ -1,5 +1,21 @@
2016-07-20 Brady Eidson <beid...@apple.com>
+ Address a small FIXME in IDB code.
+ https://bugs.webkit.org/show_bug.cgi?id=159999
+
+ Reviewed by Andy Estes.
+
+ No new tests (No behavior change).
+
+ * Modules/indexeddb/IDBRequest.cpp:
+ (WebCore::IDBRequest::IDBRequest):
+
+ * Modules/indexeddb/shared/IDBResourceIdentifier.cpp:
+ (WebCore::IDBResourceIdentifier::IDBResourceIdentifier): Deleted.
+ * Modules/indexeddb/shared/IDBResourceIdentifier.h:
+
+2016-07-20 Brady Eidson <beid...@apple.com>
+
Remove some "modernFoo"s from IndexedDB code.
https://bugs.webkit.org/show_bug.cgi?id=159985
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp (203480 => 203481)
--- trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp 2016-07-20 23:28:33 UTC (rev 203480)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp 2016-07-21 00:15:58 UTC (rev 203481)
@@ -72,7 +72,7 @@
IDBRequest::IDBRequest(ScriptExecutionContext& context, IDBClient::IDBConnectionProxy& connectionProxy)
: IDBActiveDOMObject(&context)
- , m_resourceIdentifier(connectionProxy.serverConnectionIdentifier())
+ , m_resourceIdentifier(connectionProxy)
, m_connectionProxy(connectionProxy)
{
suspendIfNeeded();
Modified: trunk/Source/WebCore/Modules/indexeddb/shared/IDBResourceIdentifier.cpp (203480 => 203481)
--- trunk/Source/WebCore/Modules/indexeddb/shared/IDBResourceIdentifier.cpp 2016-07-20 23:28:33 UTC (rev 203480)
+++ trunk/Source/WebCore/Modules/indexeddb/shared/IDBResourceIdentifier.cpp 2016-07-21 00:15:58 UTC (rev 203481)
@@ -52,13 +52,6 @@
{
}
-IDBResourceIdentifier::IDBResourceIdentifier(uint64_t connectionIdentifier)
- : m_idbConnectionIdentifier(connectionIdentifier)
- , m_resourceNumber(nextClientResourceNumber())
-{
-}
-
-
IDBResourceIdentifier::IDBResourceIdentifier(uint64_t connectionIdentifier, uint64_t resourceIdentifier)
: m_idbConnectionIdentifier(connectionIdentifier)
, m_resourceNumber(resourceIdentifier)
Modified: trunk/Source/WebCore/Modules/indexeddb/shared/IDBResourceIdentifier.h (203480 => 203481)
--- trunk/Source/WebCore/Modules/indexeddb/shared/IDBResourceIdentifier.h 2016-07-20 23:28:33 UTC (rev 203480)
+++ trunk/Source/WebCore/Modules/indexeddb/shared/IDBResourceIdentifier.h 2016-07-21 00:15:58 UTC (rev 203481)
@@ -47,10 +47,6 @@
IDBResourceIdentifier(const IDBClient::IDBConnectionProxy&, const IDBRequest&);
explicit IDBResourceIdentifier(const IDBServer::IDBConnectionToClient&);
- // FIXME: This constructor will be needed during the development of IDB-in-Workers.
- // It should be removed when no longer necessary.
- explicit IDBResourceIdentifier(uint64_t connectionIdentifier);
-
static IDBResourceIdentifier deletedValue();
WEBCORE_EXPORT bool isHashTableDeletedValue() const;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
