Title: [203502] trunk/Source/WebCore
Revision
203502
Author
[email protected]
Date
2016-07-21 06:03:16 -0700 (Thu, 21 Jul 2016)

Log Message

[GTK] The GSTREAMER_GL path in MediaPlayerPrivateGStreamerBase::paintToTextureMapper() is missing a mutex lock
https://bugs.webkit.org/show_bug.cgi?id=160018

Patch by Miguel Gomez <[email protected]> on 2016-07-21
Reviewed by Philippe Normand.

Lock the video sample mutex while accessing it.

Covered by existent tests.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (203501 => 203502)


--- trunk/Source/WebCore/ChangeLog	2016-07-21 11:36:08 UTC (rev 203501)
+++ trunk/Source/WebCore/ChangeLog	2016-07-21 13:03:16 UTC (rev 203502)
@@ -1,5 +1,19 @@
 2016-07-21  Miguel Gomez  <[email protected]>
 
+        [GTK] The GSTREAMER_GL path in MediaPlayerPrivateGStreamerBase::paintToTextureMapper() is missing a mutex lock
+        https://bugs.webkit.org/show_bug.cgi?id=160018
+
+        Reviewed by Philippe Normand.
+
+        Lock the video sample mutex while accessing it.
+
+        Covered by existent tests.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+        (WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper):
+
+2016-07-21  Miguel Gomez  <[email protected]>
+
         [Threaded Compositor] Flickering when zooming in/out in maps.google.com
         https://bugs.webkit.org/show_bug.cgi?id=154069
 

Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (203501 => 203502)


--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp	2016-07-21 11:36:08 UTC (rev 203501)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp	2016-07-21 13:03:16 UTC (rev 203502)
@@ -659,6 +659,8 @@
     }
 
 #if USE(GSTREAMER_GL)
+    WTF::GMutexLocker<GMutex> lock(m_sampleMutex);
+
     GstVideoInfo videoInfo;
     if (!getSampleVideoInfo(m_sample.get(), videoInfo))
         return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to