Title: [203507] trunk/Source/WebKit2
- Revision
- 203507
- Author
- [email protected]
- Date
- 2016-07-21 09:59:33 -0700 (Thu, 21 Jul 2016)
Log Message
Web Automation: Allow _javascript_ evaluation to return an InvalidElementState error
https://bugs.webkit.org/show_bug.cgi?id=160015
<rdar://problem/27434529>
Patch by Joseph Pecoraro <[email protected]> on 2016-07-21
Reviewed by Brian Burg.
* UIProcess/Automation/Automation.json:
* WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::WebAutomationSessionProxy::evaluateJavaScriptFunction):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (203506 => 203507)
--- trunk/Source/WebKit2/ChangeLog 2016-07-21 16:21:25 UTC (rev 203506)
+++ trunk/Source/WebKit2/ChangeLog 2016-07-21 16:59:33 UTC (rev 203507)
@@ -1,3 +1,15 @@
+2016-07-21 Joseph Pecoraro <[email protected]>
+
+ Web Automation: Allow _javascript_ evaluation to return an InvalidElementState error
+ https://bugs.webkit.org/show_bug.cgi?id=160015
+ <rdar://problem/27434529>
+
+ Reviewed by Brian Burg.
+
+ * UIProcess/Automation/Automation.json:
+ * WebProcess/Automation/WebAutomationSessionProxy.cpp:
+ (WebKit::WebAutomationSessionProxy::evaluateJavaScriptFunction):
+
2016-07-21 Carlos Garcia Campos <[email protected]>
[GTK][Threaded Compositor] WTR generates fully white images for pixel tests most of the time
Modified: trunk/Source/WebKit2/UIProcess/Automation/Automation.json (203506 => 203507)
--- trunk/Source/WebKit2/UIProcess/Automation/Automation.json 2016-07-21 16:21:25 UTC (rev 203506)
+++ trunk/Source/WebKit2/UIProcess/Automation/Automation.json 2016-07-21 16:59:33 UTC (rev 203507)
@@ -53,6 +53,7 @@
"WindowNotFound",
"FrameNotFound",
"NodeNotFound",
+ "InvalidElementState",
"NoJavaScriptDialog",
"NotImplemented",
"MissingParameter",
Modified: trunk/Source/WebKit2/WebProcess/Automation/WebAutomationSessionProxy.cpp (203506 => 203507)
--- trunk/Source/WebKit2/WebProcess/Automation/WebAutomationSessionProxy.cpp 2016-07-21 16:21:25 UTC (rev 203506)
+++ trunk/Source/WebKit2/WebProcess/Automation/WebAutomationSessionProxy.cpp 2016-07-21 16:59:33 UTC (rev 203507)
@@ -271,6 +271,8 @@
JSRetainPtr<JSStringRef> exceptionName(Adopt, JSValueToStringCopy(context, nameValue, nullptr));
if (exceptionName->string() == "NodeNotFound")
errorType = Inspector::Protocol::AutomationHelpers::getEnumConstantValue(Inspector::Protocol::Automation::ErrorMessage::NodeNotFound);
+ else if (exceptionName->string() == "InvalidElementState")
+ errorType = Inspector::Protocol::AutomationHelpers::getEnumConstantValue(Inspector::Protocol::Automation::ErrorMessage::InvalidElementState);
JSValueRef messageValue = JSObjectGetProperty(context, const_cast<JSObjectRef>(exception), toJSString(ASCIILiteral("message")).get(), nullptr);
exceptionMessage.adopt(JSValueToStringCopy(context, messageValue, nullptr));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
